From: Markus Elfring <Markus.Elfring@web.de>
To: Thomas Fourier <fourier.thomas@gmail.com>,
linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com,
Duane Grigsby <duane.grigsby@marvell.com>,
Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Larry Wisneski <Larry.Wisneski@marvell.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Quinn Tran <qutran@marvell.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: edif: Fix dma_free_coherent() size
Date: Mon, 12 Jan 2026 15:12:54 +0100 [thread overview]
Message-ID: <4b22eead-086a-43e5-99f5-f2ce609b1567@web.de> (raw)
In-Reply-To: <20260112134326.55466-2-fourier.thomas@gmail.com>
> Earlier in the function, the ha->flt buffer is allocated with size
> sizeof(struct qla_flt_header) + FLT_REGIONS_SIZE but freed in the error
> path with size SFP_DEV_SIZE.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n94
You should probably not only specify message recipients in the header field “Cc”.
…
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4489,7 +4489,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
> fail_elsrej:
> dma_pool_destroy(ha->purex_dma_pool);
> fail_flt:
> - dma_free_coherent(&ha->pdev->dev, SFP_DEV_SIZE,
> + dma_free_coherent(&ha->pdev->dev, sizeof(struct qla_flt_header) + FLT_REGIONS_SIZE,
> ha->flt, ha->flt_dma);
…
How do you think about to adjust the indentation another bit for the passed parameters?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n110
Regards,
Markus
next prev parent reply other threads:[~2026-01-12 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 13:43 Thomas Fourier
2026-01-12 14:12 ` Markus Elfring [this message]
2026-01-12 15:01 ` Greg KH
2026-01-24 3:53 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b22eead-086a-43e5-99f5-f2ce609b1567@web.de \
--to=markus.elfring@web.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Larry.Wisneski@marvell.com \
--cc=duane.grigsby@marvell.com \
--cc=fourier.thomas@gmail.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®