From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9828DC4360C for ; Thu, 10 Oct 2019 20:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61536208C3 for ; Thu, 10 Oct 2019 20:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727433AbfJJUsn (ORCPT ); Thu, 10 Oct 2019 16:48:43 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:38196 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725867AbfJJUsn (ORCPT ); Thu, 10 Oct 2019 16:48:43 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 88169781C; Thu, 10 Oct 2019 20:48:41 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: dolls38_4b7237beba646 X-Filterd-Recvd-Size: 2857 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Thu, 10 Oct 2019 20:48:38 +0000 (UTC) Message-ID: <4b2ed594c5054138562c80cc94dee8b5398c9064.camel@perches.com> Subject: Re: [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways From: Joe Perches To: Kees Cook Cc: Miguel Ojeda , Linus Torvalds , linux-kernel , Borislav Petkov , "H . Peter Anvin" , Thomas Gleixner , Pavel Machek , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Nathan Chancellor , Nick Desaulniers , Andrew Morton , David Miller , clang-built-linux Date: Thu, 10 Oct 2019 13:48:37 -0700 In-Reply-To: <201910101338.59F36A33@keescook> References: <4a904777303fbaea75fe0875b7984c33824f4b68.1570292505.git.joe@perches.com> <52794b248ba13e88ab4c30c9b6ea55a7be30df5d.camel@perches.com> <201910101338.59F36A33@keescook> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-10-10 at 13:39 -0700, Kees Cook wrote: > On Sat, Oct 05, 2019 at 11:35:42PM -0700, Joe Perches wrote: [] > > I think clang-format could not do this sort of conversion. > > Nor could coccinelle or checkpatch. > > > > Anyway, it's not really necessary for this particular patch > > to be applied, but it's a convenient way to show the script > > has the capability to do fallthrough comment conversions. > > > > I think it does conversions fairly reasonably but likely > > some files could not compile without adding an #include > > like: > > > > #include > > I think this is a nice tool to add -- at the very least it serves as > infrastructure for future similar conversions. And small cleanups can be > generated from it for people looking to clean up subsystems, etc. Another similar tool that used checkpatch and also compile tested and created git commits was reformat_with_checkpatch https://lore.kernel.org/lkml/1405128087.6751.12.camel@joe-AO725/