mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Justin Ernst <justin.ernst@hpe.com>, Borislav Petkov <bp@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Tom Rix <trix@redhat.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Mike Travis <mike.travis@hpe.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv
Date: Thu, 4 Mar 2021 12:55:49 +0100	[thread overview]
Message-ID: <4b30e296-e4d2-c8af-a920-72a09932d3d1@redhat.com> (raw)
In-Reply-To: <20210219172835.253610-1-justin.ernst@hpe.com>

Hi,

On 2/19/21 6:28 PM, Justin Ernst wrote:
> commit c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
> 
> misplaced the first line of a codeblock section, causing the reported
> warning message:
> Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected indentation.
> 
> Move the misplaced line below the required blank line to remove the
> warning message.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: c9624cb7db1c ("x86/platform/uv: Update sysfs documentation")
> Acked-by: Mike Travis <mike.travis@hpe.com>
> Signed-off-by: Justin Ernst <justin.ernst@hpe.com>

Thank you for the patch.

Since this documentation documents the interface exposed by:
drivers/platform/x86/uv_sysfs.c

I've applied this patch to the pdx86 tree now:

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  Documentation/ABI/testing/sysfs-firmware-sgi_uv | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-firmware-sgi_uv b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> index 637c668cbe45..12ed843e1d3e 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> +++ b/Documentation/ABI/testing/sysfs-firmware-sgi_uv
> @@ -39,8 +39,8 @@ Description:
>  
>  		The uv_type entry contains the hub revision number.
>  		This value can be used to identify the UV system version::
> -			"0.*" = Hubless UV ('*' is subtype)
>  
> +			"0.*" = Hubless UV ('*' is subtype)
>  			"3.0" = UV2
>  			"5.0" = UV3
>  			"7.0" = UV4
> 


       reply	other threads:[~2021-03-04 11:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210219172835.253610-1-justin.ernst@hpe.com>
2021-03-04 11:55 ` Hans de Goede [this message]
2021-03-04 11:59   ` Borislav Petkov
2021-03-04 12:00     ` Hans de Goede
2021-02-19 18:28 Justin Ernst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b30e296-e4d2-c8af-a920-72a09932d3d1@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bp@suse.de \
    --cc=justin.ernst@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=sfr@canb.auug.org.au \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®