From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF8C5474F for ; Tue, 18 Aug 2026 22:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787092359; cv=none; b=s941SWk+NnKdHbtO59L9Fpbwjsaw7NnWq2YCEBwcuZTmYbMW8kU9bo2nwmu3p7IEIvyqP9DlKZLlSmVZPNQLV3khbuKEP4fE1LHkTgGTDanR02ba7nzz9VKOgqtOFzwqh71DsKz+HfquEYk0uyqQvOouYKd9EMp3kPmPA+2sb3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787092359; c=relaxed/simple; bh=oyr9QqenMsH5pv2u1c3RiRjwxPJFG3O0LEoisWdbulk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=PcIhMONWQ7y5iTkVmi3leYfqAEffLhWHitB8wQulEue4ZvTbqeDbhEZnZGEzjcKekp+Sif0YUiUevjTowY1ffHknFeXveoWoMQfzvtANP0eDSV5c2xS1SyLMK/RG5bcemCDo5wRJyrmZ34IwxKSmU4s2lo8nlCQRJ24EkVz3Pts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZxNiJbW+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lIbDRGwG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZxNiJbW+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lIbDRGwG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787092356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Riz2A5UuSViG3JVLoC0bGAkxf2EfZnfcPl3QvTwCNF0=; b=ZxNiJbW+MZS6SXPkM+VnQTKuytghYgmPskqNT8d/lBO9ALeCrJDAVBIXHF0Bo903y2jD93 6rlpVY4bXxLC2+TZ43XeDuSxeYTYEkPYVhlnObB9JvX8PcLvUMPDvCdrNzfwfCCgXGhhcy dgQVP0Ei9ZjtwBUoo30cTl9miO2+hxY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-6zAuipJHOAGSogxGti-FNg-1; Tue, 18 Aug 2026 18:32:35 -0400 X-MC-Unique: 6zAuipJHOAGSogxGti-FNg-1 X-Mimecast-MFC-AGG-ID: 6zAuipJHOAGSogxGti-FNg_1787092354 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51a8db414c7so4973911cf.0 for ; Tue, 18 Aug 2026 15:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787092354; x=1787697154; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Riz2A5UuSViG3JVLoC0bGAkxf2EfZnfcPl3QvTwCNF0=; b=lIbDRGwGnXiLrpLLcqW0cnPKp32GoWwIC0owIFYug7wKG7Rgf0FTSexzR9ufLJEMKy O7cW7WlJH+FvZ9auYXj0DSHr5PiaOKeezSdTRqv5NW+UyYTCfDTvK6Xbe7u/ks81tcgM uV+nMU4UO1lgGxQ2wcFq6s5n4nTZQNtJiKW0Vsb1MrYyQNGS6JPLjov8VChVwQOJl8xw jIkRwK9J3hvqVGFCqM+ELRveanVYbpnQ0qAIbDBbahxSrJcx2Ql/KftQ46ldBanatr7/ 8+IEoUFo6Q9BmJxqqwCk1Ed0kvASNvPI1/bSxTlZkvDel+B+1+V3iKUvLsYACFxZGVU7 yUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787092354; x=1787697154; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Riz2A5UuSViG3JVLoC0bGAkxf2EfZnfcPl3QvTwCNF0=; b=fQp9YzqUcPdzgmcP1ObwV/DxehpSRBGxEZ219JsEwm7VTPasDPYKIaBeiAvuvJMuUJ XmjzuscwXIi1Plzpi9XZ/IT0j/XFVQ4eW4w0Z+mFnEHWuTG374nk7MJ5xE/wqGDQuQwc 7GZENBLMsUioZtzrBVSbXcImuCd7ILKFgAM0edWEjtmfuSFtgfkJ7YnhCjlOTWr/c0z+ z+uOK+TSR01DKjmD2b21d7yRdapEcJHdCmEeEtcN5OmccPsErnxgZCiPem1uyLURTIeD 4F1G2OyZp7iLWWqGxBKi0fLSxafpW5NbiIpL0gPveMqKVa6oRLINgFm1Tg35zS+OFb/g 18nw== X-Gm-Message-State: AOJu0Yz9b5Saeu6xWtpuOPMq8xzrYIKhS10hvfvf3jEFhIssH8SlRBjR wFuzSaPKeM+8zsJHJ/HfFpV7FmxS+7WDWiZLuB0J+zkkUHc5Gz5UGUEqBfh4xUwmI1HThwkhj5w +m1wxKl63tpMeUoCvKhG5c3DpRJyP9K22ZTh/rw4jnWtqm1VjzvnxWQ1JGQ6Mvfy9gw== X-Gm-Gg: AR+sD13BLXQqk71C9u1DEVGWP+bjt6+KyGDg/HIjjV25KJU3W4HW8i8e0tsIrPvKgir ZETqgg9zmSXn9ZAQ6DCC0VJx4O7SM2L8Dq0j+l0h9g1S9ezzGEhOxGPG9+pMpLkRP6DQSA7+arP nHfxgPHbpBxz8Pfp+BeM8qnLASzDXL6ICuwaTwxHD+eafAhKqwUajxdXTNjeDdio+jfIX58HLC5 4/WHh+p/lIPGJmX7bTza3iZr9dwQEfnMQL0huOExwmyAifHJXLKfymD3iuYI34+bMqn9LOrm3J3 6SYC7b7olXMkjDpxgae0c1XyNPrDpcKtfaX7XSJC8DJuX1lvzYsOKNcJv0MR/GUlUHGKaYw/ X-Received: by 2002:ac8:7f41:0:b0:52d:918b:92e9 with SMTP id d75a77b69052e-52dd5cb02b9mr4146941cf.33.1787092354677; Tue, 18 Aug 2026 15:32:34 -0700 (PDT) X-Received: by 2002:ac8:7f41:0:b0:52d:918b:92e9 with SMTP id d75a77b69052e-52dd5cb02b9mr4146391cf.33.1787092354173; Tue, 18 Aug 2026 15:32:34 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52db60eb025sm49583821cf.5.2026.08.18.15.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 15:32:32 -0700 (PDT) Message-ID: <4b354d80857386b0dfb4b38615d707f6da65b66a.camel@redhat.com> Subject: Re: [PATCH v4 2/2] drm/nouveau/kms: guard NULL crtc in nv50_sor_atomic_disable() From: lyude@redhat.com To: Marek Czernohous , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Danilo Krummrich , David Airlie , Simona Vetter Date: Tue, 18 Aug 2026 18:32:32 -0400 In-Reply-To: References: <178688574400.522643.6695278742335367229@gmail.com> <178688574402.522643.5471719764843371376@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-08-18 at 16:44 -0400, lyude@redhat.com wrote: > > + * .atomic_enable (and by the boot-time hardware readback) > > and >=20 > We don't set nv_encoder->crtc at the boot-time hardware state > readback. ...this was wrong, oops!