From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, "Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Clément Léger" <clement.leger@bootlin.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 2/2] net: dsa: rzn1_a5psw: use devm to enable clocks
Date: Mon, 7 Jul 2025 07:56:28 +0200 [thread overview]
Message-ID: <4b372f0d-0eda-47b7-a947-1932e61fa28a@lunn.ch> (raw)
In-Reply-To: <20250707003918.21607-3-rosenp@gmail.com>
On Sun, Jul 06, 2025 at 05:39:18PM -0700, Rosen Penev wrote:
> The remove function has these in the wrong order. The switch should be
> unregistered last. Simpler to use devm so that the right thing is done.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-07-07 5:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 0:39 [PATCH 0/2] net: dsa: rzn1_a5psw: add COMPILE_TEST Rosen Penev
2025-07-07 0:39 ` [PATCH 1/2] " Rosen Penev
2025-07-07 5:55 ` Andrew Lunn
2025-07-07 6:01 ` Andrew Lunn
2025-07-07 20:25 ` kernel test robot
2025-07-07 20:47 ` Rosen Penev
2025-07-07 21:33 ` Vladimir Oltean
2025-07-07 0:39 ` [PATCH 2/2] net: dsa: rzn1_a5psw: use devm to enable clocks Rosen Penev
2025-07-07 5:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b372f0d-0eda-47b7-a947-1932e61fa28a@lunn.ch \
--to=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®