From: Andrew Lunn <andrew@lunn.ch>
To: "G Thomas, Rohan" <rohan.g.thomas@altera.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH net-next] net: phy: marvell: Fix 88e1510 downshift counter errata
Date: Tue, 2 Sep 2025 17:08:39 +0200 [thread overview]
Message-ID: <4b3e4339-93d5-4d14-b53f-43c5d379d2fa@lunn.ch> (raw)
In-Reply-To: <7b799cb3-ba9f-464e-a0a6-cad151742aab@altera.com>
> > Also, what is a "link power down/up" ? Are you referring to setting
> > BMCR_PDOWN and then clearing it? (please update the commit description
> > and repost after 24 hours, thanks.)
> >
>
> Yes, I'm referring to setting and the clearing BMCR_PDOWN. Will update
> the commit description in the next version.
So it could be the bootloader left the PHY in powered down state, when
booting.
There is some not so nice logic in phy_attach_direct() which calls
phy_resume() when the MAC attaches to the PHY. So this case is covered
by that. But it would be good to comment in the commit message, and
maybe the resume function, that you are relying on this behaviour.
I do wounder if it should be more explicit, m88e1510_config_init()
also calls the workaround? You would then not need the comment.
Andrew
next prev parent reply other threads:[~2025-09-02 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 5:59 Rohan G Thomas via B4 Relay
2025-09-02 12:41 ` Andrew Lunn
2025-09-02 13:35 ` Russell King (Oracle)
2025-09-02 14:45 ` G Thomas, Rohan
2025-09-02 15:08 ` Andrew Lunn [this message]
2025-09-03 4:07 ` G Thomas, Rohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b3e4339-93d5-4d14-b53f-43c5d379d2fa@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthew.gerlach@altera.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®