From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
johan+linaro@kernel.org, steev@kali.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH 3/4] ASoC: codecs: wsa883x: mute/unmute PA in correct sequence
Date: Fri, 24 Mar 2023 06:43:40 +0000 [thread overview]
Message-ID: <4b448582-fe11-7f24-36ac-16fd8a22c139@linaro.org> (raw)
In-Reply-To: <101cfc2d-59d7-4f37-9dd1-e83d1b803bc5@sirena.org.uk>
On 24/03/2023 00:14, Mark Brown wrote:
> On Thu, Mar 23, 2023 at 01:11:11PM -0500, Pierre-Louis Bossart wrote:
>
>>> The trigger is run in atomic context, can you really write safely to a
>>> SoundWire device there?
>
>> Mark, I've seen that comment from you several times, and I wonder if I
>> am missing something: the triggers for SoundWire managers and dailinks
>> are typically nonatomic - at least for the Cadence-based solution the
>> trigger is based on a bank switch that may happen with a delay and with
>> a wait_for_completion(). Sending a command over the SoundWire channel is
>> also typically not atomic, there's usually a wait_for_completion() as well.
>
> Ah, you're setting the nonatomic flag on your links to disable the
> locking. The default for trigger operations is to run them with local
> interrupts disabled. It looks like at least some of the Qualcomm stuff
> does that too.
Yes, by default dailinks are marked as nonatomic in Qualcomm case aswell.
--srini
next prev parent reply other threads:[~2023-03-24 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:43 [PATCH 0/4] ASoC: qcom: fixes for Click/Pop Noise Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 1/4] ASoC: qcom: q6apm-lpass-dai: close graphs before opening a new one Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 2/4] ASoC: qcom: sdw: do not restart soundwire ports for every prepare Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 3/4] ASoC: codecs: wsa883x: mute/unmute PA in correct sequence Srinivas Kandagatla
2023-03-23 17:07 ` Mark Brown
2023-03-23 18:11 ` Pierre-Louis Bossart
2023-03-24 0:14 ` Mark Brown
2023-03-24 6:43 ` Srinivas Kandagatla [this message]
2023-03-24 6:44 ` Srinivas Kandagatla
2023-10-25 7:57 ` Johan Hovold
2023-10-25 12:36 ` Mark Brown
2023-10-25 12:43 ` Johan Hovold
2023-10-26 13:05 ` Mark Brown
2023-10-26 13:55 ` Johan Hovold
2023-10-27 10:51 ` Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 4/4] ASoC: codecs: wsa881x: " Srinivas Kandagatla
2023-04-06 15:03 ` (subset) [PATCH 0/4] ASoC: qcom: fixes for Click/Pop Noise Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b448582-fe11-7f24-36ac-16fd8a22c139@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=steev@kali.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®