From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Val Packett <val@packett.cool>,
Sebastian Reichel <sre@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] power: supply: qcom_battmgr: clamp charge control thresholds
Date: Mon, 13 Oct 2025 11:43:04 +0200 [thread overview]
Message-ID: <4b4ca560-d8e8-4d89-a02c-02d4245ccc37@oss.qualcomm.com> (raw)
In-Reply-To: <20251012233333.19144-3-val@packett.cool>
On 10/13/25 1:32 AM, Val Packett wrote:
> The sysfs API documentation says that drivers "round written values to
> the nearest supported value" for charge_control_end_threshold.
>
> Let's do this for both thresholds, as userspace (e.g. upower) generally
> does not expect these writes to fail at all.
The documentation says so only for the upper bound. You should
probably submit a patch to amend the lower one as well
Konrad
next prev parent reply other threads:[~2025-10-13 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-12 23:32 [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling Val Packett
2025-10-12 23:32 ` [PATCH 1/2] power: supply: qcom_battmgr: clamp charge control thresholds Val Packett
2025-10-13 9:43 ` Konrad Dybcio [this message]
2025-10-12 23:32 ` [PATCH 2/2] power: supply: qcom_battmgr: support disabling charge control Val Packett
2025-11-17 5:22 ` Fenglin Wu
2025-11-03 0:48 ` [PATCH 0/2] power: supply: qcom_battmgr: improve charge control threshold handling Sebastian Reichel
2025-11-03 3:46 ` Val Packett
2025-11-03 14:41 ` Sebastian Reichel
2025-11-17 5:12 ` Fenglin Wu
2025-11-17 12:45 ` Konrad Dybcio
2025-11-18 2:29 ` Fenglin Wu
2025-11-18 10:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4ca560-d8e8-4d89-a02c-02d4245ccc37@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®