From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 176ED33F5B4 for ; Sun, 12 Jul 2026 16:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783872466; cv=none; b=rfbVZqzG200YkkOOicvT1iJ3v5/zZw6lAIX5K5DSV82EZKeIgoxBuqv9FbHa1hiIPl0aQef6YuyaIpMB6K7xpiJIwcP7GGsBr37Dw8omQxLCiBFeQ2JNYdKGbAMq6FaWvQfoO9CL3To1gez2/9T3wfB/4h2hG4v6BXqhEEBoGW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783872466; c=relaxed/simple; bh=/Lvsg/ZJR/lfpgoUMIiOWitMqmPb9MoVhYs6ClRrfg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jufNjZYR9Ql82O033BBmhmp0pu7ErULs7cBxUKi8T0Ply7VbyzzBaEDX/xnS3FBoR7zJjOfDZ6fIHmid33rcpR2quyOpFTy77glaLuT/rrFfaQgjxSAH2xQarxNIeV9/WyHRVupWaQrQ1xo+BK8G+MfhVyaCvetKjysDx4UymqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=bS5NqABn; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="bS5NqABn" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-44ae14b4fd6so1028017fac.2 for ; Sun, 12 Jul 2026 09:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783872463; x=1784477263; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uVpYadVTuJ7Oa9ZoTB5rgj6lqcEBWKLs7QhoK6MvLlk=; b=bS5NqABnb3IrzzCXGNzFQUFOq3VQgzYZKi+bhB+usfs5AjjguDll7xUPIPvq64mD+Y VZCN/PjROGVKPdWskoa3068iA253zDh6Da6mCDh1pmmOmmySOw6I/CaQJSJplgpIjCen xmIBp3/rG2TOu1xICOgMeFMyFYM/DvtqqkvMlVdqKvZdlxNNpI5C61GK/EblxEzFp6Ju RyzT4/IhGjkMraU9Y+u0RF6oYavekZxC9fxJJPcDFi+pL2pxXpDnrL3dQyR+ktGLQaKM uAds6MENRCW2CHoKYKDEt4MGjsE5YTeZnfPU0dGZZ4W3Tp3KXR2oep2ud39/+RsWx+1j qK3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783872463; x=1784477263; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uVpYadVTuJ7Oa9ZoTB5rgj6lqcEBWKLs7QhoK6MvLlk=; b=l19Pv5pPU5pP0k9LvSfgqzpiL1A3dyEihvmQfyh2Ghae9Cd9x7zMHc6tRYpbrhhexK 9G8jR7up+5T+iE9PV081Xdr8x4N3UYYgsnxnl6bxUpQz4To0PRyHglUC5hFCZ5fi0v0r Du5lLwOMISME7YKarsxOg0KUEcuSCT8tt5+UD56hpVbSm9citnML1R6dPC7tfJ6AOyX8 sz8FhAB9eGsBAhtdHzxrjrplc1nCzSb5eywNsSeSO9Dy09Xv/aq4J1qDftxRL5Fo8tBM iIx56JUJY4hsNmKm4Wyfy9QJ13GT0PtTuWW7DwLLzIcdstmuRu+dENWT4ol9DWRWqp+h PmjQ== X-Forwarded-Encrypted: i=1; AFNElJ85ETb86/phPfhVVHPBbD3fI9pUpI+eS54FQ6x6H3wYn6aPt+Vqx/aNojbjqmxHf6jIlaNluh9orgxtI0s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6FzQTxTtwtoY2J3yW4UJgtXV7kfW4zoqC0Y17culgkEKL5rDu qBj4Ue6LQAxkntugsvRgc/Srr94JGl68nPK1OEPgwiXBGtLWm6vGA1T/efkyyVoPB10= X-Gm-Gg: AfdE7cmJpl1pr/2f3yvtbq7szxuJRQlnsHRbOGAwFds/gslR2/hAuIRaDHIXEYfvbPq R7VKW2nHyuSm6/KNLEwhZ7Gusc2kZDRCnnbvm0YNNHyMmHJwgfRzcYY9GpcWs/g+MaB6d89f/4l 327T3oyoKp3peqhm16vxSL3e1WkdlYmcLYFhdHvXMUSwR0H2U5oTcc3EMPjOvqs2aMh0w8Kvjg4 Q28MmeL0A32AMLZmRm20g+n0sf8bKTmsRt8pakaQFGADt5UFC2lPPKQyxBc8Xxl57LmLDcG/0gf HEiZe/hjt4oh1EWv6aAVjMuLEfTKoaLYRNNXj91trxxxMr+uuSRq0b3xFxt5m6GOz3wItLNmIxC nnoI4GLykjA7NvuHGDBXpE5LS2UD/xI/ozZnyFdi+feIoDiW+ewDJJSuNfE834dHmphcFQAQxU8 /oRbWgFnJsEPibwqx3OCKhgoQRlQIDrGdahUYVgMsP/f6N5kGuLm+ouASR6EEUhl8= X-Received: by 2002:a05:6870:e187:b0:449:a0db:5917 with SMTP id 586e51a60fabf-451f1445225mr2893250fac.41.1783872462881; Sun, 12 Jul 2026 09:07:42 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3af7:75b0:bf02:8cf8? ([2600:8803:e7e4:500:3af7:75b0:bf02:8cf8]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-455c73a335esm321788fac.12.2026.07.12.09.07.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2026 09:07:41 -0700 (PDT) Message-ID: <4b548db9-323c-4754-8e91-26ce94669600@baylibre.com> Date: Sun, 12 Jul 2026 11:07:40 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 To: Jonathan Cameron Cc: Janani Sunil , =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, jananisunil.dev@gmail.com References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-1-44e1194fd96a@analog.com> <36df7c4f-82ea-4ed5-a4f9-3a29c75dc99a@baylibre.com> <20260710013322.595f8ee4@jic23-huawei> <20260712023918.119fbecd@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260712023918.119fbecd@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/11/26 8:39 PM, Jonathan Cameron wrote: > On Sat, 11 Jul 2026 09:40:32 -0500 > David Lechner wrote: > >> On 7/9/26 7:33 PM, Jonathan Cameron wrote: >>>>> + adi,common-mode-output: >>>>> + $ref: /schemas/types.yaml#/definitions/string >>>>> + enum: >>>>> + - avdd-avss-half >>>>> + - 1.65V >>>>> + - 2.5V >>>>> + - 2.14V >>>>> + description: >>>>> + Common mode voltage output selection. >>>> >>>> Why not using standard regulator provider bindings for this? >>> >>> Interesting question. If that was done there would need to be >>> a consumer which means explicit modelling of any analog circuit. >>> We do that in a few cases but so far (and yup this is a driver thing >>> in a dt-binding) I don't think we have any way to consumer data when >>> a backend is involved. >> >> There is also the regulator-always-on property, so strictly speaking, >> a consumer is not required. > > Makes some sense I guess. > > How would the voltage be controlled? Set min and max to same value? yes > > J >> >>> >>>> >>>>> + >>>>> + adi,vcm-power-down: >>>>> + type: boolean >>>>> + description: Power down the common mode output buffer >>>> >>>> Is the buffer separate from the output? In that case I would expect >>>> buffer to be in the property name, otherwise this should just be >>>> part of the enum options above (and the default one at that). >>>> >> >