From: Johannes Berg <johannes@sipsolutions.net>
To: Hillf Danton <hdanton@sina.com>
Cc: Ben Greear <greearb@candelatech.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
linux-mm@kvack.org, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: 6.18.13 iwlwifi deadlock allocating cma while work-item is active.
Date: Wed, 04 Mar 2026 07:57:01 +0100 [thread overview]
Message-ID: <4b5584f3277d667bead0b851c5bdc5cc07e80183.camel@sipsolutions.net> (raw)
In-Reply-To: <20260304030835.610-1-hdanton@sina.com>
On Wed, 2026-03-04 at 11:08 +0800, Hillf Danton wrote:
> >
> > Fair. I don't know, I don't think there's anything that even shows that
> > there's a dependency between the two workqueues and the
> > "((wq_completion)events_unbound)" and "((wq_completion)events)", and
> > there would have to be for it to deadlock this way because of that?
> >
> Given the locks held [1],
>
> kworker/1:0/39480 kworker/u32:11/34989
> rtnl_mutex
> &rdev->wiphy.mtx
> __lru_add_drain_all
> flush_work(&per_cpu(lru_add_drain_work, cpu))
> &rdev->wiphy.mtx
>
> __if__ there is one work item queued __before__ one of the flush targets on
> workqueue and it acquires the rtnl mutex, then no deadlock can rise,
> because worker-xyz gets off CPU due to failing to take the rtnl lock then
> worker-xyz+1 dequeus the flush target and completes it due to nothing
> with rtnl. Same applies to the wiphy lock.
Right.
> BTW any chance for queuing work that acquires rtnl lock on mm_percpu_wq?
There really is only the work I was describing and vmstat_work (calling
vmstat_update) on that workqueue, afaict.
johannes
prev parent reply other threads:[~2026-03-04 6:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa4e82ee-eb14-3930-c76c-f3bd59c5f258@candelatech.com>
2026-02-26 18:40 ` Fwd: " Ben Greear
[not found] ` <18c4bfed-caca-bef3-a139-63d7fa48940a@candelatech.com>
[not found] ` <e7d92fab-9d0e-4a58-aa0b-2c6545772e68@candelatech.com>
[not found] ` <3456b2c89f057900b39ce79ea8ca1154c5014e43.camel@sipsolutions.net>
[not found] ` <0de6c8d1-d2fa-44ac-8025-cfcfecd87b02@candelatech.com>
[not found] ` <bed9cc03d3c214b2601093f91e4b00f3715762b2.camel@sipsolutions.net>
[not found] ` <c616fc41-3bc7-4ddc-b65c-a622111d8548@candelatech.com>
2026-03-03 11:49 ` Johannes Berg
2026-03-03 20:52 ` Tejun Heo
2026-03-03 21:03 ` Johannes Berg
2026-03-03 21:12 ` Johannes Berg
2026-03-03 21:40 ` Ben Greear
2026-03-03 21:54 ` Tejun Heo
2026-03-04 0:02 ` Ben Greear
2026-03-04 17:14 ` Tejun Heo
2026-03-10 16:10 ` Ben Greear
2026-03-10 18:06 ` Tejun Heo
2026-03-10 19:18 ` Ben Greear
2026-03-10 19:47 ` Tejun Heo
2026-03-10 19:48 ` Tejun Heo
2026-03-04 3:08 ` Hillf Danton
2026-03-04 6:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5584f3277d667bead0b851c5bdc5cc07e80183.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®