From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
likexu@tencent.com, Yang Weijiang <weijiang.yang@intel.com>
Subject: Re: [PATCH 1/2] KVM: vmx, pmu: accept 0 for absent MSRs when host-initiated
Date: Wed, 1 Jun 2022 10:54:11 +0200 [thread overview]
Message-ID: <4b59b1c0-112b-5e07-e613-607220c3b597@redhat.com> (raw)
In-Reply-To: <YpZgU+vfjkRuHZZR@google.com>
On 5/31/22 20:37, Sean Christopherson wrote:
>> +
>> /*
>> * Writing depth MSR from guest could either setting the
>> * MSR or resetting the LBR records with the side-effect.
>> @@ -535,6 +542,8 @@ static int intel_pmu_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>> case MSR_ARCH_LBR_CTL:
>> if (!arch_lbr_ctl_is_valid(vcpu, data))
>> break;
>> + if (!guest_cpuid_has(vcpu, X86_FEATURE_ARCH_LBR))
>> + return 0;
>
> Similar bug here.
>
> Can we just punt this out of kvm/queue until its been properly reviewed?
Yes, I agree. I have started making some changes and pushed the result
to kvm/arch-lbr-for-weijiang.
Most of the MSR handling is rewritten (and untested).
The nested VMX handling was also completely broken so I just removed it.
Instead, KVM should be adjusted so that it does not whine.
Paolo
next prev parent reply other threads:[~2022-06-01 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 17:54 [PATCH 0/2] KVM: vmx, pmu: respect KVM_GET_MSR_INDEX_LIST/KVM_SET_MSR contracts Paolo Bonzini
2022-05-31 17:54 ` [PATCH 1/2] KVM: vmx, pmu: accept 0 for absent MSRs when host-initiated Paolo Bonzini
2022-05-31 18:37 ` Sean Christopherson
2022-06-01 2:46 ` Like Xu
2022-06-01 8:50 ` Paolo Bonzini
2022-06-01 16:39 ` Sean Christopherson
2022-06-02 2:12 ` Like Xu
2022-06-15 18:52 ` Sean Christopherson
2022-06-16 10:37 ` Paolo Bonzini
2022-06-16 15:30 ` Sean Christopherson
2022-06-01 8:54 ` Paolo Bonzini [this message]
2022-06-01 9:12 ` Yang, Weijiang
2022-06-01 10:15 ` Paolo Bonzini
2022-06-01 10:42 ` Yang, Weijiang
2022-05-31 17:54 ` [PATCH 2/2] KVM: x86: always allow host-initiated writes to PMU MSRs Paolo Bonzini
2022-06-01 1:12 ` Like Xu
2022-06-08 22:22 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b59b1c0-112b-5e07-e613-607220c3b597@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=weijiang.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome