From: Hannes Reinecke <hare@suse.de>
To: alistair23@gmail.com, chuck.lever@oracle.com, hare@kernel.org,
kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
kch@nvidia.com, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v6 2/5] net/handshake: Define handshake_req_keyupdate
Date: Tue, 2 Dec 2025 16:34:18 +0100 [thread overview]
Message-ID: <4b5a6010-3404-43ab-8964-d704dbeac6d9@suse.de> (raw)
In-Reply-To: <20251202013429.1199659-3-alistair.francis@wdc.com>
On 12/2/25 02:34, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Add a new handshake_req_keyupdate() function which is similar to the
> existing handshake_req_submit().
>
> The new handshake_req_keyupdate() does not add the request to the hash
> table (unlike handshake_req_submit()) but instead uses the existing
> request from the initial handshake.
>
> During the initial handshake handshake_req_submit() will add the request
> to the hash table. The request will not be removed from the hash table
> unless the socket is closed (reference count hits zero).
>
> After the initial handshake handshake_req_keyupdate() can be used to re-use
> the existing request in the hash table to trigger a KeyUpdate with
> userspace.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v6:
> - New patch
>
> net/handshake/handshake.h | 2 +
> net/handshake/request.c | 95 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 97 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-12-02 15:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 1:34 [PATCH v6 0/5] nvme-tcp: Support receiving KeyUpdate requests alistair23
2025-12-02 1:34 ` [PATCH v6 1/5] net/handshake: Store the key serial number on completion alistair23
2025-12-02 18:29 ` Jakub Kicinski
2025-12-02 1:34 ` [PATCH v6 2/5] net/handshake: Define handshake_req_keyupdate alistair23
2025-12-02 13:49 ` Chuck Lever
2025-12-02 15:34 ` Hannes Reinecke [this message]
2025-12-02 1:34 ` [PATCH v6 3/5] net/handshake: Support KeyUpdate message types alistair23
2025-12-02 1:34 ` [PATCH v6 4/5] nvme-tcp: Support KeyUpdate alistair23
2025-12-02 6:02 ` Christoph Hellwig
2025-12-02 1:34 ` [PATCH v6 5/5] nvmet-tcp: " alistair23
2025-12-02 6:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5a6010-3404-43ab-8964-d704dbeac6d9@suse.de \
--to=hare@suse.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=chuck.lever@oracle.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®