From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9503B0AE1 for ; Tue, 28 Jul 2026 13:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785246615; cv=none; b=cKXi1BuBN1dKaq/5kkHaWq8ycbmLwqOJGmz4BOBq/IFR1+k4gEYjUsC9X1xs/j18ueioReD4FGRKv+emMvWzE2322+jbIpPqu9TtxsJvPCJ9Yg8xKjSR2FfOd0r8i46gYeyM7uHFTBukZzatcEP9WS/fI7RVUgqogzLhA7vdMGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785246615; c=relaxed/simple; bh=cYyqhGbOtch0OMgoH5rHeZBCWMljU1zPnzPnNokH5T0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uphE00TPGUdgqCFLy6vysAXLCWD8AUqKNR038CcmGJlwLCQvYnJ2Zn9Z15QwnwbCsUMhv/VVcGXjx2K6rbyPkZCETeHPC+XWa5uYd9z6UcBoXayrdl9ux6c/pUxep5U1zn1NMacOzeUYAzD6rzcvMRKI31dYFWKn9Nu3B+HbPmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JhWQi8mD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PizWuvOd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JhWQi8mD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PizWuvOd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785246613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WVLPzsih7jHwttgXCjqiYK0PPNx9XxtuzrfSgVm0vvg=; b=JhWQi8mD9XFPOEvRMg12RRb+9FwF7DJVHYxESDz1gzrck6pYJ3p1XdmWmmd1YQUdJBod5o 4TW6XVtqQ/PopVaz9D66+YmRAtghPW6b4y4nSxCNC9bHWjEUqU1qPqjoavKNN92pF2IDLX uFTUgWVMsiXEznPOO4jaDC7rDrDWqV0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-l783HX3sMJ2bWvaGRB8FoA-1; Tue, 28 Jul 2026 09:50:09 -0400 X-MC-Unique: l783HX3sMJ2bWvaGRB8FoA-1 X-Mimecast-MFC-AGG-ID: l783HX3sMJ2bWvaGRB8FoA_1785246607 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49545071724so40479165e9.0 for ; Tue, 28 Jul 2026 06:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785246607; x=1785851407; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WVLPzsih7jHwttgXCjqiYK0PPNx9XxtuzrfSgVm0vvg=; b=PizWuvOdheSc5rwXr8t8xxI+fS1te9cVrH6jc3dR/WIPyYugjI0JDYz2QLbSQFPe3f VgiSB5HhsqERNEMurziLnRrDr22LiRuFr2z8kAZu9tRLWETNd7JXZ6WTO8QKSmJR5vU5 82w38dHJ4MgSiss9PE66xg9ZP8i8hSwV34SA9SEv+sdXZ+TIHU8HHy0OiihW38fsK+tV B5/qPAtvZ+AdfvsF2Z0jmQFDzy+Ep4hPoPjKeUnxfaQZz1e61IiC/0PvgdagTWV5kPGu 2I6XmbcS7B0amW3iDDG/aywpi9iLrAFRc5tKjM5kJek4loo2dRiJ/b6KeelBC5FQPj4g Zm4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785246607; x=1785851407; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WVLPzsih7jHwttgXCjqiYK0PPNx9XxtuzrfSgVm0vvg=; b=BaMZxuWqo+0SmX+BPVDwOrUq2d809zsQV0rjl3SJFd+bb3TrZATXuwoMPFiQxzDhG8 ZBWUyx0MitX+NX+iSeWRLsX75gUAOTLTkJthvq7iejn8iW+lzrh+DwMuju5OyCfEcHr1 TAu7UzXaQpAEXREvLeYj7zYcHnbozQmtJ0L07asqwM7Hbtrrnh03qmbcy8ZZ15K73gno zYMX7ILn2sIGBYgie8l3ZuAWAhLAw4QlhDn2uGYLy04fmbjr7j5r+pAP+KjPWgyA4eY4 zvbQqktpBggNhi/+Pb0OJpmYbIx3vareFOrB4XJ9fURbs+pF9CLqEwHzE14UP2nYT3vJ zHDg== X-Forwarded-Encrypted: i=1; AHgh+Rr52u19EventQkIu84qO9Ij+Z/css7NfuKTS+2YIaO/OT5rUH2ljZ4DbbNrX/K7Pf0UGnOcJSP5Hx2F5wE=@vger.kernel.org X-Gm-Message-State: AOJu0YxAXx7NV3CL8tXObGO94Sgpx/nvBtwRuMbUSNf2EQEicn3XdMYf iTHYiJPJ7Ry131InY7mUB3JUqL1kaBmPhupxFuB6w3PEYyFAmMB7Xz9+wob9aVRI91IDCHIqLBP vQ5NufAvjtXh6XWZACEAlhnu2sKcuC9ez3ntLUKEWCx6TaH2vagSlyJWY2w+gaYudag== X-Gm-Gg: AR+sD13WqNX4q7ipx+mElfduW0vceE8vSXLdKCy75trdjTeOTdk94c8yoYtyinRwM72 MM52pqAjOiglLaVH7wl5spSA9wXP2U20LocS2nyGGP2OQz3tlWnjfKtRxnZp5RgIFtlBywA4oH2 m7ClO81rhXQ0xdWlJFkJfGoZdfCXxrMlVAsGfsxJbhctB16Rao+nFIhdAV84y74LoBntPXB8UBt kzb/P3XrX+rIIuNf18MkSU5TfgrFONMMkCp46pKf697tuqnDNpA3yixZ3iV+mZQ8etUQTPZGnvq 2j6geMRkWSOPiAMZV1ueR0E53+U8HZWz4YxgMIl/RumkTU4zxCCioBJIQ+c5pGfbAO3sgJf8uFJ QRmQBq444bLb6AYTrVlGCQRjBTUMffL+coIMmsPf8QXHmCetFsJ+VVB2imVRtTSoiesSu72s5fK ftIA== X-Received: by 2002:a05:600c:46d5:b0:495:4a22:d684 with SMTP id 5b1f17b1804b1-496c6439428mr31470215e9.10.1785246606605; Tue, 28 Jul 2026 06:50:06 -0700 (PDT) X-Received: by 2002:a05:600c:46d5:b0:495:4a22:d684 with SMTP id 5b1f17b1804b1-496c6439428mr31468965e9.10.1785246605194; Tue, 28 Jul 2026 06:50:05 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496c45c297dsm76861475e9.7.2026.07.28.06.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 06:50:04 -0700 (PDT) Message-ID: <4b5f67a2-5624-4adb-812a-bd87d99416ed@redhat.com> Date: Tue, 28 Jul 2026 15:50:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v5 1/3] net/smc: bound the wire-controlled producer cursor to the RMB To: hexlabsecurity@proton.me, Sidraya Jayagond , Jakub Kicinski , "D. Wythe" , "David S. Miller" , Wen Gu , Wenjia Zhang , Eric Dumazet , Tony Lu , Mahanta Jambigi , Dust Li Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, Ursula Braun , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Raspl , Simon Horman References: <20260723-b4-disp-0d07164f-v5-0-6a9e235dbc4e@proton.me> <20260723-b4-disp-0d07164f-v5-1-6a9e235dbc4e@proton.me> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260723-b4-disp-0d07164f-v5-1-6a9e235dbc4e@proton.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/24/26 2:23 AM, Bryam Vargas via B4 Relay wrote: > @@ -246,8 +256,13 @@ static inline void smcr_cdc_msg_to_host(struct smc_host_cdc_msg *local, > local->len = peer->len; > local->seqno = ntohs(peer->seqno); > local->token = ntohl(peer->token); > - smc_cdc_cursor_to_host(&local->prod, &peer->prod, conn); > - smc_cdc_cursor_to_host(&local->cons, &peer->cons, conn); > + /* bound the wire-controlled producer cursor to our RMB (used as a raw > + * index by the urgent path); leave the consumer cursor unbounded -- it > + * indexes the peer's RMB and is bounded by peer_rmbe_size. > + */ > + smc_cdc_cursor_to_host(&local->prod, &peer->prod, conn, > + conn->rmb_desc->len); Sashiko gemini suspects the above may cause a Null ptr dereference: https://sashiko.dev/#/patchset/20260723-b4-disp-0d07164f-v5-0-6a9e235dbc4e%40proton.me /P