From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F9E1D63F0 for ; Tue, 23 Jun 2026 09:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207649; cv=none; b=OtJI7/AV91JNzPLsHjzL5TxZNvqUNvEq6r+fqgFVrt4lPr8j6yt+3p/zMmJJv//7XU53BPcXeZViameEyU8VqtZa9HzH+AsYpi9Jht30jKz/9dxCq1bkMWSXtVGMWS3/J1egUNmB6gh5horIsM7n7GlplhqzlXC4TB07g9GdauI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207649; c=relaxed/simple; bh=qH1RtQSTtC9cVkZCKM8WfDRkPAnefyPwpUkl1sSLI0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=blErLKnj4ElwmfZvh5rkUFZ5kEtNNmgvNNKlFqfAE9i3wS1trbqzDHorVZBZQL/KMi2hgjrc49fkRDbVPH9Mbn/xI5XPnxghrv6+d3hVAyNuoNmF0AB7+icDV1A1dmb+Lje/lFbjly5M+g3FmucXaL0vsSs+9FTjm5VzoI1vsTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZzAbhvDD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jp0+VnBR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZzAbhvDD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jp0+VnBR" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cbjn2992224 for ; Tue, 23 Jun 2026 09:40:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UZWLMzUqG2/p/tMb+yic3sKJ+jKh1OhHeh2HvgJ8Olo=; b=ZzAbhvDDccuFi/+2 G8ra3h5Rp6kuV0uTKNZdVvEhr7poxkoAywa5zOs5yCLHeemKvwUsvb6YVzg36JMY 6JzLgXh5OMAMXYdoLY0e7dvxRTATzvc63NyPGXjCu6F5lbD8AtcLgVfX4Ix9sGb1 6L45/suxTGAw36tNBR9CV1Ihx//I+t8btlOumIV4xIMICdKEV2WO7TvYlVD2ega2 nc1zUOnveSTfhHKfDao/gpn4K2AHi4PRvGNPg279f0FfD+cucHBUAy0E45xbxsa7 /Q8f3T9s1tnLgoZ5VVAR1di/Ey2qT3AcYWrLedl9FUB4s6cqCWDDvP75XzIN9TBz sHNAnw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey729ur65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:40:43 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9229581de9eso30674585a.2 for ; Tue, 23 Jun 2026 02:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782207643; x=1782812443; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UZWLMzUqG2/p/tMb+yic3sKJ+jKh1OhHeh2HvgJ8Olo=; b=Jp0+VnBRV8JABMNYSV5iUz1Tn2r5IXjuOvA7mgs2OgYzbqNY/cakEeaLrBzhiH45Z1 cqjftq2ZI24wBRSrDZf98HKbMkrUbwHZN1Z/4ugm3lwD0fAIApdwQM6UuIT4CbY4KBge /XBX/e1Mm02I7HMB/ph7zy8KjfXgnwsE5rEMPY9HHtwa0Xq/aSo9ikjHasXlVXtC+C3Z SQJW/05sec4WDZQv82jC00d4w02yFXxrnhbtPGgd/KINJ6iE99xEahmPeeHw2gufMy03 IFPNMhnQxCBErg17geD7/pW2W+j5DwIh+tM8VDxXG29naRp0YAp4WWuFDRM7qKte8Cgc t3PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782207643; x=1782812443; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UZWLMzUqG2/p/tMb+yic3sKJ+jKh1OhHeh2HvgJ8Olo=; b=OjOFXiwR6dciV/KvanicxoA0UwxbAps55Lzmrp/vpPOJcEz1HGWJlDh4+z1FzO9Keq MGRmJbduezaXdOjRGdDmXK40uxjPQseeIumkgbtzsJlQqwFatjR9O27PfRYLvMwy9GVi J12hQKHv3PWRwBXvYCe+X7YAWrqRgZxuE1BBediEChgm2gvNDcafP9jTXPUP51LuFE4K HwgFlS55ZOkG3foMoOIuv0fdshZYduFcGocDXtlCErOMKMdOAc3boyA3wwjkFWStnWO4 yjYwfdwb68LnyZ3+QUvKaSYJAwPa8omIWeknK+hfwsqU7jG756l21IInBwnp3simiFyg QRsw== X-Forwarded-Encrypted: i=1; AFNElJ9ouGesTXIYpZQ/F+8GZ5s3j/ZdhWDUwt2aO2Glbf0U9+JOutCwSAI5OwMFqmJ/qNE36B0ahmHHYZ5ZLcA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4UQr0wiHwd/v9lkBkdvvpP4MVMrfeiLt/Ve+6wPQIJBZheC0U FaNNiSKs9xshBvhLnjCnD8Xp36zz1x0ZKdOjI/y2x3kIMrIQG4pP/oDhciSbtN9byKGxAmjnWeX Qyn9bpx0y1KV4QzGT3RIwGzW7+Mi7fw/7z6TXR9QnmNDRowwRBfjLE22D3Ff9a+2pp2Q= X-Gm-Gg: AfdE7ckcDwCdfjy4g7XJcKrKiQF4/f1s48/448lZKJUs4R0I237de4uemFSzfw+yeUu wrdqYPrdLUe2rM3e+jGCe6zkM3dqqIcmYN5yWbgqryrFHjEy5WRx1OXVZjmaFkT5Pmg5FDa2fAj wy/bmlP7Mo828RwThOw8kuJVLsb+P2yepXGmgaVE+gVRpRdy+aqYVdR8Bw/tscPUfcyKIdX5WBp o3MOsKPCMJvXxG+Ck80Mm/2I0aeLCpISnQum3Ki4raiwKkQcocaVfBJzDf3LOWJ6cvFOS5VSQoc frK6tOBy/ftxogOoUNtdoWVocEdPKslqpR4KambXPA3QGTjcL0IMnie7NuwCufg6Wz53CHz8lJT cQcPqX4KugNOW0JonqGyJTOYoE47oghebvrk= X-Received: by 2002:a05:620a:628f:b0:911:295d:59a1 with SMTP id af79cd13be357-925ca2880ebmr411570885a.8.1782207642891; Tue, 23 Jun 2026 02:40:42 -0700 (PDT) X-Received: by 2002:a05:620a:628f:b0:911:295d:59a1 with SMTP id af79cd13be357-925ca2880ebmr411567385a.8.1782207642232; Tue, 23 Jun 2026 02:40:42 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c610e5280sm492261366b.53.2026.06.23.02.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 02:40:41 -0700 (PDT) Message-ID: <4b60bb58-bc08-4bbf-be6f-d447050af479@oss.qualcomm.com> Date: Tue, 23 Jun 2026 11:40:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu/qcom: Remove sysfs device on probe failure path To: Haoxiang Li , robin.clark@oss.qualcomm.com, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jroedel@suse.de Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260623071245.1985938-1-haoxiang_li2024@163.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623071245.1985938-1-haoxiang_li2024@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=eN0jSnp1 c=1 sm=1 tr=0 ts=6a3a549b cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=Byx-y9mGAAAA:8 a=EUspDBNiAAAA:8 a=cLxE6WtmSDgmiAOwmGUA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: 8Q9zp8sgkTUALT-jJWXQHBoEjH2yM1dJ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3OCBTYWx0ZWRfX38GFGImYvILA 32A2PumyU8vwjq/QJpX0qESMmY1WiTMgqkC4NziGoGrU6HjJWpkdK2bRUKEmDO5m/mgDgGDqUVx 7egwot7kM8Mn6Fq8urVBqfQ5LTB/p2k= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3OCBTYWx0ZWRfX26LJik7mekls T9HwtrU+iX1+qFtMz8KckP+BHnRg815jVhQzOOu18oDsIF7cQH1zWN8OCNLYJw3/tac4MnmPCxg gGcCV0PNbdyVLVbbXSk89T0Tqy0j6iPbTiKEZvtHza0Wf6C1OiTQfimlK2PAWuKjEsdyEtspYlQ 1y7CPqqOmhVn286IzWyljfnhs0bru+25ZJrNYKOHGF/NvQORNu3xsOt7dotyB7U3CUIJGhU7AL2 DvJTdFBcUqOqjFshdOgmc4xroGHAkm5L5a6ufQJQg3F5XXRvKFTJxS+Vh23Joe8OwBmPLTz2MLI 9lbWn0kfjiXCw1zX9k5lGjq/9jp3ohTE+I7SLNy0Dul7TyrL0MTnflAVB/Rm34WMsw9kuaVHVLH twNSpGcLLnAN7MBur6EbEQLg29Kp2Q== X-Proofpoint-ORIG-GUID: 8Q9zp8sgkTUALT-jJWXQHBoEjH2yM1dJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230078 On 6/23/26 9:12 AM, Haoxiang Li wrote: > In qcom_iommu_device_probe(), if iommu_device_register() > fails, the sysfs device created by iommu_device_sysfs_add() > is not released. Add a goto label to do the cleanup. > > Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") > Signed-off-by: Haoxiang Li > --- Reviewed-by: Konrad Dybcio Konrad