From: Nikolay Borisov <nik.borisov@suse.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>, x86@kernel.org
Cc: David Kaplan <david.kaplan@amd.com>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 3/7] x86/bugs: Exit early if return thunk is already set
Date: Thu, 22 May 2025 13:26:16 +0300 [thread overview]
Message-ID: <4b60f99e-ae4d-49ae-b886-21e7377abe51@suse.com> (raw)
In-Reply-To: <e7453122-54c4-454c-871f-dcb7179506ec@suse.com>
On 5/22/25 13:22, Nikolay Borisov wrote:
>
>
> On 5/22/25 05:44, Pawan Gupta wrote:
>> ITS and retbleed can both set CDT return thunk. If the exact same return
>> thunk is already set, avoid the warning and exit early.
>
> According to the code there is only a single call which sets the CDT
> thunkand its in retbleed_apply_mitigation() if RETBLEED_MITIGATION_STUFF
> is being used.
>
> ITS OTOH only sets 'its_return_thunk'.
>
> While the patch itself is not wrong, the description doesn't reflect the
> current code?
So this is in preparation to allowing ITS to select the CDT, but this
must be mentioned explicitly or simply squash this change into 'x86/its:
Remove =stuff dependency on retbleed'
>
>>
>> Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
>
>
>
next prev parent reply other threads:[~2025-05-22 10:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 2:44 [PATCH v2 0/7] eIBRS fixes Pawan Gupta
2025-05-22 2:44 ` [PATCH v2 1/7] x86/retbleed: Check for AUTO in all cases Pawan Gupta
2025-05-22 9:52 ` Nikolay Borisov
2025-05-22 11:27 ` Borislav Petkov
2025-05-22 17:42 ` Pawan Gupta
2025-05-22 2:44 ` [PATCH v2 2/7] x86/retbleed: Simplify the =stuff checks Pawan Gupta
2025-05-22 10:18 ` Nikolay Borisov
2025-05-22 11:42 ` Borislav Petkov
2025-05-22 18:02 ` Pawan Gupta
2025-05-22 2:44 ` [PATCH v2 3/7] x86/bugs: Exit early if return thunk is already set Pawan Gupta
2025-05-22 10:22 ` Nikolay Borisov
2025-05-22 10:26 ` Nikolay Borisov [this message]
2025-05-22 18:03 ` Pawan Gupta
2025-05-22 2:45 ` [PATCH v2 4/7] x86/its: Use switch/case to apply mitigation Pawan Gupta
2025-05-22 11:15 ` Nikolay Borisov
2025-05-22 18:04 ` Pawan Gupta
2025-05-22 2:45 ` [PATCH v2 5/7] x86/retbleed: Introduce cdt_possible() Pawan Gupta
2025-05-22 2:45 ` [PATCH v2 6/7] x86/its: Remove =stuff dependency on retbleed Pawan Gupta
2025-05-22 2:45 ` [PATCH v2 7/7] x86/its: Allow stuffing in eIBRS+retpoline mode also Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b60f99e-ae4d-49ae-b886-21e7377abe51@suse.com \
--to=nik.borisov@suse.com \
--cc=david.kaplan@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®