From: Jonathan Marek <jonathan@marek.ca>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] misc: fastrpc: add ioctl for attaching to sensors pd
Date: Mon, 7 Sep 2020 10:02:26 -0400 [thread overview]
Message-ID: <4b617c4c-f0f8-3d6b-c726-9dd4bf705fbc@marek.ca> (raw)
In-Reply-To: <e0db9beb-bbd2-8f20-d7f4-675b62acf782@linaro.org>
On 9/7/20 9:58 AM, Srinivas Kandagatla wrote:
>
>
> On 07/09/2020 14:51, Jonathan Marek wrote:
>>>> @@ -1477,7 +1477,10 @@ static long fastrpc_device_ioctl(struct file
>>>> *file, unsigned int cmd,
>>>> err = fastrpc_invoke(fl, argp);
>>>> break;
>>>> case FASTRPC_IOCTL_INIT_ATTACH:
>>>> - err = fastrpc_init_attach(fl);
>>>> + err = fastrpc_init_attach(fl, 0);
>>>> + break;
>>>> + case FASTRPC_IOCTL_INIT_ATTACH_SNS:
>>>> + err = fastrpc_init_attach(fl, 2);
>>>
>>> Shouldn't you have #defines for those magic numbers somewhere? What
>>> does 0 and 2 mean?
>>>
>>
>> This is based off a downstream driver which also uses magic numbers,
>> although I can make an educated guess about the meaning.
>>
>> Srini do you have any suggestions for how to name these values?
>
> These are domain id corresponding to each core.
> you can use SDSP_DOMAIN_ID in here!
> these are already defined in the file as:
>
> #define ADSP_DOMAIN_ID (0)
> #define MDSP_DOMAIN_ID (1)
> #define SDSP_DOMAIN_ID (2)
> #define CDSP_DOMAIN_ID (3)
>
I don't think this is right:
FASTRPC_IOCTL_INIT_ATTACH uses pd = 0
FASTRPC_IOCTL_INIT_CREATE uses pd = 1
And these two ioctl are used with all DSP cores. So it wouldn't make
sense for the pd value to correspond to the domain id.
>
> --srini
next prev parent reply other threads:[~2020-09-07 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 0:32 Jonathan Marek
2020-09-07 12:33 ` Greg Kroah-Hartman
2020-09-07 13:51 ` Jonathan Marek
2020-09-07 13:58 ` Srinivas Kandagatla
2020-09-07 14:02 ` Jonathan Marek [this message]
2020-09-08 8:19 ` Srinivas Kandagatla
2020-09-07 12:36 ` Srinivas Kandagatla
2020-09-07 13:47 ` Jonathan Marek
2020-09-07 14:01 ` Srinivas Kandagatla
2020-09-07 14:05 ` Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b617c4c-f0f8-3d6b-c726-9dd4bf705fbc@marek.ca \
--to=jonathan@marek.ca \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®