From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD428C432BE for ; Thu, 19 Aug 2021 17:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD1DC6109F for ; Thu, 19 Aug 2021 17:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbhHSRz5 (ORCPT ); Thu, 19 Aug 2021 13:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbhHSRzt (ORCPT ); Thu, 19 Aug 2021 13:55:49 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D833C061575; Thu, 19 Aug 2021 10:55:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id 27D711F43F4F Message-ID: <4b67e381c3c6819d5888f4ca713db5236b58d951.camel@collabora.com> Subject: Re: [PATCH] media: cedrus: Fix SUNXI tile size calculation From: Nicolas Dufresne To: Jernej =?UTF-8?Q?=C5=A0krabec?= , Maxime Ripard Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Date: Thu, 19 Aug 2021 13:54:59 -0400 In-Reply-To: <3519986.qLKfoAsNv3@jernej-laptop> References: <20210819140009.158156-1-nicolas.dufresne@collabora.com> <3519986.qLKfoAsNv3@jernej-laptop> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeudi 19 août 2021 à 18:30 +0200, Jernej Škrabec a écrit : > Hi Nicolas! > > Dne četrtek, 19. avgust 2021 ob 16:00:09 CEST je Nicolas Dufresne napisal(a): > > Tiled formats requires full rows being allocated (even for Chroma > > planes). When the number of Luma tiles is odd, we need to round up > > to twice the tile width in order to roundup the number of Chroma > > tiles. > > > > This was notice with a crash running BA1_FT_C compliance test using > > sunxi tiles using GStreamer. Cedrus driver would allocate 9 rows for > > Luma, but only 4.5 rows for Chroma, causing userspace to crash. > > > > Signed-off-by: Nicolas Dufresne > > Fixes tag would be nice so it would be picked up for stable branches. > Otherwise it looks good. It also aligns logic with libvdpau-sunxi. Sure, I'd say can be merged adding (it was broken since when cedrus was added): Fixes: 50e761516f2b8 ("media: platform: Add Cedrus VPU decoder driver") > > Reviewed-by: Jernej Skrabec > > Best regards, > Jernej > >