From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A82A1F63FC for ; Tue, 7 Jan 2025 16:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268176; cv=none; b=uPVCNfLLU9/mCmErU5hGHT25BwYJC/SKjVLT7Ut1OH96LxE3SHHHzgw4klHMhYSzCse0dDZLWCb3189bNmgDIQFClmMuOeQP7XrfhisF2fynwKHCP7oJBEIHFQc0X1Mcs3EcuwDeeOXW4CY/7dHzxnwa1IdmRMAdhb5dS7mC2Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268176; c=relaxed/simple; bh=Y4CJRAGDnC7iGZQEiu3CAI5YM1AmUdMlOjU3LW7pIKw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tXmltw60bhWNtSBhvgkLOj7b5jcyHrOdR2Sa3BkzvSLE9kCYiLEcsZBrGoXty/wXtCai9jXJMNolq7PnzSj9e3RwPL40G0DwlPyTAt0lq7TQAroTMCBTEd0Kx/xQxLyXCqy8RIKAB5IJcAY5XACbJvWKv/xuGm7CgyLg+E1+cCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=tv0zbpD9; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="tv0zbpD9" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71e3005916aso3306689a34.2 for ; Tue, 07 Jan 2025 08:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736268172; x=1736872972; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NS+4uyy4WSlme22Nh2XfmwM5QULvJZzhlOyoVgJVctE=; b=tv0zbpD9CiXJO8FzapNqnsZZdOCVNEQ5Ju7iNCjvLlnrSDAebUBL2igMd/483EFM7n NzsY+B+oYooPYkE3u0dtxtmm3t/gnFMUndJnM5KPSqwNy1xuhxldxHrykozegX9w+wYY Y7aGWxQKSXwL51bPQ8ZdnRTiZdWopltX+46Ccj3mrSFrPV1NT3Yntk/9yEIlwxAnHp3o bWF/X0RLmOQnPmB8tCd342cxcWeH1NhCvaDV0QYFKmOCUib8Bw+hDCR+RfLxovK9QREG KddyW5R8TmHsJ/riNRCZCzPDOPOgK4pLRYdZcfHINFfr07b4MsZEWIKZaWfxiqtcW1AC b+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736268172; x=1736872972; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NS+4uyy4WSlme22Nh2XfmwM5QULvJZzhlOyoVgJVctE=; b=hKMJX46rr2/95ubzheJa2fD09qNufMxftYMmTr0Ijp3vWM6mawbEVUeJwihU/099Qw qGaLFj0QuxXeTCi0JmMwUw5Wut08vn/woj8VbkpG0kYqsj2mzaF3NOBmLyTqXdufTzRX O5sHgp36zhlJIPd3qbE+/yo/mJZURrkiT2AJIVClCl8i6WLDXoEazyiu1UNwf7YL/c2H j36WrWlxVN6MepsImrotG8IiriiwdKdDSK8wH6CioRbLUxYfm21LdY1F8zYTmCaMYKP+ +DRz5jJvBLY6i3kUK7G7K1ivUa7I0fvzFxY3Y0CJMEsN7uGHBHU7NJtU7Kgvl9PEKnij n7LQ== X-Forwarded-Encrypted: i=1; AJvYcCVfhoOGhYlnD3bPwgmyQ/QvnQnfDvXUw1ikpHg3oPr8LkYcqncCqABgmYUS0z332hWAWx/xGCSBsGIVnS8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7S67RZhk9CUr7rYRPz7OxR08Zsx7x2cl4iaRgADRrJMn0IsEG KfUza1Hbeg/Ry11dGiPRABBLD2EoZnKj2pdznkMYmqsNVUJAhkW8JUf9TMadKTo= X-Gm-Gg: ASbGncs0q9PlbJX253ivERnqzHUKoHP8XzDLhSwdVs1FwfGBaHriEViTyBo7OjqzGlY viCuAYyIFCHEuyo5FOmzeQhA8/8Iijglkvr7cZlZmUOds9mh0RZGAlsQUU/DkSV/DxrbMC1x7EL d5TpPaT4fFM4Sw0sBLd5TBIwABJSgVDuc0i9hMxW/2dSYMJ0MqjkvFZquww9jdNA0xdXdfIHu7q nS9X8soqqzoRxfEHcjIrcmMZiqakxgQ4kQwegD+MbNkoFxlvh39MwscJ4fd6mbjxjbAy8euFvEZ 2yGPeYKXo+eSllc6LQ== X-Google-Smtp-Source: AGHT+IH1ms8XV/786w6e3xRpBgzBKmkYoG3him7eUgN7qc4ku/C3O+p7mR3rZq7QoSJ1bl4nVcxtrA== X-Received: by 2002:a05:6870:47a2:b0:29e:14ff:2f9c with SMTP id 586e51a60fabf-2a7fb0cc025mr36125756fac.18.1736268172098; Tue, 07 Jan 2025 08:42:52 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2a7d745627dsm12619643fac.2.2025.01.07.08.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 08:42:50 -0800 (PST) Message-ID: <4b6c8505-5615-4d43-9632-3fc3dca27e70@baylibre.com> Date: Tue, 7 Jan 2025 10:42:49 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iio-next] iio: proximity: Fix use-after-free in hx9023s_send_cfg() To: Dheeraj Reddy Jonnalagadda , jic23@kernel.org, lars@metafoo.de Cc: jstephan@baylibre.com, yasin.lee.x@gmail.com, dan.carpenter@linaro.org, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250107123510.44978-1-dheeraj.linuxdev@gmail.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250107123510.44978-1-dheeraj.linuxdev@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 6:35 AM, Dheeraj Reddy Jonnalagadda wrote: > Reorder the assignment of fw_size to happen before release_firmware() > to avoid accessing the firmware structure after it's been freed. > > Fixes: e9ed97be4fcc ("iio: proximity: hx9023s: Added firmware file parsing functionality") > Closes: https://scan7.scan.coverity.com/#/project-view/52337/11354?selectedIssue=1602791 > Signed-off-by: Dheeraj Reddy Jonnalagadda > --- Reviewed-by: David Lechner