From: Valentin Schneider <valentin.schneider@arm.com>
To: Qais Yousef <qais.yousef@arm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, vincent.guittot@linaro.org,
Dietmar.Eggemann@arm.com, tj@kernel.org,
patrick.bellasi@matbug.net, surenb@google.com,
qperret@google.com
Subject: Re: [PATCH] sched/uclamp: Fix overzealous type replacement
Date: Fri, 15 Nov 2019 00:05:40 +0000 [thread overview]
Message-ID: <4b702b68-997b-da33-660c-db4313ac6dc5@arm.com> (raw)
In-Reply-To: <20191114202855.64e4jnb4dcbru4w3@e107158-lin.cambridge.arm.com>
On 14/11/2019 20:28, Qais Yousef wrote:
> On 11/13/19 16:53, Valentin Schneider wrote:
>> Some uclamp helpers had their return type changed from 'unsigned int' to
>> 'enum uclamp_id' by commit
>>
>> 0413d7f33e60 ("sched/uclamp: Always use 'enum uclamp_id' for clamp_id values")
>>
>> but it happens that some *actually* do return an unsigned int value. Those
>> are the helpers that return a utilization value: uclamp_rq_max_value() and
>> uclamp_eff_value(). Fix those up.
>>
>> Note that this doesn't lead to any obj diff using a relatively recent
>> aarch64 compiler (8.3-2019.03). The current code of e.g. uclamp_eff_value()
>> already figures out that the return value is 11 bits (bits_per(1024)) and
>> doesn't seem to do anything funny. I'm still marking this as fixing the
>> above commit to be on the safe side.
>>
>> Fixes: 0413d7f33e60 ("sched/uclamp: Always use 'enum uclamp_id' for clamp_id values")
>> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
>> ---
>
> The changelog could be a bit simpler and more explicitly say 0413d7f33e60
> wrongly changed the return type of some functions. For a second I thought
> something weird is going inside these functions.
>
The first paragraph is exactly that, no? The rest (that starts with "Note
that") is just optional stuff I look into because I was curious.
> But that could be just me :-)
>
> Reviewed-by: Qais Yousef <qais.yousef@arm.com>
>
> Thanks!
>
> --
> Qais Yousef
>
next prev parent reply other threads:[~2019-11-15 0:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 16:53 Valentin Schneider
2019-11-14 20:28 ` Qais Yousef
2019-11-15 0:05 ` Valentin Schneider [this message]
2019-11-15 9:05 ` Qais Yousef
2019-11-15 8:12 ` Vincent Guittot
2019-11-15 9:09 ` Qais Yousef
2019-11-15 9:55 ` Valentin Schneider
2019-11-15 18:13 ` [tip: sched/urgent] " tip-bot2 for Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b702b68-997b-da33-660c-db4313ac6dc5@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®