From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46BC83DEAC3; Wed, 18 Mar 2026 14:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845210; cv=none; b=VPqJIcYWMHPuZ8rxmdlnrawFKMbHMRsp+h0X9eUOZHpIEj/CRQx45C0joPLIj1CKRUMR4MKCW17Gzu0MvoWq4/3FMk/nN4iuEl5N0Z4x5//w5XV3gutiMrXr02yP6KWmEIi8bzuuZ4Bj+jdt55knBIHxf2cqJQgJ5f4z91cp290= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773845210; c=relaxed/simple; bh=gvuq/gAM5OiH7F9mMhn33EHNI4LQXwBO42NHJxQek74=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Tz+z4NZztWy2LqMb1MIIzyuG55LCF5Xj1fzpOpV4scr5INN7KdIYVMLKJFFyO5LoAf639nuaY1vIhHoD9XbkAvPuiGMPGAkePAmPKDSANL+TnI5Jm3mDgU62W6E6zgZLBJX4o8WVQ1mD6XdApYP2fSWe2xh6JAnWZyKaUy5eWTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BUs6buE1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BUs6buE1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6450C19421; Wed, 18 Mar 2026 14:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773845209; bh=gvuq/gAM5OiH7F9mMhn33EHNI4LQXwBO42NHJxQek74=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=BUs6buE13hMtTigsrWMuHpEH31O6+DNhfIcUQsItbYPXQ3zvLPaMh7bEIMvkN6Lio nvJr6Mo/5tMArhQSUNxlUAVELnjVTj9/wy2ry1wZ/0RwHcdPuhrszrWVer641s1Lkk K83wa1nXuUv9cOgVTLt79bcJYZY/6OujEDIaU1XhKcS0nBnRYxKmBQ5Btd9KeEHg+9 q9imPjiQg7yrf4FurCSWfMtlZ5vH0lPQb/TxIEjlqmUDTn9uTFl5sxUgDL/51eJkwf vqr4XCikz6I4qpwcjJ6g+Bf9nYwOlHdtP5J41g9Ita/5I4VUymBnhIS6mniC9sSUVf JDnf8/9Zoah4Q== Message-ID: <4b7689ce-5ab1-4f04-8701-f9f03a40ae76@kernel.org> Date: Wed, 18 Mar 2026 15:46:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] clk: qcom: dispcc-eliza: Add Eliza display clock controller support From: Krzysztof Kozlowski To: Dmitry Baryshkov Cc: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260318-clk-qcom-dispcc-eliza-v2-0-8c05581168d1@oss.qualcomm.com> <20260318-clk-qcom-dispcc-eliza-v2-2-8c05581168d1@oss.qualcomm.com> <1a00582d-66d6-4325-aafd-156cfacee8cd@oss.qualcomm.com> <2227a9d2-fb34-4d54-8122-c00f54009de1@oss.qualcomm.com> <846ae47c-8e0e-4fdb-899d-de679d013fa5@oss.qualcomm.com> <9ea16bfe-ac9b-405c-8597-e4f398347d8f@oss.qualcomm.com> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <9ea16bfe-ac9b-405c-8597-e4f398347d8f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/03/2026 15:33, Krzysztof Kozlowski wrote: > On 18/03/2026 14:46, Dmitry Baryshkov wrote: >> On Wed, Mar 18, 2026 at 12:36:24PM +0100, Krzysztof Kozlowski wrote: >>> On 18/03/2026 12:32, Konrad Dybcio wrote: >>>> On 3/18/26 12:13 PM, Krzysztof Kozlowski wrote: >>>>> On 18/03/2026 11:48, Konrad Dybcio wrote: >>>>>> On 3/18/26 11:39 AM, Krzysztof Kozlowski wrote: >>>>>>> Add a driver for the display clock controller on Qualcomm Eliza SoC, >>>>>>> which is copied from SM8750 driver plus changes: >>>>>>> >>>>>>> 1. Additional DT_HDMI_PHY_PLL_CLK clock input, >>>>>>> 2. Eight new HDMI clocks, >>>>>>> 3. Different PLLs (lucid and pongo). >>>>>>> >>>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>>> --- >>>>>> >>>>>> [...] >>>>>> >>>>>> >>>>>>> +// SPDX-License-Identifier: GPL-2.0-only >>>>>>> +/* >>>>>>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved. >>>>>>> + * Copyright (c) 2023-2024, Linaro Ltd. >>>>>>> + * Copyright (c) 2024-2025, Qualcomm Innovation Center, Inc. All rights reserved. >>>>>> >>>>>> -> Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>>>> >>>>> That's the copyright I found in the downstream code I used in few places >>>>> here (with modifications) and I am not touching them. I also don't care >>>>> about these and I am surprised this keeps popping in community review... >>>> >>>> You may not care, but our legal department does.. >>> >>> And your task as community maintainer is to care about community and >>> Linux kernel, not about legal department. >>> >>> Legal department can comment here, if they care. You as maintainer have >>> rather responsibilities regardless of that legal department. >>> >>> Don't bring corpo legal stuff to the community. >> >> Then please follow the internal company guidelines as outlined in the >> legal&marketing documents. > > That's not your task to instruct people what internal stuff should they > follow or not. > > Especially not implied by previous comment "Then". > >> >> JFYI, several other Qualcomm maintainers also enforce use of copyright >> headers for Qualcomm-provided patches. Konrad is not unique here. > > I already objected to one of them, so I know. > > You do understand that this is completely broken review process? As > every contributor, I can object to that comment with arguments (and I > did in the past), however you as reviewer do not bring any > counter-arguments for that all. You just refer "follow legal internal > stuff". No, this does not work for that. BTW, I welcome here any legal arguments, not referring to whatever internal stuff you have, why I should remove EXISTING copyright or replace it with something. Also kind of related to above, please provide arguments, since copyright statements absolutely do not matter and Git history defines actual copyrights, why I should add more copyright lines after the initial copyrights I carried over from the code I used. If you come with argument that I should provide something, then please at least justify it. And no, do not refer to any internal legal departments, because they do not matter. They are not being a part of discussion here. Best regards, Krzysztof