mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Kathara Sasikumar <katharasasikumar007@gmail.com>, shuah@kernel.org
Cc: david.hunter.linux@gmail.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: zram: use bash as script uses bash syntax
Date: Wed, 31 Dec 2025 13:11:59 -0700	[thread overview]
Message-ID: <4b780e63-b1cb-4496-8bc0-94c9d051766e@linuxfoundation.org> (raw)
In-Reply-To: <20251205233216.792698-1-katharasasikumar007@gmail.com>

On 12/5/25 16:32, Kathara Sasikumar wrote:
> The zram_lib.sh script uses bash-specific syntax,
> so the shebang must be /bin/bash instead of /bin/sh.

What errors are you seeing without this change?

> 
> Signed-off-by: Kathara Sasikumar <katharasasikumar007@gmail.com>
> ---
>   tools/testing/selftests/zram/zram_lib.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/zram/zram_lib.sh b/tools/testing/selftests/zram/zram_lib.sh
> index 21ec1966de76..16b108db450b 100755
> --- a/tools/testing/selftests/zram/zram_lib.sh
> +++ b/tools/testing/selftests/zram/zram_lib.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>   # SPDX-License-Identifier: GPL-2.0-or-later
>   # Copyright (c) 2015 Oracle and/or its affiliates. All Rights Reserved.
>   #

thanks,
-- Shuah

      reply	other threads:[~2025-12-31 20:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 23:32 Kathara Sasikumar
2025-12-31 20:11 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b780e63-b1cb-4496-8bc0-94c9d051766e@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=katharasasikumar007@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®