From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECCC71E49F for ; Tue, 9 Dec 2025 05:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765256536; cv=none; b=sBh8HGeyHsTjo3xtykDdne5sLSpBFdPBf1flGrIa3U7+GQutshukf4bQkrPCZFD3z+js15VNDOTMiSUV3xqP4gtUq7D0fDRSmzATPkVAC+acAqwNhOwWmB7XvFSWQQacKxFXUNlUCRBXGazAW3taVxrfrk1Hic6GN901k0UoIMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765256536; c=relaxed/simple; bh=i/E8NqFYX+FtRYbeAzrMOV+c808Z1Yr+re4Tbnjd+qA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=scKXqw4b4B47n/9tF+CXbtpHlES5cgr5FmwJLiEixvmjWDXmw2vcPxbp8zHtL6gzAwBbvavb5gHgqC2FwsAahZXMmR/8pYwGV7o56gur1XnI5ySEpCN5Jnar8aNxH3ZMlVCSsb5bbybTJE7B6wvkpIDb6h5vfjXNGHqWWDzv7LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N5klPZ/1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fOrqR3ks; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N5klPZ/1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fOrqR3ks" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B8NXdB62430574 for ; Tue, 9 Dec 2025 05:02:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jc4jv2RNuyXGveHXHTVYyuwtb9MnQoiXlS8KJa9ej4A=; b=N5klPZ/1AvOgjugL nkdxD1LwFil6nKqnTeMQK/1A8D/sf8Hhswkpynx+heqYl/67/jJyDSl7DKEWIcct l2dPBB7fuLjHgQxC5p01wQY+Qv3laQMCtpkH/MhgZUtXIF2Xla+QS1BzleyhrcqA JN8MsaGlrjV9vYDa8WOntoDR3Poa7cTJYCuYylyhjs9YpVom4RKp460YIAZ2T7zv OehClvfmc5LF1BjsiXF1uscI6vmSVsHeLLfrl1TO581cXreaNCGflsbbutIuP2Ix NT9oQSXiTRB59ZVaeY0eyuzDASnYEQng0AJRzAaYYuCNyzeFZH4ZF+jy+0PscQ4U tkwVmw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ax2rf1rbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Dec 2025 05:02:12 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b895b520a2so5197677b3a.0 for ; Mon, 08 Dec 2025 21:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765256532; x=1765861332; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jc4jv2RNuyXGveHXHTVYyuwtb9MnQoiXlS8KJa9ej4A=; b=fOrqR3kspiUHj6GfiTJv4IS/OLQkNslWhQ+vWvkfOoS4prtKSlNZmH2RpG0LFSwVEi ExUbtoQhNHxx5QEXsOGnclFmbO6lAGbmapuTkoDx3myx8KifWprv5nMhIwSVD7nyDuo9 LWr0vRwSVwD4R1JAWfJ5GGbrGgnGzrvjy8w+bGaLbjR/p0m0Y33Bw7xxgf/T35DbH5k9 kocUQnBGo4EayweerjyPv9zgur2kL9AS/y/anwnhJ5lz+jTcCcdUJfrDOtoa0ITueuZw l9cMlgpVU1Ujd/TUKx5NB7OAoCoums2zIJV9Lhi2X1bWPAjfx0c50sJauly31zO4qNlT 8Zcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765256532; x=1765861332; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jc4jv2RNuyXGveHXHTVYyuwtb9MnQoiXlS8KJa9ej4A=; b=fMOD4K1htsUCyZukwAs9hyoFXKK7qYgakq739Q+PJLJ1pZTt3lzhWoSu7nk1n2b2iz /Nv14pJLYvbAULB0Es+z9bT5eANxsI60wy+rm2WtFQv6YslXcUEFgC20tlZMNLXf/T0R lI8ThNz6PFoxSawVCbPSEk64SqUcJ466JEA+nH7+AJNP3FMsmBSY9yjm1JJ+Q8HgnPjW q4rE4x4eCfbiJ3fxeFFSSnj3K5Mj1kayubDFJPMO3ISZodkW5BHraCa0yTBORtPSxWfb gLee2dawxdwr9fy+j1vlgxbIRetGl88nVhbkmi0RquQh9Xgg3B356G+xhRd2E+WriEm9 7e5Q== X-Forwarded-Encrypted: i=1; AJvYcCVbGKmHzLDYwES+ae42u0wq1EnIKpG9BtIEQOvpbflB8+nw6snHJ+8rjfZDQt1661Zu6GenSXQMErtZZMM=@vger.kernel.org X-Gm-Message-State: AOJu0YyhEkQxg6N/QOa1T286Bl9wEpogJNzgssfAotZqiXi8S8Ln83+c F+653REFAPzHzEzzXdy3wOwvax6J1GbCiRp2pb/8DUQb+p8OhG5g9GmdcEgwXU9zKMjyPuo3Lkz Ju29OCABxPfzRa7hknspAXdAdFiErvbyQ9nWVjMWcnu0Q98yQh0YewtvIry9s57bxE/k= X-Gm-Gg: ASbGncv9sIYsl7UizROsc+S+IHOZFynFT0Hj7uqQz3xoErzwya6YpaFYbbavQLF3tAM EqDyXKniyBezIqg3xoFol8AR+oCCP16W1UgsTYAtECO4NciFELtQdE/h6EbKLJpBJd8q+lWFWwN 3ubiPCKzGUxLKWaQmjE1h0gT2oz8hS7f6+xa7LQQZM4MbhT8EKIgSrIIDRQO9IBBnVswQu+tFbG wycDI/qvHrdQnb36erO0dRTah7R4hFxTCpwTV4YqZrqSsRTyM2Zgk54fv8/WHuIBjsBGvjU6caP 3sTAlv9CKb8aYSzRzzmZUQqkCI83qGEd8nK8e9MVxf6geD4k9V3mPEbYgqmdde9UR6+fMUH1nFD lYKEfplCz86+c4aEXZyiN3aqPJo3/w4u5ZkGwV9E6J2D6kTfq3hGBluc= X-Received: by 2002:a05:6a00:3981:b0:7e8:4587:e8ae with SMTP id d2e1a72fcca58-7e8c3912445mr8517338b3a.33.1765256531726; Mon, 08 Dec 2025 21:02:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYLdzTPb0B57/9aI4fS+XKXuKcTD/o71EuRLCeGYL7FTGUtSJh8ceVafXGdQFf2b8l3oLSuA== X-Received: by 2002:a05:6a00:3981:b0:7e8:4587:e8ae with SMTP id d2e1a72fcca58-7e8c3912445mr8517312b3a.33.1765256531194; Mon, 08 Dec 2025 21:02:11 -0800 (PST) Received: from [10.152.204.0] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e2aef9f649sm14743547b3a.55.2025.12.08.21.02.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 21:02:10 -0800 (PST) Message-ID: <4b793236-2008-e57f-3257-48a65dae5d8b@oss.qualcomm.com> Date: Tue, 9 Dec 2025 10:32:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] wifi: ath11k: fix qmi memory allocation logic for CALDB region Content-Language: en-US From: Vasanthakumar Thiagarajan To: Alexandru Gagniuc , jjohnson@kernel.org, ath11k@lists.infradead.org, "Rob Herring (Arm)" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jeff Johnson References: <20251206175829.2573256-1-mr.nuke.me@gmail.com> <01a05a49-ae5f-a3ec-7685-02a5f7cb9652@oss.qualcomm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ee0wvrEH c=1 sm=1 tr=0 ts=6937ad54 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=EWcMrb2KQbkG0C4WZugA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: zQ9l0p8XYPX2tkRHbg5cnztfEEMwzUvn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA5MDAzNiBTYWx0ZWRfXzHSOyiBRQwOG j+1kFgQA/tiPWl0dFFEA545qP+zyrwGTNeabJiTFwpk9ZDhQdf883AdpUCStg3yvFmLS8LkejMe RPDkDJL67hg93RaVnsmoIaD7L4gBRn7yrjMS5dx0r25Psjd/ktaotTliJFUbPiMgXOEp5rwtEKm vQMA8Enh2SfTjj2+d4pfn3FHpweVOjvGly8NzPJdQIsOU95bvdLxsqO8cRYkhL8kKCFRpt6rqQU Ljv/ggMQgK5BBnWav8o7k0znjv4r2qxe19WL6jywXvaEcUGyJM7D+nxcPgtLp4JvZp21GhlzwtK cgWulmJO9qbZvaD5XxHPQG0+AFL1wqTA1NXkB40TDQJ6iOOrLWPt9+AKwjEG/PVeW9Waxgw49ZU 53HiiotTXxT7ppEWGhVI6qJ0svAENg== X-Proofpoint-ORIG-GUID: zQ9l0p8XYPX2tkRHbg5cnztfEEMwzUvn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-08_07,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512090036 On 12/8/2025 3:55 PM, Vasanthakumar Thiagarajan wrote: > > > On 12/8/2025 3:38 PM, Vasanthakumar Thiagarajan wrote: >> >> >> On 12/6/2025 11:28 PM, Alexandru Gagniuc wrote: >>> Memory region assignment in ath11k_qmi_assign_target_mem_chunk() >>> assumes that: >>>    1. firmware will make a HOST_DDR_REGION_TYPE request, and >>>    2. this request is processed before CALDB_MEM_REGION_TYPE >>> >>> In this case CALDB_MEM_REGION_TYPE, can safely be assigned immediately >>> after the host region. >>> >>> However, if the HOST_DDR_REGION_TYPE request is not made, or the >> >> AFAICT, this is highly unlikely as HOST_DDR_REGION_TYPE will always be before >> CALDB_MEM_REGION_TYPE. > >>> reserved-memory node is not present, then res.start and res.end are 0, >>> and host_ddr_sz remains uninitialized. The physical address should >>> fall back to ATH11K_QMI_CALDB_ADDRESS. That doesn't happen: >>> >>> resource_size(&res) returns 1 for an empty resource, and thus the if >>> clause never takes the fallback path. ab->qmi.target_mem[idx].paddr >>> is assigned the uninitialized value of host_ddr_sz + 0 (res.start). >>> >>> Use "if (res.end > res.start)" for the predicate, which correctly >>> falls back to ATH11K_QMI_CALDB_ADDRESS. >>> >>> Fixes: 900730dc4705 ("wifi: ath: Use of_reserved_mem_region_to_resource() for >>> "memory-region"") >>> >>> Cc: stable@vger.kernel.org # v6.18 >>> Signed-off-by: Alexandru Gagniuc >>> --- >>>   drivers/net/wireless/ath/ath11k/qmi.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c >>> index aea56c38bf8f3..6cc26d1c1e2a4 100644 >>> --- a/drivers/net/wireless/ath/ath11k/qmi.c >>> +++ b/drivers/net/wireless/ath/ath11k/qmi.c >>> @@ -2054,7 +2054,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base >>> *ab) >>>                   return ret; >>>               } >>> -            if (res.end - res.start + 1 < ab->qmi.target_mem[i].size) { >>> +            if (resource_size(&res) < ab->qmi.target_mem[i].size) { >>>                   ath11k_dbg(ab, ATH11K_DBG_QMI, >>>                          "fail to assign memory of sz\n"); >>>                   return -EINVAL; >>> @@ -2086,7 +2086,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base >>> *ab) >>>               } >>>               if (ath11k_core_coldboot_cal_support(ab)) { >>> -                if (resource_size(&res)) { >>> +                if (res.end > res.start) { >>>                       ab->qmi.target_mem[idx].paddr = >>>                               res.start + host_ddr_sz; >>>                       ab->qmi.target_mem[idx].iaddr = >> >> The rest looks good. >> >> Reviewed-by: Vasanthakumar Thiagarajan >> > > Well, since CALDB_MEM_REGION_TYPE will always come only after HOST_DDR_REGION_TYPE we'll > not be running into this issue in real deployment with ath11k firmware binaries available > in public. > Nevertheless, I agree this is a critical issue to be fixed. There is another patch[1] fixing the same issue a bit differently. Vasanth [1]: https://lore.kernel.org/linux-wireless/20251208200437.14199-1-ansuelsmth@gmail.com/