From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4293C433F5 for ; Mon, 14 Mar 2022 13:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232977AbiCNNZE (ORCPT ); Mon, 14 Mar 2022 09:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbiCNNZB (ORCPT ); Mon, 14 Mar 2022 09:25:01 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C7AF11141 for ; Mon, 14 Mar 2022 06:23:49 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KHHJY0J4NzfYxD; Mon, 14 Mar 2022 21:22:21 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 14 Mar 2022 21:23:47 +0800 Received: from [127.0.0.1] (10.174.177.249) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 14 Mar 2022 21:23:46 +0800 Subject: Re: [PATCH] md: remove unused dm_thin_remove_block() From: Zhiqiang Liu To: , Mike Snitzer CC: , "linux-kernel@vger.kernel.org" , linfeilong , lixiaokeng , wuguanghao , References: Message-ID: <4b7e5e2c-a847-4e40-1f23-de71753fe9e8@huawei.com> Date: Mon, 14 Mar 2022 21:23:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.249] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org friendly ping.. On 2022/2/16 14:37, Zhiqiang Liu wrote: > dm_thin_remove_block() is no longer unused, just remove it. > > Signed-off-by: Zhiqiang Liu > --- > drivers/md/dm-thin-metadata.c | 12 ------------ > drivers/md/dm-thin-metadata.h | 1 - > 2 files changed, 13 deletions(-) > > diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c > index 1a96a07cbf44..986a2dc9a686 100644 > --- a/drivers/md/dm-thin-metadata.c > +++ b/drivers/md/dm-thin-metadata.c > @@ -1740,18 +1740,6 @@ static int __remove_range(struct dm_thin_device *td, dm_block_t begin, dm_block_ > return dm_btree_insert(&pmd->tl_info, pmd->root, keys, &value, &pmd->root); > } > > -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block) > -{ > - int r = -EINVAL; > - > - pmd_write_lock(td->pmd); > - if (!td->pmd->fail_io) > - r = __remove(td, block); > - pmd_write_unlock(td->pmd); > - > - return r; > -} > - > int dm_thin_remove_range(struct dm_thin_device *td, > dm_block_t begin, dm_block_t end) > { > diff --git a/drivers/md/dm-thin-metadata.h b/drivers/md/dm-thin-metadata.h > index 7ef56bd2a7e3..4d7a2caf21d9 100644 > --- a/drivers/md/dm-thin-metadata.h > +++ b/drivers/md/dm-thin-metadata.h > @@ -166,7 +166,6 @@ int dm_pool_alloc_data_block(struct dm_pool_metadata *pmd, dm_block_t *result); > int dm_thin_insert_block(struct dm_thin_device *td, dm_block_t block, > dm_block_t data_block); > > -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block); > int dm_thin_remove_range(struct dm_thin_device *td, > dm_block_t begin, dm_block_t end); >