From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A0CC43381 for ; Fri, 8 Mar 2019 18:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5983E20857 for ; Fri, 8 Mar 2019 18:44:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J7PryVhi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728793AbfCHSo0 (ORCPT ); Fri, 8 Mar 2019 13:44:26 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43109 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbfCHSo0 (ORCPT ); Fri, 8 Mar 2019 13:44:26 -0500 Received: by mail-pf1-f195.google.com with SMTP id q17so14757821pfh.10; Fri, 08 Mar 2019 10:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pWKsfU6uHrqj8Xp57otNa8SgRd7j9D+JruyXQoS4C+8=; b=J7PryVhiC3L5Kw1/wXL8l4nuDZuoaj7I20RspOVysIu5btxPSbdq48a+SdFj2wtXcP cxL7KmPJ7fEOd811aM98rvAyZTOGUpKCjygH2nAabQ4vtA1AYi9itcAdQN+dpuPS0xpA 4m3pGVB8VteZJ7/oAM2vD4gfb/hqz7pJs1by/MjFHuRMNFk6vPO8S1fq7bRspPTYzEQg ij3bhMWID4mgp6sKJX1DWBdRfOLFfbXtwtBlc+NU4oYBeg0kATV7X3Ax/VBaZtlhfYMU Vo1CGK42eBVx0bL7OZt+RO14+SpOJJxbv36CyfCJsE+8i5p8qYnTKniAR5dzrHbMuyU0 RoVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pWKsfU6uHrqj8Xp57otNa8SgRd7j9D+JruyXQoS4C+8=; b=UEK+VzzQ0lawylTDYkKniGmOZ2c57AFgFNrgp8qzPGW6pt9Vo2dy4pVlpd/T+lln2j o5ykZEAQuYShRdDFIy+zFWwBbJLx8lgmzo1bWqZd2Y/nNc057CPPl4aPiUqgFyjxXOyu NAilTppacaELwxveXtw7kdTK4dEC8Iu0M4ojjVwO1Zf1z5xYcCKE6YAQe152vE8mz30H Ec6wmXbE697vowGlmPwzHRbUjjB4bPOMYnC3ZEkfHX0TjQLrGWz1zYfkQGS4Mt2G+suX c3inIBujks6P/vJmSAtrqVGIaFpHIEYTThm33B7iB+8V47U7TOtSACfs7gxJ7x4fWUIr EuHQ== X-Gm-Message-State: APjAAAUR3kPEvg6d1itZtWa6KoA6+K0usQ1cdFznk/Qf2FCF+rsitqKm FEBjEvzTZqxgQm3YqpSgnPWq9zay X-Google-Smtp-Source: APXvYqy70jPZlEiat9AXN03sQbiDWCXLL+hcoN8rN2C+SgXIZRt9it5LjhHZQ3fibTCMIXMlRt0ubg== X-Received: by 2002:a62:aa08:: with SMTP id e8mr19803840pff.139.1552070664567; Fri, 08 Mar 2019 10:44:24 -0800 (PST) Received: from [10.67.50.31] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id f10sm9288043pgo.55.2019.03.08.10.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 10:44:23 -0800 (PST) Subject: Re: [PATCH v6 0/3] Stingray thermal driver support To: Srinath Mannam , Eduardo Valentin Cc: Ray Jui , Daniel Lezcano , Zhang Rui , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , BCM Kernel Feedback , linux-pm@vger.kernel.org References: <1546505734-24527-1-git-send-email-srinath.mannam@broadcom.com> <20190205235811.GA19687@localhost.localdomain> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <4b8324a6-1d02-983c-7d4c-d824b57d8675@gmail.com> Date: Fri, 8 Mar 2019 10:44:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/19 8:20 PM, Srinath Mannam wrote: > Hi Eduardo, > > Could you please provide your review comments? So it sounds like this driver was included in a pull request to Linus for 5.1 [1], although I did not see a response to that patch series, which would have helped synchronize the Device Tree changes and send them to Linus as well... I will see if the ARM SoC folks will accept a late request, most likely they would not. Eduardo, can you include replies to patches when you applies those to your tree that way we know whether/when to take the corresponding DTS changes? Thank you. [1]: https://git.kernel.org/torvalds/c/9f24a81e2e5daf8820c8654afcd8512e797c41f2 > > Regards, > Srinath. > > On Wed, Feb 6, 2019 at 5:28 AM Eduardo Valentin wrote: >> >> Hello, >> >> On Mon, Feb 04, 2019 at 04:16:19PM -0800, Ray Jui wrote: >>> Hi Zhang/Eduardo, >>> >>> Can this patch series be merged? It looks like Srinath has addressed all >>> review comments? >> >> I will take a look. Side note, thermal patches are reviewed on >> linux-pm@vger.kernel.org. Copying that list it does help because that >> is how the patches get assigned in patchwork.kernel.org. >> >>> >>> The following tag should be added to the binding document patch: >>> >>> Reviewed-by: Rob Herring >>> >>> Thanks, >>> >>> Ray >>> >>> On 1/3/2019 12:55 AM, Srinath Mannam wrote: >>>> These patches adds the stingray thermal driver and its >>>> corresponding DT nodes with documentation. >>>> >>>> Changes from v5 >>>> - Addressed Eduardo Valentin comments. >>>> >>>> Changes from v4 >>>> - Addressed Rob Herring comments on DT parameters and >>>> thermal driver architecture. >>>> - Removed brcm,max-crit-temp DT parameter >>>> - Changed driver to thermal sensor registration model. >>>> - Added trip DT properties. >>>> >>>> Changes from v3 >>>> - Addressed Daniel lezcano comments. >>>> - Elaborated commit description of thermal driver patch. >>>> - Added brcm,max-crit-temp DT parameter. >>>> >>>> Changes from v2: >>>> - All stingray TMON DT nodes are combine together into single. >>>> Temperature registers are combined into one mem resource. >>>> brcm,tmon-mask parameter has available TMONs mask value. >>>> - All available TMONs are initialized together in single >>>> instance of driver probe call. >>>> >>>> Changes from v1: >>>> - Fixed auto build sparce warning. >>>> >>>> Pramod Kumar (3): >>>> dt-bindings: thermal: Add binding document for SR thermal >>>> thermal: broadcom: Add Stingray thermal driver >>>> arm64: dts: stingray: Add Stingray Thermal DT support. >>>> >>>> .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++++ >>>> .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++++ >>>> drivers/thermal/Kconfig | 3 +- >>>> drivers/thermal/broadcom/Kconfig | 9 ++ >>>> drivers/thermal/broadcom/Makefile | 1 + >>>> drivers/thermal/broadcom/sr-thermal.c | 122 +++++++++++++++++++++ >>>> 6 files changed, 328 insertions(+), 1 deletion(-) >>>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>>> create mode 100644 drivers/thermal/broadcom/sr-thermal.c >>>> -- Florian