From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <fenghua.yu@intel.com>,
<reinette.chatre@intel.com>, <tglx@linutronix.de>,
<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
<yanjiewtw@gmail.com>, <babu.moger@amd.com>,
<kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<eranian@google.com>, <james.morse@arm.com>
Subject: [PATCH v5 07/20] x86/resctrl: Introduce the interface to display monitor mode
Date: Wed, 3 Jul 2024 16:48:18 -0500 [thread overview]
Message-ID: <4b8e3a4dcd8b6c7d7ce80a54cd2a129cbd2eedda.1720043311.git.babu.moger@amd.com> (raw)
In-Reply-To: <cover.1720043311.git.babu.moger@amd.com>
The ABMC feature provides an option to the user to assign a hardware
counter to an RMID and monitor the bandwidth as long as it is assigned.
ABMC mode is enabled by default when supported. System can be one mode
at a time (Legacy monitor mode or ABMC mode).
Provide an interface to display the monitor mode on the system.
$cat /sys/fs/resctrl/info/L3_MON/mbm_mode
[abmc]
legacy
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v5: Changed interface name to mbm_mode.
It will be always available even if ABMC feature is not supported.
Added description in resctrl.rst about ABMC mode.
Fixed display abmc and legacy consistantly.
v4: Fixed the checks for legacy and abmc mode. Default it ABMC.
v3: New patch to display ABMC capability.
---
Documentation/arch/x86/resctrl.rst | 30 ++++++++++++++++++++++++++
arch/x86/kernel/cpu/resctrl/monitor.c | 2 ++
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 26 ++++++++++++++++++++++
3 files changed, 58 insertions(+)
diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
index 30586728a4cd..108e494fd7cc 100644
--- a/Documentation/arch/x86/resctrl.rst
+++ b/Documentation/arch/x86/resctrl.rst
@@ -257,6 +257,36 @@ with the following files:
# cat /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config
0=0x30;1=0x30;3=0x15;4=0x15
+"mbm_mode":
+ Reports the list of assignable monitoring features supported. The
+ enclosed brackets indicate which feature is enabled.
+ ::
+
+ cat /sys/fs/resctrl/info/L3_MON/mbm_mode
+ [abmc]
+ legacy
+
+ The bandwidth monitoring feature on AMD system only guarantees that
+ RMIDs currently assigned to a processor will be tracked by hardware.
+ The counters of any other RMIDs which are no longer being tracked
+ will be reset to zero. The MBM event counters return "Unavailable"
+ for the RMIDs that are not tracked by hardware. So, there can be
+ only limited number of groups that can give guaranteed monitoring
+ numbers. With ever changing configurations there is no way to
+ definitely know which of these groups are being tracked for certain
+ point of time. Users do not have the option to monitor a group or
+ set of groups for certain period of time without worrying about
+ RMID being reset in between.
+
+ The ABMC feature provides an option to the user to assign a
+ hardware counter to an RMID and monitor the bandwidth as long as
+ it is assigned. The assigned RMID will be tracked by the hardware
+ until the user unassigns it manually. There is no need to worry
+ about counters being reset during this period.
+
+ Without ABMC enabled, monitoring will work in "legacy" mode
+ without assignment option.
+
"max_threshold_occupancy":
Read/write file provides the largest value (in
bytes) at which a previously used LLC_occupancy
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 12793762ca24..6c4cb36b4b50 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -1245,6 +1245,8 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
}
}
+ resctrl_file_fflags_init("mbm_mode", RFTYPE_MON_INFO);
+
l3_mon_evt_init(r);
r->mon_capable = true;
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 471fc0dbd7c3..3988d7b86817 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -845,6 +845,26 @@ static int rdtgroup_rmid_show(struct kernfs_open_file *of,
return ret;
}
+static int rdtgroup_mbm_mode_show(struct kernfs_open_file *of,
+ struct seq_file *s, void *v)
+{
+ struct rdt_resource *r = of->kn->parent->priv;
+
+ if (r->mon.abmc_capable) {
+ if (resctrl_arch_get_abmc_enabled()) {
+ seq_puts(s, "[abmc]\n");
+ seq_puts(s, "legacy\n");
+ } else {
+ seq_puts(s, "abmc\n");
+ seq_puts(s, "[legacy]\n");
+ }
+ } else {
+ seq_puts(s, "[legacy]\n");
+ }
+
+ return 0;
+}
+
#ifdef CONFIG_PROC_CPU_RESCTRL
/*
@@ -1901,6 +1921,12 @@ static struct rftype res_common_files[] = {
.seq_show = mbm_local_bytes_config_show,
.write = mbm_local_bytes_config_write,
},
+ {
+ .name = "mbm_mode",
+ .mode = 0444,
+ .kf_ops = &rdtgroup_kf_single_ops,
+ .seq_show = rdtgroup_mbm_mode_show,
+ },
{
.name = "cpus",
.mode = 0644,
--
2.34.1
next prev parent reply other threads:[~2024-07-03 21:49 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:48 [PATCH v5 00/20] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2024-07-03 21:48 ` [PATCH v5 01/20] x86/cpufeatures: Add support for " Babu Moger
2024-07-12 21:55 ` Reinette Chatre
2024-07-15 18:36 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 02/20] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2024-07-03 21:48 ` [PATCH v5 03/20] x86/resctrl: Consolidate monitoring related data from rdt_resource Babu Moger
2024-07-12 21:57 ` Reinette Chatre
2024-07-15 19:05 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 04/20] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2024-07-12 22:04 ` Reinette Chatre
2024-07-15 20:04 ` Moger, Babu
2024-07-16 15:11 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 05/20] x86/resctrl: Introduce resctrl_file_fflags_init() to initialize fflags Babu Moger
2024-07-12 22:04 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 06/20] x86/resctrl: Add support to enable/disable AMD ABMC feature Babu Moger
2024-07-12 22:05 ` Reinette Chatre
2024-07-16 15:13 ` Moger, Babu
2024-07-16 17:51 ` Reinette Chatre
2024-07-16 18:48 ` Moger, Babu
2024-07-16 20:41 ` Reinette Chatre
2024-07-18 21:11 ` Moger, Babu
2024-08-16 16:29 ` James Morse
2024-07-03 21:48 ` Babu Moger [this message]
2024-07-12 22:06 ` [PATCH v5 07/20] x86/resctrl: Introduce the interface to display monitor mode Reinette Chatre
2024-07-16 16:51 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 08/20] x86/resctrl: Introduce interface to display number of monitoring counters Babu Moger
2024-07-03 21:48 ` [PATCH v5 09/20] x86/resctrl: Initialize monitor counters bitmap Babu Moger
2024-07-12 22:07 ` Reinette Chatre
2024-07-16 17:59 ` Moger, Babu
2024-07-26 22:48 ` Peter Newman
2024-07-26 23:53 ` Moger, Babu
2024-08-01 21:05 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 10/20] x86/resctrl: Introduce mbm_total_cfg and mbm_local_cfg Babu Moger
2024-07-12 22:08 ` Reinette Chatre
2024-07-16 19:21 ` Moger, Babu
2024-07-16 20:42 ` Reinette Chatre
2024-07-16 22:43 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 11/20] x86/resctrl: Remove MSR reading of event configuration value Babu Moger
2024-07-12 22:10 ` Reinette Chatre
2024-07-16 19:34 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 12/20] x86/resctrl: Add data structures and definitions for ABMC assignment Babu Moger
2024-07-12 22:13 ` Reinette Chatre
2024-07-16 20:24 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 13/20] x86/resctrl: Add the interface to assign hardware counter Babu Moger
2024-07-12 22:09 ` Reinette Chatre
2024-07-16 20:45 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 14/20] x86/resctrl: Add the interface to unassign " Babu Moger
2024-07-03 21:48 ` [PATCH v5 15/20] x86/resctrl: Assign/unassign counters by default when ABMC is enabled Babu Moger
2024-07-12 22:10 ` Reinette Chatre
2024-07-16 20:58 ` Moger, Babu
2024-07-26 23:22 ` Peter Newman
2024-07-26 23:57 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 16/20] x86/resctrl: Report "Unassigned" for MBM events in ABMC mode Babu Moger
2024-07-12 22:13 ` Reinette Chatre
2024-07-16 21:04 ` Moger, Babu
2024-07-13 20:26 ` Markus Elfring
2024-07-03 21:48 ` [PATCH v5 17/20] x86/resctrl: Introduce the interface switch between monitor modes Babu Moger
2024-07-12 22:14 ` Reinette Chatre
2024-07-16 22:46 ` Moger, Babu
2024-07-13 7:15 ` Markus Elfring
2024-07-03 21:48 ` [PATCH v5 18/20] x86/resctrl: Enable AMD ABMC feature by default when supported Babu Moger
2024-07-12 22:15 ` Reinette Chatre
2024-07-16 23:23 ` Moger, Babu
2024-07-26 0:16 ` Moger, Babu
2024-08-01 21:40 ` Reinette Chatre
2024-07-03 21:48 ` [PATCH v5 19/20] x86/resctrl: Introduce interface to list monitor states of all the groups Babu Moger
2024-07-12 22:16 ` Reinette Chatre
2024-07-17 15:22 ` Moger, Babu
2024-08-01 21:37 ` Reinette Chatre
2024-08-02 16:10 ` Moger, Babu
2024-07-03 21:48 ` [PATCH v5 20/20] x86/resctrl: Introduce interface to modify assignment states of " Babu Moger
2024-07-12 22:17 ` Reinette Chatre
2024-07-17 16:22 ` Moger, Babu
2024-07-25 0:03 ` Peter Newman
2024-07-25 1:22 ` Moger, Babu
2024-07-25 17:11 ` Peter Newman
2024-07-25 17:28 ` Moger, Babu
2024-08-01 18:56 ` Reinette Chatre
2024-08-01 19:40 ` Moger, Babu
2024-07-12 22:03 ` [PATCH v5 00/20] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Reinette Chatre
2024-07-17 17:19 ` Moger, Babu
2024-08-01 21:49 ` Reinette Chatre
2024-08-01 22:45 ` Peter Newman
2024-08-02 16:13 ` Reinette Chatre
2024-08-02 18:49 ` Moger, Babu
2024-08-02 19:13 ` Peter Newman
2024-08-02 20:23 ` Moger, Babu
2024-08-02 18:49 ` Peter Newman
2024-08-02 20:38 ` Moger, Babu
2024-08-02 20:55 ` Reinette Chatre
2024-08-02 22:50 ` Peter Newman
2024-08-14 17:37 ` Reinette Chatre
2024-08-15 23:06 ` Peter Newman
2024-08-16 1:45 ` Reinette Chatre
2024-08-03 0:49 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8e3a4dcd8b6c7d7ce80a54cd2a129cbd2eedda.1720043311.git.babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=jithu.joseph@intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yanjiewtw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®