From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, vincent.guittot@linaro.org,
linux-kernel@vger.kernel.org, kprateek.nayak@amd.com,
juri.lelli@redhat.com, vschneid@redhat.com, tglx@linutronix.de,
dietmar.eggemann@arm.com, anna-maria@linutronix.de,
frederic@kernel.org, wangyang.guo@intel.com
Subject: Re: [PATCH v3 1/3] sched/fair: Move checking for nohz cpus after time check
Date: Fri, 9 Jan 2026 20:44:18 +0530 [thread overview]
Message-ID: <4b8e64ef-8f7c-4978-91f3-a23bab109cc5@linux.ibm.com> (raw)
In-Reply-To: <20260108124443.GA2490257@noisy.programming.kicks-ass.net>
Hi Peter. Thanks for going through.
On 1/8/26 6:14 PM, Peter Zijlstra wrote:
> On Wed, Jan 07, 2026 at 12:21:23PM +0530, Shrikanth Hegde wrote:
>> NOHZ idle load balancer is kicked off only after time check. So move
>> the atomic read after the time check to access it only when needed.
>>
>> When there are no idle CPUs(100% busy), even if the flag gets set to
>> NOHZ_STATS_KICK | NOHZ_NEXT_KICK, find_new_ilb will fail and
>> there will be no NOHZ idle balance. The current behaviour is retained.
>>
>> Note: This patch doesn't solve any cacheline overheads. No improvement
>> in performance apart from saving a few cycles of atomic_read.
>
> Note that atomic_read() == READ_ONCE() is just a regular load, but sure.
Cool. thanks. Let me keep it in the series then.
next prev parent reply other threads:[~2026-01-09 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 6:51 [PATCH v3 0/3] sched/fair: Improve nohz fields for large systems Shrikanth Hegde
2026-01-07 6:51 ` [PATCH v3 1/3] sched/fair: Move checking for nohz cpus after time check Shrikanth Hegde
2026-01-08 12:44 ` Peter Zijlstra
2026-01-09 15:14 ` Shrikanth Hegde [this message]
2026-01-07 6:51 ` [PATCH v3 2/3] sched/fair: Change likelyhood of nohz.nr_cpus Shrikanth Hegde
2026-01-07 6:51 ` [PATCH v3 3/3] sched/fair: Remove nohz.nr_cpus and use weight of cpumask instead Shrikanth Hegde
2026-01-09 14:44 ` Valentin Schneider
2026-01-09 15:15 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8e64ef-8f7c-4978-91f3-a23bab109cc5@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=anna-maria@linutronix.de \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wangyang.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®