From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF62C433FE for ; Sat, 5 Nov 2022 09:54:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiKEJyP (ORCPT ); Sat, 5 Nov 2022 05:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiKEJyM (ORCPT ); Sat, 5 Nov 2022 05:54:12 -0400 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2242D18B21 for ; Sat, 5 Nov 2022 02:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QO/uh1tfrB1vZ/birVU9li3LJoDhOtqTeKkjmuQEcpU=; b=f8PZKPFaPnsa8knKT47i9fE0mj aPMGaxO8zVXZyxJw7hhyjdY4uvNrXmbqRHSafTyZWk/g8BzjhCu914LSe3zgUxxIsg+6gYlyIIyO7 lDHZlOIyJGF9WsoQWnE4Cl/1UtZdjggV34hs38KfCrXqNmSrljZff2IkB7ocrp4Gy9K/dCuaeFeuj DkWey3994d15MZEeU9o/P8W8QrYdwL7LQnJEIG6Z+t8EQgXAN2Ksnf9RirKKbjp92ni2CIiIrgqw4 WqLxmEJSQtVJTAm5xnBVPkhwwKPnnmMnofe+rOmye/FM633hokTlk13EMWHPa/1DhC6+Im2uTGbWs QLgtsy7w==; Received: from [2a01:799:95a:cb00:749c:a195:60ac:1a6b] (port=61208) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orFsN-0003Pc-4Z; Sat, 05 Nov 2022 10:54:07 +0100 Message-ID: <4b97cc9b-4143-2a2f-f431-a7ea83a2e945@tronnes.org> Date: Sat, 5 Nov 2022 10:54:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4a 31/38] timers: drm: Use timer_shutdown_sync() for on stack timers To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20221105060024.598488967@goodmis.org> <20221105060200.540142479@goodmis.org> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20221105060200.540142479@goodmis.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 05.11.2022 07.00, skrev Steven Rostedt: > From: "Steven Rostedt (Google)" > > Before a timer is released, timer_shutdown_sync() must be called. > > Link: https://lore.kernel.org/all/20221104054053.431922658@goodmis.org/ > > Cc: "Noralf Trønnes" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: dri-devel@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Steven Rostedt (Google) > --- Acked-by: Noralf Trønnes > drivers/gpu/drm/gud/gud_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c > index 7c6dc2bcd14a..08429bdd57cf 100644 > --- a/drivers/gpu/drm/gud/gud_pipe.c > +++ b/drivers/gpu/drm/gud/gud_pipe.c > @@ -272,7 +272,7 @@ static int gud_usb_bulk(struct gud_device *gdrm, size_t len) > > usb_sg_wait(&ctx.sgr); > > - if (!del_timer_sync(&ctx.timer)) > + if (!timer_shutdown_sync(&ctx.timer)) > ret = -ETIMEDOUT; > else if (ctx.sgr.status < 0) > ret = ctx.sgr.status;