From: Jeremy Linton <jeremy.linton@arm.com>
To: "tarumizu.kohei@fujitsu.com" <tarumizu.kohei@fujitsu.com>,
'Sudeep Holla' <sudeep.holla@arm.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control
Date: Thu, 7 Jul 2022 09:37:57 -0500 [thread overview]
Message-ID: <4b99cf3c-f40b-cba7-2fa2-b6b311859776@arm.com> (raw)
In-Reply-To: <OSBPR01MB2037E92722D372D48F54438E80269@OSBPR01MB2037.jpnprd01.prod.outlook.com>
Hi,
On 2/1/22 05:56, tarumizu.kohei@fujitsu.com wrote:
>> I am assuming this is ACPI enabled system.
>
> Yes, it is ACPI enabled system.
>
>> This looks bit hacky in my opinion. Before I explore better way of adding it, I would
>> like to check if you have explored ways to add PPTT reading these registers from
>> UEFI/EDK2 as PPTT has other topology information which you will need anyways.
>> That would simplify handling of these cacheinfo sysfs in the kernel. Let me know
>> what are your thoughts ?
>
> The latest firmware of ARM64 machine, FX700 with the A64FX processor
> does not support PPTT.
> I think adding PPTT is the best way to generate cacheinfo sysfs.
> However, it is difficult to modify the firmware to add PPTT, so
> it is not clear when it will be possible.
> Therefore, I would like to implement the function in the kernel on
> the condition that firmware does not support PPTT.
As a bit of a late comment here, I assume you tried injecting the PPTT
via the initrd (directions in
admin-guide/acpi/initrd_table_override.txt) then? That is one of the
usual kernel workarounds for broken/missing ACPI tables.
As mentioned above, besides not providing appropriate topology
information to userspace, not having the PPTT is also possibly causing
suboptimal scheduling decisions in the kernel itself.
next prev parent reply other threads:[~2022-07-07 14:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 7:14 [PATCH 0/8] Add hardware prefetch control driver for arm64 and x86 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 1/8] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 2/8] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 3/8] arm64: Add hardware prefetch control support for ARM64 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 4/8] arm64: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-01-29 17:03 ` Randy Dunlap
2022-02-01 12:04 ` tarumizu.kohei
2022-01-25 7:14 ` [PATCH 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu
2022-01-26 10:36 ` Sudeep Holla
2022-02-01 11:56 ` tarumizu.kohei
2022-07-07 14:37 ` Jeremy Linton [this message]
2022-07-07 14:44 ` Sudeep Holla
2022-07-08 10:21 ` tarumizu.kohei
2022-01-25 7:14 ` [PATCH 6/8] x86: Add hardware prefetch control support for x86 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 7/8] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 8/8] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu
2022-01-25 15:12 ` [PATCH 0/8] Add hardware prefetch control driver for arm64 and x86 Dave Hansen
2022-01-26 9:24 ` tarumizu.kohei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b99cf3c-f40b-cba7-2fa2-b6b311859776@arm.com \
--to=jeremy.linton@arm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=tarumizu.kohei@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®