From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E73A920CCE5; Thu, 7 Nov 2024 11:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.248 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730980027; cv=none; b=NsehTddno2xJ3jzBB99MvVh/nGpdJoueu6b2ootnL99UqUThkdlqJxrX3gWAQ74+vNTMcq/87b8TVEupxlnoGJw29aINcjhl3FT/UcDvqPxcGZv5R9jTMb+ay6Z+8a2TyNMybVZGBZ8nrCIvYAO8FjhYhl3T5i376Wra6l+kZYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730980027; c=relaxed/simple; bh=bnwzNBP8ZJfOAco7LigBE2mD4HbfIWSCWFRvpgZnDMQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=GkW9B5BQ64YnMwfO7Gq3FDY3JQvh2kEybhQgwROqvpQfV/OwRBorj2sp2wRr/ze4xUZ9URqNMkRPbz5jwgA+wSN4gohWnwVLeth7lPOZ2bMv1u4Nstbet30DkH1ybzGlSYIIevvxC0j8M7ZcPWsbjX4WTIg4Dqz1ibRe/PTqN78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=rFjzBCsl; arc=none smtp.client-ip=198.47.23.248 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="rFjzBCsl" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4A7Bkka3078743; Thu, 7 Nov 2024 05:46:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1730980006; bh=si9YNXwmhbk/xZY9UvtfCMxk1ivuOWhY4TSic4udOw4=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=rFjzBCslybLDxHd9JeJwgu/nMlq7kg92tbxVcM5Gm8CCOZGMWLZ2EjSI+XnzgsTU/ 0jvtW/aDm4WWeOSwF1ggBU2Dybt2YV5QCljasvHPn4q8HVdRYq+BDL4NaZ7uA0jK3e /IDYJaaV4VlvrvlCNtmAeLv3mnzInXTbFd0monxo= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4A7Bkk6c006313 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Nov 2024 05:46:46 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 7 Nov 2024 05:46:46 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 7 Nov 2024 05:46:46 -0600 Received: from [10.24.69.25] (danish-tpc.dhcp.ti.com [10.24.69.25]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4A7BkfCD118636; Thu, 7 Nov 2024 05:46:42 -0600 Message-ID: <4ba0381b-d30a-4469-a7c4-327f6ac20c9c@ti.com> Date: Thu, 7 Nov 2024 17:16:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: Add clocks for ICSSG To: Krzysztof Kozlowski , , , , , , Vignesh Raghavendra CC: , , , , , , Roger Quadros References: <20241107104557.1442800-1-danishanwar@ti.com> <20241107104557.1442800-2-danishanwar@ti.com> <7f0a73c3-9977-4d07-b996-683ed18e4724@kernel.org> <8156fd61-c476-4b58-b3b2-e8bc4f93035e@ti.com> <2c368f5a-4b58-45de-8140-21b2f7af4d12@kernel.org> Content-Language: en-US From: MD Danish Anwar In-Reply-To: <2c368f5a-4b58-45de-8140-21b2f7af4d12@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 07/11/24 5:14 pm, Krzysztof Kozlowski wrote: > On 07/11/2024 12:36, MD Danish Anwar wrote: >> >> >> On 07/11/24 5:01 pm, Krzysztof Kozlowski wrote: >>> On 07/11/2024 11:45, MD Danish Anwar wrote: >>>> Add clocks, assigned-clocks and assigned-clock-parents for ICSSG >>> >>> Why? We see what you are doing from the diff, no point to repeat it. I >>> don't understand why you are doing it. >>> >>>> >>>> Signed-off-by: MD Danish Anwar >>>> --- >>>> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>>> index 3cb1471cc6b6..cf4c5884d8be 100644 >>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>>> @@ -92,6 +92,17 @@ properties: >>>> description: | >>>> This property is as per sci-pm-domain.txt. >>>> >>>> + clocks: >>>> + items: >>>> + - description: ICSSG_CORE Clock >>>> + - description: ICSSG_ICLK Clock >>>> + >>>> + assigned-clocks: >>>> + maxItems: 1 >>>> + >>>> + assigned-clock-parents: >>>> + maxItems: 1 >>> >>> Why? This is really not needed, so you need to explain why you are doing >>> things differently than entire Linux kernel / DT bindings. >>> >> >> I need to add this to the device tree node >> >> + clocks = <&k3_clks 81 0>, /* icssg0_core_clk */ >> + <&k3_clks 81 20>; /* icssg0_iclk */ >> + assigned-clocks = <&k3_clks 81 0>; >> + assigned-clock-parents = <&k3_clks 81 2>; >> >> But without the above change in the binding I am getting below errors >> while running dtbs check. >> >> /workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@30000000: >> 'assigned-clock-parents', 'assigned-clocks' do not match any of the >> regexes: '^(pru|rtu|txpru)@[0-9a-f]+$', '^pa-stats@[a-f0-9]+$', >> 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$', 'interrupt-controller@[a-f0-9]+$', >> 'mdio@[a-f0-9]+$', 'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', >> 'mii-rt@[a-f0-9]+$', 'pinctrl-[0-9]+' >> +/workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@30080000: >> 'anyOf' conditional failed, one must be fixed: >> >> To fix this warning I added these in the binding and the warnings were >> fixed. > > nah, cannot reproduce. Just be sure you work on recent kernel (last time > you were sending it on some ancient stuff) and your packages are > updated, including dt schema and other kernel dependencies. > I have posted this series on the latest kernel. Base commit 5b913f5d7d7fe0f567dea8605f21da6eaa1735fb Let me check if the schema is up to date or not. I will re test and reply. Thanks for pointing it out. > Best regards, > Krzysztof > -- Thanks and Regards, Danish