From: Mark Brown <broonie@kernel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Cc: Haixu Cui <quic_haixcui@quicinc.com>,
virtio-dev@lists.oasis-open.org, viresh.kumar@linaro.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
hdanton@sina.com, qiang4.zhang@linux.intel.com,
alex.bennee@linaro.org, quic_ztu@quicinc.com
Subject: Re: [RFC PATCH v4 3/3] SPI: Add virtio SPI driver
Date: Tue, 22 Apr 2025 15:19:04 +0100 [thread overview]
Message-ID: <4ba22af1-fffc-46f4-bf42-675b5cda9ddc@sirena.org.uk> (raw)
In-Reply-To: <74698d99-db5b-4ec7-a965-eea2a29e54b1@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Apr 22, 2025 at 11:33:09AM +0530, Mukesh Kumar Savaliya wrote:
> On 4/1/2025 9:06 AM, Haixu Cui wrote:
> > +{
> > + int cs_setup;
> > + int cs_word_delay_xfer;
> > + int cs_word_delay_spi;
> > + int delay;
> > + int cs_hold;
> > + int cs_inactive;
> > + int cs_change_delay;
> Please maintain reverse christmas tree alingment.
> int cs_word_delay_xfer;
> int cs_word_delay_spi;
> int cs_change_delay;
> int cs_inactive;
> int cs_setup;
> int cs_hold;
> int delay;
That's not a requirement for the SPI subsystem at all.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-04-22 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 3:36 [RFC PATCH v4 0/3] Virtio SPI Linux driver Haixu Cui
2025-04-01 3:36 ` [RFC PATCH v4 1/3] virtio: Add ID for virtio SPI Haixu Cui
2025-04-01 3:36 ` [RFC PATCH v4 2/3] virtio-spi: Add virtio-spi.h Haixu Cui
2025-04-22 6:03 ` Mukesh Kumar Savaliya
2025-04-25 8:24 ` Haixu Cui
2025-08-11 13:50 ` Andy Shevchenko
2025-08-11 13:49 ` Andy Shevchenko
2025-08-08 13:26 ` Jyothi Kumar Seerapu
2025-08-11 13:25 ` Haixu Cui
2025-08-11 13:52 ` Andy Shevchenko
2025-04-01 3:36 ` [RFC PATCH v4 3/3] SPI: Add virtio SPI driver Haixu Cui
2025-04-22 6:03 ` Mukesh Kumar Savaliya
2025-04-22 14:19 ` Mark Brown [this message]
2025-04-22 14:27 ` Mukesh Kumar Savaliya
2025-04-25 3:45 ` Haixu Cui
2025-08-11 14:12 ` Andy Shevchenko
2025-04-22 3:14 ` [RFC PATCH v4 0/3] Virtio SPI Linux driver Haixu Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba22af1-fffc-46f4-bf42-675b5cda9ddc@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alex.bennee@linaro.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qiang4.zhang@linux.intel.com \
--cc=quic_haixcui@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®