From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
geert <geert@linux-m68k.org>,
"biju.das.au" <biju.das.au@gmail.com>
Cc: "magnus.damm" <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
Date: Fri, 1 Aug 2025 11:16:12 +0200 [thread overview]
Message-ID: <4ba8a463-43bc-402c-9814-5ef811d4c715@kernel.org> (raw)
In-Reply-To: <TY3PR01MB11346C00F991D3D718D16417A8626A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On 01/08/2025 10:11, Biju Das wrote:
> Hi Geert,
>
> Thanks for the feedback.
>
>> -----Original Message-----
>> From: Geert Uytterhoeven <geert@linux-m68k.org>
>> Sent: 01 August 2025 08:30
>> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
>>
>> Hi Biju,
>>
>> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@gmail.com> wrote:
>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>
>>> Fix typo for deleting node 'channel@0'->'channel0'.
>>>
>>> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
>>> channel 1")
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>
>> Thanks for your patch!
>>
>>> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> @@ -48,7 +48,7 @@ sound_card {
>>> #if (SW_SCIF_CAN || SW_RSPI_CAN)
>>> &canfd {
>>> pinctrl-0 = <&can1_pins>;
>>> - /delete-node/ channel@0;
>>> + /delete-node/ channel0;
>>
>> As pointed out by Rob's bot, you must not delete this node.
>> Instead, set channel0's status to disabled.
>
> OK. Will fix this in next version.
Please TEST your patch before sending it. This would avoid this entire
discussion.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-01 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 12:51 Biju
2025-07-31 23:09 ` Rob Herring (Arm)
2025-08-01 7:30 ` Geert Uytterhoeven
2025-08-01 8:11 ` Biju Das
2025-08-01 9:16 ` Krzysztof Kozlowski [this message]
2025-08-01 10:10 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba8a463-43bc-402c-9814-5ef811d4c715@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®