From: Jens Axboe <axboe@kernel.dk>
To: kernel test robot <lkp@intel.com>, Omar Sandoval <osandov@fb.com>
Cc: LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: a9f38e1dec ("floppy: convert to blk-mq"): INFO: task mount:661 blocked for more than 120 seconds.
Date: Sun, 18 Nov 2018 20:06:25 -0700 [thread overview]
Message-ID: <4baa37de-8ec3-45cb-2a31-f5eff0806f48@kernel.dk> (raw)
In-Reply-To: <5bf0d0d9.2S1lqKo/21KXGcuH%lkp@intel.com>
On 11/17/18 7:39 PM, kernel test robot wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> commit a9f38e1dec107af70d81338332494bf0a1e76597
> Author: Omar Sandoval <osandov@fb.com>
> AuthorDate: Mon Oct 15 09:21:34 2018 -0600
> Commit: Jens Axboe <axboe@kernel.dk>
> CommitDate: Tue Oct 16 09:50:14 2018 -0600
>
> floppy: convert to blk-mq
>
> This driver likes to fetch requests from all over the place, so make
> queue_rq put requests on a list so that the logic stays the same. Tested
> with QEMU.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
>
> Converted to blk_mq_init_sq_queue() and fixed a few spots where the
> tag_set leaked on cleanup.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
This should be fixed by:
commit de7b75d82f70c5469675b99ad632983c50b6f7e7
Author: Jens Axboe <axboe@kernel.dk>
Date: Fri Nov 9 15:58:40 2018 -0700
floppy: fix race condition in __floppy_read_block_0()
which isn't in the tree that you tested. It's in -rc3, and in Linus's
tree since:
commit 59749c2d49bf28df69ac4bcabf1f69b00d3dca59
Merge: 9b5f361ac4a9 8dc765d438f1
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri Nov 16 09:31:59 2018 -0600
Merge tag 'for-linus-20181115' of git://git.kernel.dk/linux-block
--
Jens Axboe
prev parent reply other threads:[~2018-11-19 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 2:39 kernel test robot
2018-11-19 3:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4baa37de-8ec3-45cb-2a31-f5eff0806f48@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=lkp@intel.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®