From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02DAE43BDDD for ; Mon, 24 Aug 2026 14:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581564; cv=none; b=VMD/p3cSwSqKm0OKvHwGM4MGcFS62vYdyyCSE/rneeV9b7czhn/SIm3QEBcHwCPRigwrLBRLUiZ8oT295aDq3iaM98okcdVcVVPo7uSdJms0SzIFvMphB+evYRLlunpBXmluFFRj1rj9Xk4gDTnQGpOxC0tf/8lkjPDPLC6XpzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581564; c=relaxed/simple; bh=1gndqcwixIf69ERl83wZ/ahlq6SVahr40TbASWBQcgI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=upqgZ7OxqYAN9ZVTmbN4MvwlsTWzOw51DlnSeaSRWDBsQkijcRF+KeYqTZVOW3bzdm6/51CZpKDfz3JWP6zolDoSfYGvzldNVwC7wKIo4Zkljnb/KqHzUhLL/KUvvlwDwo8vmaMAtYT85vSGl3IMSplEfcbps9tN+UG3gTUFGW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qtyj8YcU; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qtyj8YcU" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-836d2861a39so48293137b3.2 for ; Mon, 24 Aug 2026 07:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787581562; x=1788186362; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lsHaeoqxnMhy2GB3rUAu2bzr8hj8izpjrzp8bJJzBnk=; b=qtyj8YcUWb3nhbWfFR1yFkoOzDGF3NubYDQbAGYRXxSFU9sFzPTnQXiVe1+L8Ya6Ub Y3ABAv8Skeh07ilRLu2LRwBRetxeZ3YjvOwJoSVd+ieEDuHymyt4KK7PyHaLFCez6/yA CmYhhc3hG7OddFHnmw1Zds95SnjpsFeq6aR4Wpgl5qB23W0fCz4t9iCoDsh/RU+pcBqi epj4aR0lPB6ForXt8ft/Mn+wYMS94Ze0kESzmtAXcUmhlDfYh9lsTD46vBBuJsMneRcq DsveRAU02svpn38yxs09ge518OuI/pVdkv3Knis9TnbAIvU4lDhnuCGaGoZiptRruc5f /2dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787581562; x=1788186362; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lsHaeoqxnMhy2GB3rUAu2bzr8hj8izpjrzp8bJJzBnk=; b=tLdUj6q6a9CxX1TfRyAifTKdzXsEV9xvgXJuIJhwp3J5gM0oYkj1Ua1OoPyDZ9jkWO JaHTXt/kKyaAtdDTbKK7MK/vVYAETHddA7xCAi8NY8RBhF3Wg6y2M+JPQuS0HA7dp7zw xC3/CPBsJuI11hYmHWsgC0eByYMWi4PmH/Uir/2hyKDKiI9u5GrATwJ5BX10KkItHG4J ipiVnuRSBGhxRz10s/hQgwFwcDJuyLO+UxRReEPuBRMZi60XgYJu89pnLjlxojgzNy5w B4Ov2jq7C6og1qi3H5ecH7Q/uG92B8MtjOySAtYt9MgCnK7fPZgRUDfkOlmu4CTRfIo8 cRUg== X-Forwarded-Encrypted: i=1; AHgh+RpN2Zagok4JP0WqSXksN2M0ODY0DJhe6d3yVIXEc5LyQlkIJk9bmW1I08D6abbGlJ6yY1wZwnZ+FQFEi6I=@vger.kernel.org X-Gm-Message-State: AFuF++kcuHFsQkv/y+BZimSJIMD5dOK1bnS7Fx53VqnwM/0n7KufGGmS HB1Ol8Tn42hU2llGd0n9wr8QW271r+PhHcxApVg6scUXKZojFzHla1Q0/BXPom6xwg== X-Gm-Gg: AR+sD12slokik4aqp2ksXedT7uiNO8iRaa4F+ttlyazH3i1TQgjDU507YtM5MdTYDAz F3agvmPIkbZnKZqmebUPNXut2bv28Wut5VN4VJPE92F/WGAG+1MxopVzKUn5AOVFN47XWMjp8wF P8eEfw6rB4qbdlXvB2LXhyayT7uVL5H40nK9wkkr+ymtSqMv8NfQpI4KpI7tvwUEHDU5qIIW37x +s++aZswK1wac5W4QqfLUsKtTYNvPRc1jcotqK+arR4Ox3apQYJdlImnB89Ekytj4egBOv4z0Lr 65cyZED72NgXuZn7iplI/yjs7jei7ssl+OVtYTb6Rrt4mZ00OnM72GdB/xI1+/nRhn3/I3H2dyT CWiQNpRiPQRafsMVzJuKvQfeEH+1Tq3tgXAsQ6cOwHdj+meuDj519q0nCyGtnfsEOn+EvZxE15m xJKQO6r0xRu5wppGfL8Q59Kp2vechl8SkOaAiPQTZ7PvUGJRUgkXj2gIkty9XESJ5w+VYsszqEH PW/vLHohQU3c4RnAwnwVaR9dwEK2F5XuKvO1DDGQaBexuHa X-Received: by 2002:a05:690c:c604:b0:821:1288:f820 with SMTP id 00721157ae682-84c95591347mr57984377b3.4.1787581561128; Mon, 24 Aug 2026 07:26:01 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca68c1b14sm34720667b3.21.2026.08.24.07.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 07:26:00 -0700 (PDT) Date: Mon, 24 Aug 2026 07:25:56 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 14/25] mm/fbatch: no lru_add_drain() nor _all() for memfd_wait_for_pins() In-Reply-To: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Message-ID: <4bad9833-60f5-30fd-098f-3a306722833d@google.com> References: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII memfd_tag_pins() used lru_add_drain(), memfd_wait_for_pins() then used lru_add_drain_all(): remove those calls, no longer useful now that the per-cpu fbatch references are gone. Signed-off-by: Hugh Dickins --- mm/memfd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/memfd.c b/mm/memfd.c index c708d92533f4..064f24dcddaa 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -40,8 +40,6 @@ static void memfd_tag_pins(struct xa_state *xas) struct folio *folio; int latency = 0; - lru_add_drain(); - xas_lock_irq(xas); xas_for_each(xas, folio, ULONG_MAX) { if (!xa_is_value(folio) && memfd_folio_has_extra_refs(folio)) @@ -168,9 +166,7 @@ static int memfd_wait_for_pins(struct address_space *mapping) if (!xas_marked(&xas, MEMFD_TAG_PINNED)) break; - if (!scan) - lru_add_drain_all(); - else if (schedule_timeout_killable((HZ << scan) / 200)) + if (scan && schedule_timeout_killable((HZ << scan) / 200)) scan = LAST_SCAN; xas_set(&xas, 0); -- 2.51.0