From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED4C2836BE for ; Mon, 6 Oct 2025 12:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759755018; cv=none; b=AjKUWXFxJlOgtqJRPlDY1abTnpr2nG0WNfpMSgisa/TK9TCdxy2BV6oi2mJnwUD7yo3krdcRlHKtfLFJ9tkucOOPmvpGoQK2KWHGb39xBZB9MKBEtpxN2neAxFUr+fiBHZMHlwWsVQwK4ytkFfDhRNYlXullWCWFhChgU8Z8X3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759755018; c=relaxed/simple; bh=1+ke2TkHctZOigrivj+U7Q7F20sV5pMDl2nkjiByetM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=OTRIpeoQ/HWfT40AiR+ti/bXX8nneo3BEQ9yfquWHaO0vEzFdtHFM8or9LS3nTBU/z5XUtJ65a9zQGzQBY5LNf/cEbfHfZ3eIc9G5Fye4E/RY2k7EsSKeoyeJrQ2ewtWvFMD77djlK8ozFPUTtriLqFlt2UeAlkLiaQ1wKqKyNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=akLfpc1i; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="akLfpc1i" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-46e3a50bc0fso40359535e9.3 for ; Mon, 06 Oct 2025 05:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759755015; x=1760359815; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=TvDhuie6qY8dt8ec7g1A3HAHuwzFnTbr7gEWQFFeMLg=; b=akLfpc1i4vHLpXIQu7/IBGKFhjAR6cVqc0ts24uQF1GlW+XePrzg9ttrtW8B/lfe0r hSMk8k2KcaQ49lUys7bRRnlXOStad0jZ+XtAo02ALepbVltK2dgDlRovCOiyzXruepdV Eef/8cMwXR7mWjAOXF17GeIL+OEiIXN39L3IBEFHiNftc+RqJSIahVEe+F18XJZBHnJj ZObUb/fOd/GGUoFyxBrTy6UsJ/+6JzBxK23l6v1Osnotvw2GNelKa23JXHgMGk1FrcJp uARvcH1BC0dgEPuduSbo9ynlG7+zmD/IcMWIlCrJOlbxXnOwvzMBtCot+yGWm06ejER0 tsnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759755015; x=1760359815; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TvDhuie6qY8dt8ec7g1A3HAHuwzFnTbr7gEWQFFeMLg=; b=VxPdF63d/0XeXdOKXp2EiwSWxO1uXOvxyIJf9TrjVfsq+KdeV/hQgT8JlEXTCwP0FX bftzfr+7SWb+0if0pxzRluqZvldVnd/9/5XrZGNhDYmuyTXFkAy01AnVEPD7rSYG/xan eJH6Qxa/pHl8JOQAY4RCtEZMNuwjVcOKZXyvY+CQRfjhgL+poXHu0KNi78IPDGF9kkTo YMS4v7Ntu6y2WUrBzdDSMJDzV7e6PHQjlu9kUO6sZYhqnEvsUqOxmJc29AAo9SWOFpKy XW2Z+2JeX1dXsTJ0ixUdafPQmY/lmbhFr/ZAkmmMadzK4x6B5rW091jT8/6fDL6TRpXg bs+w== X-Forwarded-Encrypted: i=1; AJvYcCWMbb1DsQl62Q3K0jE3gsG7zm967q1enGWVB21ip/awmFnOAch5EKKUGz1c4gkCLUB01Mkrt4gwbAXLz1s=@vger.kernel.org X-Gm-Message-State: AOJu0YxJQaKPqjtfWMjCAgwS1TQPxPbO/BpnQnnPh2+aIhq0Cb8g8pqm 24WjMjnEiMESEWApbiYXejPFPnjWII+y2SqZETb3kLr0dCCm7Z1zKfU9v5Qfa1KJHVM= X-Gm-Gg: ASbGncug6D230s7pKr/VL/KUtsV4pEHh3Isg4Nmwblk//5NIVjQ9YuY3Jo504afdSBB 0iLxBZkE95+iVTDrkDkLUGehJZdMQfdzB8btvT4DBgoExQsm+j20jSV7bwl3nfkeaqO9ett6x/G aSsK6RhpDggg28qd7M0jCvaPEwUywC0RSgLj1+ZQxVU3Ns+EVJGrw3ibX/tFXGA6hIg388a5XKO rIeE6OitB/ih7lMkNkSGQYgMZ7HeVN1qSOO4DcUZIwwVlemYBs0VomSLz45vd4Xx9yK0gb6PU3e ET2XyMuLNkojHfLCNXSLDSV4HN2OXywxYKMyrr9XwGh091JCco/aqXvkc2z8dOIj5c08BcHq1xF wPt7gb2QNKFy6iBr7GtdGV8HuWOK3dhW+G3E3z3pvpE29r4mN4jJH6oM74TuqANkpon0OOvPM7i hhL0eyHaGetjmotd16ahqEbEhn/js= X-Google-Smtp-Source: AGHT+IGxYNrhR5rb1hMdZacbBTASV6s/vat0+OUcrWk/mznR4enIUg1haus1BRrmnxmBozboXRQ6Ug== X-Received: by 2002:a05:600c:3b08:b0:46e:396b:f5ae with SMTP id 5b1f17b1804b1-46e7110cf6fmr95364035e9.16.1759755014953; Mon, 06 Oct 2025 05:50:14 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:2dd0:9118:d7f5:51d9? ([2a01:e0a:3d9:2080:2dd0:9118:d7f5:51d9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e723593d8sm173623055e9.11.2025.10.06.05.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 05:50:14 -0700 (PDT) Message-ID: <4bb1c10d-b8fe-485e-b4aa-faa43033be76@linaro.org> Date: Mon, 6 Oct 2025 14:50:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 2/3] phy: qcom: qmp-combo: get the USB3 & DisplayPort lanes mapping from DT To: Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Xilin Wu , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250930-topic-x1e80100-hdmi-v4-0-86a14e8a34ac@linaro.org> <20250930-topic-x1e80100-hdmi-v4-2-86a14e8a34ac@linaro.org> <74446713-15a1-4706-b3c7-801724467575@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <74446713-15a1-4706-b3c7-801724467575@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/6/25 12:08, Konrad Dybcio wrote: > On 9/30/25 9:39 AM, Neil Armstrong wrote: >> The QMP USB3/DP Combo PHY hosts an USB3 phy and a DP PHY on top >> of a combo glue to route either lanes to the 4 shared physical lanes. >> >> The routing of the lanes can be: >> - 2 DP + 2 USB3 >> - 4 DP >> - 2 USB3 >> >> Get the lanes mapping from DT and stop registering the USB-C >> muxes in favor of a static mode and orientation detemined >> by the lanes mapping. >> >> This allows supporting boards with direct connection of USB3 and >> DisplayPort lanes to the QMP Combo PHY lanes, not using the >> USB-C Altmode feature. >> >> Signed-off-by: Neil Armstrong >> --- > > [...] > >> +struct qmp_combo_lane_mapping { >> + unsigned int lanes_count; > > "num_lanes"? Is this significant ? > >> + enum typec_orientation orientation; >> + u32 lanes[4]; >> +}; >> + >> +static const struct qmp_combo_lane_mapping usb3_data_lanes[] = { >> + { 2, TYPEC_ORIENTATION_NORMAL, { 1, 0 }}, >> + { 2, TYPEC_ORIENTATION_REVERSE, { 2, 3 }}, >> +}; >> + >> +static const struct qmp_combo_lane_mapping dp_data_lanes[] = { >> + { 1, TYPEC_ORIENTATION_NORMAL, { 0 }}, >> + { 1, TYPEC_ORIENTATION_REVERSE, { 3 }}, > > This is not corroborated by your bindings change ^ Damn you're right, I'll fix it... > > I'm also frankly not sure whether it's pin 2 or 3 that 1-lane-DP > would be TXd on > >> + { 2, TYPEC_ORIENTATION_NORMAL, { 3, 2 }}, >> + { 2, TYPEC_ORIENTATION_REVERSE, { 0, 1 }}, >> + { 4, TYPEC_ORIENTATION_NORMAL, { 3, 2, 1, 0 }}, >> + { 4, TYPEC_ORIENTATION_REVERSE, { 0, 1, 2, 3 }}, > > Would it be too cheesy to check orientation based like: > > static bool qmpphy_mapping_orient_flipped(u32 *data_lanes) > { > return data_lanes[0] == 0; > } > > ? Do we want a proper check of the property content or some random check ? Sorry I prefer something formal, since perhaps sometime we will have a full lanes remapping available instead of just orientation and if we have some random input it will explose... > >> - ret = qmp_combo_typec_register(qmp); >> - if (ret) >> - goto err_node_put; >> + qmp->qmpphy_mode = QMPPHY_MODE_USB3DP; >> + >> + if (of_find_property(dev->of_node, "mode-switch", NULL) || >> + of_find_property(dev->of_node, "orientation-switch", NULL)) { > > of_property_present() I'll replace with that. Thanks, Neil > > Konrad