From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<hpa@zytor.com>
Subject: Re: [PATCH] x86/boot: drop memset from copy.S
Date: Tue, 8 Jan 2019 16:46:13 +0800 [thread overview]
Message-ID: <4bb8f61a-f93c-4b30-9990-ecf5a8ddc998@cn.fujitsu.com> (raw)
In-Reply-To: <20190107074056.12532-1-caoj.fnst@cn.fujitsu.com>
One more question: in compressed/, for mem*(), it seems we both use the
macros of boot/string.h, and the functions of compressed/string.c. Is
that what we want?
compressed/ is compiled with -O2, so it cannot be told by objdump -d,
but still can be confirmed by nm <*.o>, for example:
$nm arch/x86/boot/compressed/eboot.o
U memcpy
U memset
$nm arch/x86/boot/compressed/pgtable_64.o
# No entry of mem*()
both of eboot.c and pgtable_64.c #include "../string.h", and use some of
mem*(), it is counter-intuitive to me. Very appreciate it someone can
leave a hint.
--
Sincerely,
Cao jin
On 1/7/19 3:40 PM, Cao jin wrote:
> According to objdump output of setup, function memset is not used in
> setup code. Currently, all usage of memset in setup come from macro
> definition of string.h.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> Compiled and booted under x86_64; compiled under i386.
>
> Questions: now there is 2 definition of memcpy, one lies in copy.S,
> another lies in string.h which is mapped to gcc builtin function. Do we
> still need 2 definition? Could we move the content of copy.S to
> boot/string.c?
>
> At first glance, the usage of string.{c.h} of setup is kind of confusing,
> they are also used in compressed/ and purgatory/
>
> arch/x86/boot/copy.S | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/arch/x86/boot/copy.S b/arch/x86/boot/copy.S
> index 15d9f74b0008..5157d08b0ff2 100644
> --- a/arch/x86/boot/copy.S
> +++ b/arch/x86/boot/copy.S
> @@ -33,21 +33,6 @@ GLOBAL(memcpy)
> retl
> ENDPROC(memcpy)
>
> -GLOBAL(memset)
> - pushw %di
> - movw %ax, %di
> - movzbl %dl, %eax
> - imull $0x01010101,%eax
> - pushw %cx
> - shrw $2, %cx
> - rep; stosl
> - popw %cx
> - andw $3, %cx
> - rep; stosb
> - popw %di
> - retl
> -ENDPROC(memset)
> -
> GLOBAL(copy_from_fs)
> pushw %ds
> pushw %fs
>
next prev parent reply other threads:[~2019-01-08 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 7:40 Cao jin
2019-01-07 7:59 ` hpa
2019-01-07 8:52 ` Cao jin
2019-01-08 8:38 ` hpa
2019-01-10 8:28 ` Cao jin
2019-01-08 8:46 ` Cao jin [this message]
2019-01-11 3:40 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb8f61a-f93c-4b30-9990-ecf5a8ddc998@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®