Re: [PATCHv4] dmaengine: tegra210-adma: use platform to ioremap

[Jon Hunter <jonathanh@nvidia.com>]

On 30/06/2026 01:31, Rosen Penev wrote:
> On Wed, Jun 10, 2026 at 1:43 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>>
>> On 09/06/2026 22:25, Rosen Penev wrote:
>>> Simpler to call devm_platform_ioremap_resource() as it returns multiple
>>> error messages for whichever part fails.
>>>
>>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>>> ---
>>>    v4: rebase and reword commit message
>>>    v3: change subject
>>>    v2: reword commit message
>>>    drivers/dma/tegra210-adma.c | 12 +++---------
>>>    1 file changed, 3 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
>>> index ceaee1e33e68..21a381d022cf 100644
>>> --- a/drivers/dma/tegra210-adma.c
>>> +++ b/drivers/dma/tegra210-adma.c
>>> @@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
>>>                }
>>>        } else {
>>>                /* If no 'page' property found, then reg DT binding would be legacy */
>>> -             res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> -             if (res_base) {
>>> -                     tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
>>> -                     if (IS_ERR(tdma->base_addr))
>>> -                             return PTR_ERR(tdma->base_addr);
>>> -             } else {
>>> -                     return dev_err_probe(&pdev->dev, -ENODEV,
>>> -                                          "failed to get memory resource\n");
>>> -             }
>>> +             tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
>>> +             if (IS_ERR(tdma->base_addr))
>>> +                     return PTR_ERR(tdma->base_addr);
>>
>> The dev_err_probe() was purposely added to assist debug. Please don't
>> drop this.
> If you're talking about the memory resource error,
> devm_platform_ioremap_resource() prints
> 
> ret = dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res);

Well technically it is devm_ioremap_resource() that prints the above 
which was not obvious. So clarifying that in the commit message would be 
good.

Jon

-- 
nvpublic