From: Christophe Leroy <chleroy@kernel.org>
To: Haoran lee <470658536@qq.com>
Cc: maddy@linux.ibm.com, npiggin@gmail.com,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mpe@ellerman.id.au
Subject: Re: PATCH: Fix typo recommand in comment
Date: Thu, 13 Nov 2025 20:51:11 +0100 [thread overview]
Message-ID: <4bbfc2ae-2776-485e-8d6f-8f3dbd3f0591@kernel.org> (raw)
In-Reply-To: <tencent_F844A82DB85660D110008F34E54330312A08@qq.com>
Le 01/10/2025 à 16:42, Haoran lee a écrit :
> [Vous ne recevez pas souvent de courriers de 470658536@qq.com. D?couvrez pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ]
>
> From e949fa326c98953fda200fe92c108fa71e334715 Mon Sep 17 00:00:00 2001
> From: Haoran Lee <470658536@qq.com>
> Date: Wed, 15 Oct 2025 10:18:52 +0000
> Subject: [PATCH] powerpc/smu: Fix typo "recommand" in comment
>
> The word "recommand" is incorrect. The correct spelling is "recommend".
>
> Fix the typo in the comment in arch/powerpc/include/asm/smu.h.
Why is it important to correct that as a standalone change ?
If someone reads the text, do you think he/she won't understand the word
because of letter 'a' instead of 'e', allthought the prononciation is
likely the same ?
Do you think it is worst the cost of handling a patch like this ?
Christophe
>
> Signed-off-by: Haoran Lee <470658536@qq.com>
> ---
> arch/powerpc/include/asm/smu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/smu.h b/arch/powerpc/include/asm/smu.h
> index 2ac6ab903023..23b4ed8b4399 100644
> --- a/arch/powerpc/include/asm/smu.h
> +++ b/arch/powerpc/include/asm/smu.h
> @@ -667,7 +667,7 @@ extern struct smu_sdbp_header *smu_sat_get_sdb_partition(unsigned int sat_id,
> * file is opened. poll() isn't implemented yet. The reply will consist
> * of a header as well, followed by the reply data if any. You should
> * always provide a buffer large enough for the maximum reply data, I
> - * recommand one page.
> + * recommend one page.
> *
> * It is illegal to send SMU commands through a file descriptor configured
> * for events reception
> --
> 2.48.1
>
>
prev parent reply other threads:[~2025-11-13 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 14:42 Haoran lee
2025-11-13 19:51 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bbfc2ae-2776-485e-8d6f-8f3dbd3f0591@kernel.org \
--to=chleroy@kernel.org \
--cc=470658536@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®