From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "sashal@kernel.org" <sashal@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] selftests/x86: report a skip when shadow stack cannot be enabled
Date: Thu, 5 Nov 2026 19:08:56 +0000 [thread overview]
Message-ID: <4bc04525a02fd3fbc39b010acba59c4ac53c01b0.camel@intel.com> (raw)
In-Reply-To: <20261105030245.1241500-1-sashal@kernel.org>
On Wed, 2026-11-04 at 22:02 -0500, Sasha Levin wrote:
> test_shadow_stack prints "[SKIP] Could not enable Shadow stack" when
> ARCH_SHSTK_ENABLE fails, as it does on CPUs without shadow stack support
> and on kernels built without CONFIG_X86_USER_SHADOW_STACK, but then exits
> with 1, so the kselftest runner reports a failure.
>
> Exit with KSFT_SKIP instead.
>
> Fixes: 81f30337ef4f ("selftests/x86: Add shadow stack test")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> Found with KernelCI's x86 builds, which leave
> CONFIG_X86_USER_SHADOW_STACK unset. Tested on an AMD EPYC 9655P with
> KernelCI's x86_64 build of next-20261104: the test now exits with 4
> instead of 1.
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
There are some other things labeled SKIP in the same function. But they should
probably actually be FAIL, so the one update done in this patch seems
appropriate.
prev parent reply other threads:[~2026-11-05 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 3:02 Sasha Levin
2026-11-05 19:08 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bc04525a02fd3fbc39b010acba59c4ac53c01b0.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sashal@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®