From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A0A3793A9 for ; Tue, 16 Jun 2026 19:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781639700; cv=none; b=PjnACAuDkHpxU5XwpyYymy3wANg6ElF5GJUNh33R1XACeVecKFzNYeoJd0CopOJqBGqbFoRhUa0oJlOsDq6NAZVkhaYvIZWUkKR8UubKXTM4xxqRAIfuc4Og49MTkc/A/lNQXzwuVlviC0LlYNDWGcQRBjB8HzW7hIxdpJluA7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781639700; c=relaxed/simple; bh=qid9DIArPYwfSjkUFRfV4He3p02CnHhDIZb42+sFGlY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aoqrW607o3xbRQWrrAE8yb51AD8I9Y5i+K9tyiJ74hrcv4UByBLm1jTnu3epNIJtTsGBIUfPNvUk81hfU9Na9VR96+Wu9BD0EU8+RUPPuo/b2kkZK4nVMHVU41wwgrp0Brxrt/QqDvQCzsEPKRK2ScLtWZTT5TTNbEHw1p6K+CY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=DeH9AZyR; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="DeH9AZyR" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-48670d35a87so158415b6e.1 for ; Tue, 16 Jun 2026 12:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781639697; x=1782244497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N2+6heM+av1fkrRkycYCoMgCjrDPvZd+1jLwzGQxKvI=; b=DeH9AZyRfez1dO7Qs9atrTbpGLDSSuku/PFCJ2Y8FaH+nFC1ypu9KCDyqbN+MRP5KB TUnCH+eaYdYYV2hRk4hcpIVOFUpGWXOgXHpOOIIQO0K5EqMjh7EH9YNip2+IL4a+5USI +AvkgtWEnMHDIdge6CiJ1ryIheRtJfVckcg7ooZ75h2AxTrI8wTu8HDBui+DN5Kw1shU yijPT2RblKcjU6jwaaQVcZEkZCRBvhIiWKWIi4/F5LWZErRNkbrs4CaQkoOEu4Ux5svX K5GrM/648oOUWZ4xslqPU6mltU9w591BAY8TPmFefXANV2rN0bvY4PgMDy2GQZSjRLA3 R97g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781639697; x=1782244497; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N2+6heM+av1fkrRkycYCoMgCjrDPvZd+1jLwzGQxKvI=; b=ejr8LEavqU8XbXBXD/pErWya7f8Ir8bYgInPOYpg42uRyIWvyZG1LpB6QcXeX9Kjoi Jmvky904sTXs41AwtYwR6P9i1FGtpJrndcVW0iGLmRjOgxJepQo0kYbHYGbzsPL6mB9/ G8/3sq/tiYDOSNaFiWrdfvaCvqScJJsU+UjNp28VSJLLF1d1qFUTI6/nfl+UedVx7gLj /7DxFQA/HmyAeW+OtKYGfOvIFHFUAFh3DAd1FOTu5XhzBG+i+jo6f2rHA1yhHtxHgFCM GmJjFooDfZ6fz7iXwfoAWrr3CL/36GOnBYHIda+Y91DVW6RLx6uRQX5QCKnZigBCcAPd 3IdA== X-Forwarded-Encrypted: i=1; AFNElJ+UYS5BMkYzhxXlJ4iiDh+TBGMErUy47mB6M0tmFMxPT+Cg4c7f58ANr1yc/KK/9t57GHlceDekAQwmRVA=@vger.kernel.org X-Gm-Message-State: AOJu0YwbxNES7kC9Jb3fDhQX7aq22vR9TfkpQ9KBzzDyoxJwlA6KMdBl 7PfjXf2TCclDZKnXBjGjWDs8YIPrjjTaxUHV2QgDjk3cWZcA9PlbqFc2Z8PQMapTPQ0= X-Gm-Gg: Acq92OFzd2rW60ItpiTYq4QheWCVLPO7Nw/+ZqZrS0FupE66QrbvLl5yhF5KJ6hM0NS 5/PtpcbkeaFyHIKckcvs1pxIuUFag0EmiKPq1j7rjnJeKsl6QlfDfwRiuslNOrkcZ/OWEHrR8ps 4Nj8/eLqBZA8V+wWfJgxsltrrCgDZNb7WzmJ15rHZOTohYYEehHdOInYINVZIJOp2xO/Ah7Kse2 z2uy/iXgWN5KmUqxdINKNThu2A+qqUVSFNYA1cnAEF5SBBu2/7GcuW9gVte250IMdey7FoddUYX tOdknIJOpzG79jRcEo6rVcVVJx7Wl4h3pvzmSJtvKw/i1RF+Q7lPH4KlMpM+sq+vZqDSuB+0gV8 bhAopWdam1KYJqAy1laf3iI79AJIFLmJ+b7hw4KvMEVlngzoVdm81OxCDcJ2JVXfo+BC1toCC6j h7/ebdXMmQweY/eCUyK7JVyZKZPIyT93S80LlII/xjKspGPb5HcsPcDDnZ391io2izPDzJN6I6x g== X-Received: by 2002:a05:6808:5094:b0:479:fca7:465d with SMTP id 5614622812f47-4894636fa63mr100624b6e.30.1781639697065; Tue, 16 Jun 2026 12:54:57 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:28a8:6095:71d2:86eb? ([2600:8803:e7e4:500:28a8:6095:71d2:86eb]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e79f451fe7sm7380732a34.0.2026.06.16.12.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 12:54:56 -0700 (PDT) Message-ID: <4bc99611-4bf1-4797-ba31-6f1d7dee1e1e@baylibre.com> Date: Tue, 16 Jun 2026 14:54:55 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: add ti,ads122c14 To: Conor Dooley Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kurt Borja , Nguyen Minh Tien , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260615-iio-adc-ti-ads122c14-v1-0-e6bdadf7cb2b@baylibre.com> <20260615-iio-adc-ti-ads122c14-v1-1-e6bdadf7cb2b@baylibre.com> <20260616-spoon-ducky-b05e9bf7e999@spud> Content-Language: en-US From: David Lechner In-Reply-To: <20260616-spoon-ducky-b05e9bf7e999@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/16/26 11:07 AM, Conor Dooley wrote: > On Mon, Jun 15, 2026 at 04:59:59PM -0500, David Lechner (TI) wrote: >> Add new bindings for ti,ads122c14 and similar devices. >> >> This is an ADC that is primarily intended for use with temperature >> sensors. There are a few unusual properties because of this. In >> particular, the reference voltage source and current output requirements >> can be different for each measurement, so these are included in the >> channel bindings. >> >> The REFP/REFN reference voltage is usually just connected to a resistor >> that is being driven by the ADC's current outputs, so there is special >> property for this case rather than requiring a regulator to be defined >> to represent that. >> >> ti,vref-source is reused from ti,tlv320adcx140.yaml (otherwise might >> have preferred an enum of strings). >> >> Signed-off-by: David Lechner (TI) >> --- >> .../devicetree/bindings/iio/adc/ti,ads112c14.yaml | 224 +++++++++++++++++++++ >> MAINTAINERS | 7 + >> include/dt-bindings/iio/adc/ti,ads112c14.h | 11 + >> 3 files changed, 242 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml >> new file mode 100644 >> index 000000000000..dc7f37cad772 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c14.yaml >> @@ -0,0 +1,224 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/adc/ti,ads112c14.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments' ADS112C14 and similar ADC chips >> + >> +description: | >> + Supports the following Texas Instruments' ADC chips: >> + - ADS112C14 (16-bit) >> + - ADS122C14 (24-bit) >> + >> + https://www.ti.com/lit/ds/symlink/ads122c14.pdf >> + >> + These chips are primarily designed for use with temperature sensors such as >> + RTDs and thermocouples. The channel bindings reflect this in that each channel >> + represents the conditions required to make a measurement rather than strictly >> + just the physical input channels. >> + >> +maintainers: >> + - David Lechner >> + >> +unevaluatedProperties: false > > Weird positioning of this. IIRC, Rob asked that I do it in this order on another binding a while ago (the reasoning being that it was too far away from properties: otherwise), so I've done it like this on a few bindings now. It doesn't make much difference to me though. > >> + >> +properties: >> + compatible: >> + enum: >> + - ti,ads112c14 >> + - ti,ads122c14 >> + >> + reg: >> + items: >> + - minimum: 0x40 >> + maximum: 0x47 >> + >> + clocks: >> + maxItems: 1 >> + description: Optional external clock connected to GPIO3 pin. >> + >> + avdd-supply: true >> + dvdd-supply: true >> + >> + refp-supply: true >> + refn-supply: true >> + >> + refp-refn-resistor-ohms: > > Missing prefix here and elsewhere. I thought we didn't need a prefix when using standard units. >> + ti,vref-source: >> + description: | >> + Indicates the source for the reference voltage for this channel. >> + 0 - Internal 2.5V reference >> + 1 - Internal 1.25V reference >> + 2 - External reference (REFP-REFN) >> + 3 - AVDD as reference > > My usual complaint here about things you have to make macros for, could > these just be strings from the get-go? As in the commit message, this is an existing property name, so I didn't want to change the type. But I agree that strings are better for this kind of thing so perhaps I should just use a different property name instead so we can do it better.