From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CABBF3B2FD5 for ; Thu, 26 Mar 2026 09:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515889; cv=none; b=R9ACRtbB8dzL3ZZlC8Y+F6xy+UVSB6XDplKga9dtX+KFd7gF+2oqIuisCd0ME6mKmfgiANmE5P84mr4eLXQIjDDci09GnqYQalHSM/pU57gb6c6DP6nZ5EBIwuyTp+XwvYLgAvXwEcnq8sgIvIsLlprf2D/ckQRa91GWO1mBIyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515889; c=relaxed/simple; bh=fac5TGGyDbkeV+/QzYj1NXjCY3JKxaVX8LM0LOivLdo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HLj4VGamQjnlMKoU1HPeVHQfkZmteJk9M6FieOQM7cKeLATVF+C/M3VL3aQue+Ck9d+kCySn5v3RmjESs0XCSTmBT8bcv8t1e/7/aW8LSc87b3RSJ/Qx2BjtaP82F2h5VMVGM5Yhk0sPpx6KzR+dbiUq/G/zfIAY3y22Qt723RY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SKmBJX+P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YcXEEF1J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SKmBJX+P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YcXEEF1J" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62Q67GIj051557 for ; Thu, 26 Mar 2026 09:04:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dm7+IkHm6u3Ao2yPOvX+EC3oSpBBKWxXJu32fAZJmu8=; b=SKmBJX+Prt9utq8F pulv5S/Dzl0T/M/OhuoOry5fWfak9jVzJzptISTfv1yDKRpOysnUbaZdVRNR4pbv syOJd6mQwe1gOwQtfg9l7BuaT6cDuv8Mf63z72uQSgi8tTHpuzZl3elZRLwlRJj0 Ldt/svGvnK1kgkty3J/la8EfJNJ65zPbMUEWmro+fK/soY0U6VfoTffZOIhkIRe4 DkFJ/hKvEoYPJ9NyTMcu1HS20B3jIVRg+q0wWHunvHYs4jhvCKnLFgkSlRWrck3b 0A2q413plVVlGc+v59P1X94X1YwRJG6EIuI1+sL4sASLDEpfg4H0lRFsfxvn603X l0GYPw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4q1t22v6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 09:04:46 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-895375da74bso2771426d6.0 for ; Thu, 26 Mar 2026 02:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774515886; x=1775120686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dm7+IkHm6u3Ao2yPOvX+EC3oSpBBKWxXJu32fAZJmu8=; b=YcXEEF1JiXkIYqnvor+xnRWKySFUwjstOjSPXsOJSjiDZPVyFNTPBWO4xXX3gCebwZ mHTtiupF58GL4BTxqrws4XcCIg0OEQPlSsAiCVIxEQMxM1yX+yqTFCSyUQoUVWAa3U8U N+ARf3oBYYdJX+rm1FItjSlRK1ZOBTJOl0iqnR6NjAKfQDTxAOfAXLciddbXigtE7mEH k5s9htbxznqE7LHVUTL0WcE5/ZcWPvzauRnf+6plvDePETa6DsH01UxBGLlNxrStZoYx D7TYCmKzqXt9BVzDy93FUBxw1uRPyNVHJhcQHt9OeyPKXZ6cpxa5/7IQNTGmUDD5xtf8 Xpkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774515886; x=1775120686; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dm7+IkHm6u3Ao2yPOvX+EC3oSpBBKWxXJu32fAZJmu8=; b=JBaURUM6mg5cHUPip/TkJEHricbhVic4n3oEI7ZvLEgbPwpfKOPzDIWywVgU21+bql bnJLgMaYSfNZaY6zhOZ3YqgRww+ES86JVbpXOHnXszr2R1cRyaS3OM6dS56TkdQxlzfP fLkHQIyHJGD0isZkmlTHo0C/Jh8zI6IuohTDYrWzv9wRr5lKgGsdxwpz14LMjke1c8Fl of8NmGxGU5dSO0CeAetgmQXRNMICQN77zFicth/FfrfbpRK2xXBwFzIJGyyqAq+Q6/7J 7emfdJJTlV4ejdoL0iNbXLk/AGmaBZQMmRYu5YyoUa1zR2r1sJLIFX/CK14cv1biv2Ta P0jw== X-Forwarded-Encrypted: i=1; AJvYcCWnTttr/BtSSxHTgKqD/h1sNcTYGI06qeitgXHHmscKDaNBFwFzpLuD6vPOgwMNOtzJNKPIvqclTRzR7QU=@vger.kernel.org X-Gm-Message-State: AOJu0YwmEFK6x3Muhoj1yOsUnAEYIJ0HLbcP7qEOaN2Mri+Z1AlonE2l 403PQmJ8L30DSvBVnHb1AVvpIGg98QwhjjuOwte7udcZPrmIY13hyWD8G7uQIHwrmyEMH+6MStD hp6tYmJD68BngHuoFTk2tPlqwdvGZsAC7cN2rtIYd4dsB27DfmTaW+Nz6etVrVwntwFA= X-Gm-Gg: ATEYQzye5X2U37E9wGVSqj+bQS8GRSdRZXIeOT4z/flluj1kfZhP4/XQ/jDI4UwcBtD WJ6NlGOjAUoOMnAhzjGUBx3UCIw09dIa0LktL1LrJM9ZFnD3bZ4/RWvCw1Q4geSQcWwT9NVG1E7 fjW9qbmNZlgaSNTlW4466oiJLJwn3q+4aeIOgQZ5Yhj87MAkDXqauIUHne06RDee/EF6qJqWiek 1RwiJGiwpDM7roKWQYQtWntoBfeexNGGBYRspZ/02Ef5M88NpHomC0KwWC6kX9rcQcjmlnPywNW QwbIEEIyM0sFuSEpeIPGcOxDDJ23Y1i7PdaYusgifgxMJzkbRAF/APXswx6LHa7uMMxSSD2mXHb WgiPyV7D9c1lhKPVGZKUMQgOBmi+U//ve89j5+xAmIt7ImVks//nYmhK64cQHb0Bxyy5rnzUB0V Oz2sI= X-Received: by 2002:a05:6214:21c3:b0:89c:cacb:e8fb with SMTP id 6a1803df08f44-89ccacbee74mr55023446d6.7.1774515885662; Thu, 26 Mar 2026 02:04:45 -0700 (PDT) X-Received: by 2002:a05:6214:21c3:b0:89c:cacb:e8fb with SMTP id 6a1803df08f44-89ccacbee74mr55023176d6.7.1774515885035; Thu, 26 Mar 2026 02:04:45 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203ef95csm87773966b.52.2026.03.26.02.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 02:04:44 -0700 (PDT) Message-ID: <4bd0e8fb-a41b-4d56-88d0-c241d6ab431a@oss.qualcomm.com> Date: Thu, 26 Mar 2026 10:04:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] drm/msm/a6xx: Switch to preemption safe AO counter To: Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-2-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=e7cLiKp/ c=1 sm=1 tr=0 ts=69c4f6ae cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=5p6duuq3bivipkMi_LoA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: vn2PJ6s1EBXKKA5hfj1ZC4eWxMS82XbB X-Proofpoint-ORIG-GUID: vn2PJ6s1EBXKKA5hfj1ZC4eWxMS82XbB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA2NSBTYWx0ZWRfX5DFV7hF8/G7Q fh9vkiayw6Q62F+A/ejXYicYOywjDD9QZMHkkVHm7VIMaG61wFxo8q7jXOSud378zF30LhtCwUX qKKN+c3CGL3laROZBy6WUBFtTbTDx9CekwDF81wfixaNPbaMCNXWMRlJdaj7GvSRSTT5QYWkFMG m3z08uquVMM688IWtaUtWd40uT9RZizb/Rg9iTDBg4QagLvHfArXWCv5p7tNy0GxR3Y01sK+7X8 bxOlKEGTADENuomgXnryJk2ba1NM2WuiLji/6HYXxccLEEhJ/0VPLyWgXfU6f6517jpSCPEPtPH OhfKyynQCwensuMasxuyJyl8jAPpfZpThiLC09ElBUvDiSL/1j1qihruyqxiKvpLJNqXG/feOMI 43rjkfrs85jQNNcIrVEOAg2d3fR2AUw0AEwc+fS/8r3te/gcp1p73L4LmHgHEmvT/bNut4HLY5d dpdIeuwdQstdwDYsuiA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260065 On 3/25/26 10:46 PM, Akhil P Oommen wrote: > On 3/24/2026 3:21 PM, Konrad Dybcio wrote: >> On 3/23/26 9:12 PM, Akhil P Oommen wrote: >>> CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't >>> provide accurate data about the 'submit' when preemption is enabled. >>> Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. >>> >>> Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") >>> Signed-off-by: Akhil P Oommen >>> --- >>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>> index 14d5b5e266f7..93bf2c40bfb9 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>> @@ -345,7 +345,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >>> * GPU registers so we need to add 0x1a800 to the register value on A630 >>> * to get the right value from PM4. >>> */ >>> - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, >>> + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, >>> rbmemptr_stats(ring, index, alwayson_start)); >>> >>> /* Invalidate CCU depth and color */ >>> @@ -386,7 +386,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >>> >>> get_stats_counter(ring, REG_A6XX_RBBM_PERFCTR_CP(0), >>> rbmemptr_stats(ring, index, cpcycles_end)); >>> - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, >>> + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, >>> rbmemptr_stats(ring, index, alwayson_end)); >>> >>> /* Write the fence to the scratch register */ >>> @@ -478,10 +478,10 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) >>> >>> if (adreno_is_a8xx(adreno_gpu)) { >>> rbbm_perfctr_cp0 = REG_A8XX_RBBM_PERFCTR_CP(0); >>> - cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_COUNTER; >>> + cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_CONTEXT; >> >> I'm a little worried about mixing the names here - KGSL uses both of >> these registers (A6XX_KERNEL_PROFILE vs A6XX_KERNEL_PROFILE_CONTEXT) >> to track different fields of the struct adreno_drawobj_profile_entry > > But this naming aligns with the HW reg spec. So I prefer to use the same. To make it clear, my confusion comes from: cp_always_on_counter = REG_A8XX_CP_ALWAYS_ON_CONTEXT ^^^^^^^ vs ^^^^^^^ i.e. I'm not saying this is wrong, but rather that the local variable could be renamed as well, to match Konrad