From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38CBA224891; Fri, 29 Aug 2025 06:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448206; cv=none; b=aZTfhHcVfolNz4jv0gWoAyKryelcfAak8fAFK6A5kqfE0JsnU1ZMPxj3iLD9X5TjiKuNXc3c1uviCmoyuG9lypdu3wYiK5fsXAr87IVlK9R9Sh5qHnbw5EypDfOft4cp0lSO49o9/frsavIens92UKharvo4EXd5/zlv+IvjbV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448206; c=relaxed/simple; bh=tXNRQR0LEg3hiIeSSJFfR+V99Lxseu+uUQSYgchwYtI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YBaMxMXSYjzc1YtsuiXL6R7L6n0kvnOkW+Alishx/oPZ1R0LxXVCdsY0+sQipWM9LL2mL4a5tEN/wzopyrbcmk61NW29CarWPoemsueOgws5YsxzZ4Qs3QN/2pqj4G8BWoFNU/7F30+f8I5mOtmdomLoZP7ePQ/QJ6ghnBpEZPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: b4734c5c849f11f0b29709d653e92f7d-20250829 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:6904f771-77b5-4f5f-b470-fdf055c8b617,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6493067,CLOUDID:363845aa8f825743d29eadcc6fd84d5d,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102,TC:nil,Content:0|52,EDM: -3,IP:nil,URL:99|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA :0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: b4734c5c849f11f0b29709d653e92f7d-20250829 Received: from mail.kylinos.cn [(10.44.16.175)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 102524683; Fri, 29 Aug 2025 14:16:31 +0800 Received: from mail.kylinos.cn (localhost [127.0.0.1]) by mail.kylinos.cn (NSMail) with SMTP id C3FDAE008FA5; Fri, 29 Aug 2025 14:16:30 +0800 (CST) X-ns-mid: postfix-68B145BE-679736167 Received: from [172.25.120.24] (unknown [172.25.120.24]) by mail.kylinos.cn (NSMail) with ESMTPA id D1D0AE008FA4; Fri, 29 Aug 2025 14:16:16 +0800 (CST) Message-ID: <4bd55a08-62bb-46c4-bfb6-a3375ce37e79@kylinos.cn> Date: Fri, 29 Aug 2025 14:16:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/18] cpufreq: brcmstb-avs-cpufreq: Use __free(put_cpufreq_policy) for policy reference To: Viresh Kumar Cc: "Rafael J . wysocki" , Catalin Marinas , Will Deacon , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Markus Mayer , Florian Fainelli , Srinivas Pandruvada , Madhavan Srinivasan , Michael Ellerman , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Daniel Lezcano , Sascha Hauer , Shawn Guo , Eduardo Valentin , Keerthy , Matthias Brugger , AngeloGioacchino Del Regno , zhenglifeng , "H . Peter Anvin" , Zhang Rui , Len Brown , Nicholas Piggin , Christophe Leroy , Lukasz Luba , Pengutronix Kernel Team , Beata Michalska , Fabio Estevam , Pavel Machek , Sumit Gupta , Prasanna Kumar T S M , Sudeep Holla , Yicong Yang , linux-pm@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, linux-acpi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250827023202.10310-1-zhangzihuan@kylinos.cn> <20250827023202.10310-5-zhangzihuan@kylinos.cn> <20250829055944.ragfnh62q2cuew3e@vireshk-i7> From: Zihuan Zhang In-Reply-To: <20250829055944.ragfnh62q2cuew3e@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable =E5=9C=A8 2025/8/29 13:59, Viresh Kumar =E5=86=99=E9=81=93: > On 27-08-25, 10:31, Zihuan Zhang wrote: >> Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy) >> annotation for policy references. This reduces the risk of reference >> counting mistakes and aligns the code with the latest kernel style. >> >> No functional change intended. >> >> Signed-off-by: Zihuan Zhang >> --- >> drivers/cpufreq/brcmstb-avs-cpufreq.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > Applied. Thanks. > Thanks for applying the patch! I=E2=80=99ve been thinking further =E2=80=94 instead of using __free dire= ctly, maybe we=20 could introduce a small macro wrapper around it to make the release=20 scope more controllable and consistent. Link:=20 https://lore.kernel.org/all/6174bcc8-30f5-479b-bac6-f42eb1232b4d@kylinos.= cn/ Do you think this would be a better approach, or should we just stick=20 with the current use of __free?