From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>, linux-iio@vger.kernel.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com
Subject: Re: [PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent
Date: Sun, 4 Dec 2016 11:39:25 +0000 [thread overview]
Message-ID: <4bd7cc64-f429-8234-9e6a-144bd445b36f@kernel.org> (raw)
In-Reply-To: <1480817983-32359-6-git-send-email-masneyb@onstation.org>
On 04/12/16 02:19, Brian Masney wrote:
> The alignment of the #defines at the top of the file is not consistent.
> This changes all of the defines to use consistent alignment to improve
> the code readability.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Skipped patch 4 for now, but this one still applies fine so applied to the
togreg branch of iio.git.
Will push out as testing later.
> ---
> drivers/staging/iio/light/isl29028.c | 42 ++++++++++++++++++------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e96a8cb..d5b069e 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -27,38 +27,38 @@
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
>
> -#define ISL29028_CONV_TIME_MS 100
> +#define ISL29028_CONV_TIME_MS 100
>
> -#define ISL29028_REG_CONFIGURE 0x01
> +#define ISL29028_REG_CONFIGURE 0x01
>
> -#define ISL29028_CONF_ALS_IR_MODE_ALS 0
> -#define ISL29028_CONF_ALS_IR_MODE_IR BIT(0)
> -#define ISL29028_CONF_ALS_IR_MODE_MASK BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_ALS 0
> +#define ISL29028_CONF_ALS_IR_MODE_IR BIT(0)
> +#define ISL29028_CONF_ALS_IR_MODE_MASK BIT(0)
>
> -#define ISL29028_CONF_ALS_RANGE_LOW_LUX 0
> +#define ISL29028_CONF_ALS_RANGE_LOW_LUX 0
> #define ISL29028_CONF_ALS_RANGE_HIGH_LUX BIT(1)
> -#define ISL29028_CONF_ALS_RANGE_MASK BIT(1)
> +#define ISL29028_CONF_ALS_RANGE_MASK BIT(1)
>
> -#define ISL29028_CONF_ALS_DIS 0
> -#define ISL29028_CONF_ALS_EN BIT(2)
> -#define ISL29028_CONF_ALS_EN_MASK BIT(2)
> +#define ISL29028_CONF_ALS_DIS 0
> +#define ISL29028_CONF_ALS_EN BIT(2)
> +#define ISL29028_CONF_ALS_EN_MASK BIT(2)
>
> -#define ISL29028_CONF_PROX_SLP_SH 4
> -#define ISL29028_CONF_PROX_SLP_MASK (7 << ISL29028_CONF_PROX_SLP_SH)
> +#define ISL29028_CONF_PROX_SLP_SH 4
> +#define ISL29028_CONF_PROX_SLP_MASK (7 << ISL29028_CONF_PROX_SLP_SH)
>
> -#define ISL29028_CONF_PROX_EN BIT(7)
> -#define ISL29028_CONF_PROX_EN_MASK BIT(7)
> +#define ISL29028_CONF_PROX_EN BIT(7)
> +#define ISL29028_CONF_PROX_EN_MASK BIT(7)
>
> -#define ISL29028_REG_INTERRUPT 0x02
> +#define ISL29028_REG_INTERRUPT 0x02
>
> -#define ISL29028_REG_PROX_DATA 0x08
> -#define ISL29028_REG_ALSIR_L 0x09
> -#define ISL29028_REG_ALSIR_U 0x0A
> +#define ISL29028_REG_PROX_DATA 0x08
> +#define ISL29028_REG_ALSIR_L 0x09
> +#define ISL29028_REG_ALSIR_U 0x0A
>
> -#define ISL29028_REG_TEST1_MODE 0x0E
> -#define ISL29028_REG_TEST2_MODE 0x0F
> +#define ISL29028_REG_TEST1_MODE 0x0E
> +#define ISL29028_REG_TEST2_MODE 0x0F
>
> -#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1)
> +#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1)
>
> enum isl29028_als_ir_mode {
> ISL29028_MODE_NONE = 0,
>
next prev parent reply other threads:[~2017-01-08 9:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 2:19 [PATCH 00/19] staging: iio: isl29028: staging cleanups Brian Masney
2016-12-04 2:19 ` [PATCH 01/19] staging: iio: isl29028: remove nested if statements Brian Masney
2016-12-04 11:01 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity() Brian Masney
2016-12-04 11:13 ` Jonathan Cameron
2016-12-04 11:16 ` Jonathan Cameron
2017-01-14 20:00 ` Brian Masney
2017-01-15 14:33 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 03/19] staging: iio: isl29028: remove chip test and defaults from isl29028_chip_init() Brian Masney
2016-12-04 11:23 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 04/19] staging: iio: isl29028: add power management support Brian Masney
2016-12-04 11:37 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent Brian Masney
2016-12-04 11:39 ` Jonathan Cameron [this message]
2016-12-04 2:19 ` [PATCH 06/19] staging: iio: isl29028: made alignment of variables in struct isl29028_chip consistent Brian Masney
2016-12-04 2:19 ` [PATCH 07/19] staging: iio: isl29028: fix alignment of function arguments Brian Masney
2016-12-04 2:19 ` [PATCH 08/19] staging: iio: isl29028: combine isl29028_proxim_get() and isl29028_read_proxim() Brian Masney
2016-12-04 2:19 ` [PATCH 09/19] staging: iio: isl29028: change newlines to improve readability Brian Masney
2016-12-04 2:19 ` [PATCH 10/19] staging: iio: isl29028: remove unused define ISL29028_DEV_ATTR Brian Masney
2016-12-04 2:19 ` [PATCH 11/19] staging: iio: isl29028: made column alignment in isl29028_channels consistent Brian Masney
2016-12-04 11:48 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers Brian Masney
2016-12-05 20:53 ` Dan Carpenter
2016-12-06 0:10 ` Brian Masney
2016-12-06 10:19 ` Dan Carpenter
2016-12-04 2:19 ` [PATCH 13/19] staging: iio: isl29028: move failure logging into isl29028_set_proxim_sampling() Brian Masney
2016-12-04 11:50 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 14/19] staging: iio: isl29028: move failure logging into isl29028_set_als_scale() Brian Masney
2016-12-04 11:51 ` Jonathan Cameron
2016-12-04 2:19 ` [PATCH 15/19] staging: iio: isl29028: made error messages consistent Brian Masney
2016-12-04 2:19 ` [PATCH 16/19] staging: iio: isl29028: remove unnecessary error logging in isl29028_chip_init_and_power_on() Brian Masney
2016-12-04 2:19 ` [PATCH 17/19] staging: iio: isl29028: remove out of memory log message Brian Masney
2016-12-04 2:19 ` [PATCH 18/19] staging: iio: isl29028: remove unnecessary parenthesis Brian Masney
2016-12-04 2:19 ` [PATCH 19/19] staging: iio: isl29028: remove legacy device tree binding Brian Masney
2016-12-04 11:55 ` Jonathan Cameron
2017-01-08 9:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd7cc64-f429-8234-9e6a-144bd445b36f@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®