From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0FBC4167B
	for <linux-kernel@archiver.kernel.org>; Sun, 26 Nov 2023 16:45:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230259AbjKZQpj (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 26 Nov 2023 11:45:39 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49416 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229437AbjKZQpg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 26 Nov 2023 11:45:36 -0500
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0EF39C;
        Sun, 26 Nov 2023 08:45:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition:
        Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From:
        Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:
        Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition:
        In-Reply-To:References; bh=j2jPT/9rr9kXvPsTQ11nJwwxmOX/0wSB95nubK+OrHc=; b=56
        ++GXxvk0aycH3l+IA1TCnmFUQtlOctVh1L+hFZhIePl6+oxXNV8sbIcBwNipOqqaKfHBNfQ6Gj3vU
        IPDQFgHwbRIKCY9CJ1v5t5qUWDqmphWDvf7a8S/F+S+8Gpre76Q/+TBabmvea6DcgqU0t7w06ebRq
        eVm5PwlyUY8u2tU=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1r7IGB-001G8A-Mb; Sun, 26 Nov 2023 17:45:31 +0100
Date:   Sun, 26 Nov 2023 17:45:31 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Tim Harvey <tharvey@gateworks.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] net: dsa: mv88e6xxx: Support LED control
Message-ID: <4bd8642c-988f-4b99-944a-da573d0ef2c3@lunn.ch>
References: <20231123-mv88e6xxx-leds-v1-1-3c379b3d23fb@linaro.org>
 <c8c821f8-e170-44b3-a3f9-207cf7cb70e2@lunn.ch>
 <CACRpkdY+T8Rqg_irkLNvAC+o_QfwO2N+eB9X-y24t34_9Rg3ww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdY+T8Rqg_irkLNvAC+o_QfwO2N+eB9X-y24t34_9Rg3ww@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 26, 2023 at 12:46:03AM +0100, Linus Walleij wrote:
> On Thu, Nov 23, 2023 at 5:13 PM Andrew Lunn <andrew@lunn.ch> wrote:
> 
> > What i would really like to see happen is that the DSA core handles
> > the registration of the LEDs, similar to how phylib does. The DT
> > binding should be identical for all DSA devices, so there is no need
> > for each driver to do its own parsing.
> >
> > There are some WIP patches at
> >
> > https://github.com/lunn/linux.git leds-offload-support-reduced-auto-netdev
> >
> > which implement this. Feel free to make use of them.
> 
> Oh it's quite a lot of patches, I really cannot drive that because there are
> so many things about them that I don't understand the thinking behind...
> But I like what I see!

O.K. Let me dust them off, rebase them on net-next and see what is
missing. You have some fibre things i don't have. I don't have a
machine with fibre so i cannot test that.

	Andrew