From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liang He <windhl@126.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory: of: Add of_node_put() when breaking out of for_each_child_of_node()
Date: Tue, 19 Jul 2022 10:18:31 +0200 [thread overview]
Message-ID: <4be14ed4-17de-a90b-e899-536552d6c3c7@linaro.org> (raw)
In-Reply-To: <20220716025043.447036-1-windhl@126.com>
On 16/07/2022 04:50, Liang He wrote:
> In of_get_ddr_timings() and of_lpddr3_get_ddr_timings(), we should
> add the of_node_put() when breaking out of for_each_child_of_node()
> as it will automatically increase and decrease the refcount.
>
Thank you for your patch. There is something to discuss/improve.
> Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support")
> Fixes: e6b42eb6a66c ("memory: emif: add device tree support to emif driver")
Please split the patches into two separate fixes.
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/memory/of_memory.c | 2 ++
> 1 file changed, 2 insertions(+)
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-19 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 2:50 Liang He
2022-07-19 8:18 ` Krzysztof Kozlowski [this message]
2022-07-19 8:22 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4be14ed4-17de-a90b-e899-536552d6c3c7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®