From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BC62F60CC for ; Tue, 7 Apr 2026 13:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568592; cv=none; b=aL0InFyvkQian5hYpfkgZw8d89k8iUr4AR+QQqAd8efTQ9XiU1I9oLkWeL1HOhz3DwgnVTnkaMVsTqBZ5ELB68L4m4a8rmRRIZXTSuIJtKXq2J++olKFm3ErBCS7j1YK+LNGO0H4L9CUMZVRkXHNz/oKfEZ3ozjfPK7KD/koDGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568592; c=relaxed/simple; bh=24winHpEP6yCscClPL7a8tX85b5mr13n6/UAWQd2++Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bhQoNtsPs/xVp0WVf9QkScJ5V63LkyIqVZ/HDKgzFJKyfbxJPpzYGOPAiIRS3c4nCf9KJT7AugPYGaEKcj0Y27x0y0k81vZHplp4ewtYhAglZkN0FiKEI/HBwcoia2q1I0l34XFUD2p4vjn7BIE+LWRkJyDuhFIGGJAcX34Wa9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pxGcSRL2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gw6GQvV1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pxGcSRL2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gw6GQvV1" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637CeIbu3537314 for ; Tue, 7 Apr 2026 13:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uV0jgDOoisJMOeCaLNDInlnDVtS4gJ+3iRPk9zVjquw=; b=pxGcSRL2NmGi/noF OUKrEHMW+pcnSB+djaGN2gAe5g9XH4Zsdg+6Grp08r0jG4SsV8N+7+OvWDz0H6E0 LWmz4ybvUXF5l9fdVG4zHwYWzrSfyo/22Sk6vwRtkKos0MiSLRzJ/Mp5WPvu54Ko gkRZo81ja7XBpjKpirTQKGs5zBv3jBZMJ817F24aqCrwzUfxKS0H1uRwpGEa9l/f bTrvkOQN8YqQuloIyiczkyP01gmnlzCEXoyeFP7YLas1KeUy8zYncj7CAdOu/VYk SvIv31nBnLYxpLYerZfmy60Pok0HGPFRUOHG3ajZqMDyrMfTdj4Cjt/EHpMn9qv1 /d+zww== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmra2vxv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 13:29:48 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b4bd8e77dso7607361cf.3 for ; Tue, 07 Apr 2026 06:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775568588; x=1776173388; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uV0jgDOoisJMOeCaLNDInlnDVtS4gJ+3iRPk9zVjquw=; b=Gw6GQvV1jqSbWkqq8xvmxNKbwDRciRmqoPRAhAfMtL6kfa0Us5kOd6HPv8ahRKtBMQ NaNKs9nu5njOEQ60ZD9FGY4xD/BCkpeCtXjyhQwfBwbXSA+rOfwJUEGnyANB7CZkCDrP 9JpdgbS+qhihvQ+w4zrUu1Q9fXohkdkz2oKLqIKHU6zMRaQDpE1sqtFcXl/V2ihUbhrE YGKNQ4CmghU+Tvy9vAutIgNGmhlnM4m4HBb1Jx4yarZKKGCfLa9v3/Kyv8H6fOwJppOa NjMlDv340sZ1ehdKP0t4ugLgS+rXh6RqeX6fFkO6VlZE+cY8qRtCqzqcFjJYPOD6cwT7 0thw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775568588; x=1776173388; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uV0jgDOoisJMOeCaLNDInlnDVtS4gJ+3iRPk9zVjquw=; b=D4PlpYftr9j7WHyhTdOsfLx7v2ZfLwY2vx5zVLezabAOWgjmEB1vx6Vpg1JVB+KYPe nkGQ8zp9utcmIBG0kI+kDdoIiLe2TtJDz1C8CjKv7Nl0WvF/t5dk/luA4PDk9X73pu4U 7Ffh+SD8NQLz9D7btoLMoB8wPWYPTZlN/98Ooi9MsnQa0vkZ7lez3+ueaBExM6+EwN0Q cHSj23jVcWSQT6I7qXTj9fk0RFaoFx+cX+OKu6r4Qc7lxXPfncS+h5GmOq+NFFp8Wn4j Bn05r2Ddbckw3/KBTC2CPLmTJ2HdIE4iiqClrFOhvgCkZ9d2gaQcVV3DZk0wGP820Luo 5EZQ== X-Forwarded-Encrypted: i=1; AJvYcCULuzak0ZokzXFVOB/qRF/6mToCw5XkpRR+gjqQqLerjhbKYLSx+TGI2WVeii8SBPghKeXujo6sRYw+zHY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo7wJ1XNcK69qM6EC8DsiT5Iy4edMbDhhrzr4fUNg0pLJsIFxk TVh4zIXqBOdbteP0UUY5AO1klyhPRn3ESEwaDwJjpQFg3AnZhjSbnDtfxCSIeojzR/48X9Lys00 L+QK0TFR1AtMmK2fTGzLZwMJQvdVJFgldrzNslgKBkI3NXzLEhWulITJM2NScdDvtDWA= X-Gm-Gg: AeBDietUBuVEBT0uLQ0DoqgHlWrf2FeTqd24WBNlDrFsoUsskzLzzuycGxsEnYQSsm1 itSghYvJA2GtCiRr7duA+B/wNnlyfD1Oy8S384zJ6WJT9c5ImUFKXFv/ddnqasfyMHa3tCAlbfO OFEFTT1MUDBL7gS8bcmcqUOEdkJDC9jN6E/5Zg2rrVJD2Mzq4BupxU+y3BpszUjxThYEQpCtMFa 8iT88gVOLJ4Ci9j5PKkTNhMHi9Y5yOhC43t1LKno33OYUUlPRKqhWU2GxZ7FK4R8X1yN4aT7EbH o9g6JvqwyHnzfb6lyU2EkM9osI7NjiML8mPjL1Azr8cE9gIz5FNy07ovay+3loc+0W5t5M0mSHk ib60Ey1E5GdnxGo3ALDIuNGnqxHZ/KG9FDAX8IWpK4gpI9HJvhM16nu1wjG02EAGv4zFW+19pja eKMbY= X-Received: by 2002:a05:622a:60c:b0:509:d76:fe73 with SMTP id d75a77b69052e-50d62c8442bmr161891411cf.3.1775568587995; Tue, 07 Apr 2026 06:29:47 -0700 (PDT) X-Received: by 2002:a05:622a:60c:b0:509:d76:fe73 with SMTP id d75a77b69052e-50d62c8442bmr161890971cf.3.1775568587439; Tue, 07 Apr 2026 06:29:47 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cff131csm557563666b.52.2026.04.07.06.29.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 06:29:46 -0700 (PDT) Message-ID: <4be1efbe-ec76-458d-9abf-c24b80a6da4b@oss.qualcomm.com> Date: Tue, 7 Apr 2026 15:29:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] clk: qcom: gcc-sc7280: switch GP clocks to clk_rcg2_gp_ops To: Xilin Wu , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260407-gcc-gpclk-sc7280-v1-1-2445c2f7a539@radxa.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260407-gcc-gpclk-sc7280-v1-1-2445c2f7a539@radxa.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: xTYgHNJJ8HPycQw_zzNEtbVq2pGkONcl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEyNiBTYWx0ZWRfX96JTV7iXD/CN ZO9NLY8IHJvjYf1KvfUFVPunHo5LEyKUq0IqDNwJyxlhHuS8aMH5RZP2zADV9eNOJ5pjUNdLDJQ FCYV28RdNJEMmrhm6pPwpATl8c1ubispEF881Aedx2+YHfF4tJBava5O9FS6tlVCyn7UbPek+s7 mUzILx94W7cI79GZ0HqVsHMxykkw9a7k5PPpWLkG0sgZfpJUddk1/FXN2pV/F9i3GZH76X0wbqv 4r3fCceyyF1lYgJFKKD/KmmgTBYayNiTfHhikK7dA182c2vNpKYCzA6XEayjhVdEUau9pi7Wihw wDu7tPxdv09cp8MQCiiRBMNb/QVYCURSeaSIkEn5ZCCojZXzh6tZXj11j/dVJ7POVKN2FLY7erW 1J/hpAVA+XwU5qnA7fuyglPrfEr2f95chOG6bgUqBZblC6Noo5ZjmTnybTxPVlP9+6GbEQr66xZ 1UxnPoCoJkze5T+J/Vg== X-Authority-Analysis: v=2.4 cv=BKGDalQG c=1 sm=1 tr=0 ts=69d506cd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=ksxQWNrZAAAA:8 a=Moh2RT2aINYzgBBivQcA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=l7WU34MJF0Z5EO9KEJC3:22 X-Proofpoint-GUID: xTYgHNJJ8HPycQw_zzNEtbVq2pGkONcl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070126 On 4/6/26 6:00 PM, Xilin Wu wrote: > The GP1/GP2/GP3 clock sources are general-purpose timer/PWM clocks > that require runtime-computed MND divider values and duty cycle > control. They are currently using clk_rcg2_ops with a frequency table > containing only a few fixed entries (50/100/200 MHz), which: > > - Cannot produce arbitrary frequencies needed for PWM periods > - Bypasses the MND divider (m=0, n=0), making duty cycle control > impossible (MND is in bypass mode, set_duty_cycle returns -EINVAL) > > Switch to clk_rcg2_gp_ops which uses clk_rcg2_calc_mnd() to > dynamically compute optimal M/N/pre_div values from any requested > frequency, and empty the frequency table since it is not used by the > GP ops path. > > Signed-off-by: Xilin Wu > --- > Sending this as RFC, because I'm not sure if all other gcc drivers require > the same change. Possibly! It's only been introduced recently, so it may be that we do a mass update However The introductory commit notes: Limitations: - The driver doesn't select a parent clock (it may be selected by client in device tree with assigned-clocks, assigned-clock-parents properties) which could potentially break some existing users that rely on the clock provider to do it.. > --- > drivers/clk/qcom/gcc-sc7280.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c > index 4502926a2691..e7748c468721 100644 > --- a/drivers/clk/qcom/gcc-sc7280.c > +++ b/drivers/clk/qcom/gcc-sc7280.c > @@ -457,9 +457,6 @@ static struct clk_regmap_mux gcc_usb3_sec_phy_pipe_clk_src = { > }; > > static const struct freq_tbl ftbl_gcc_gp1_clk_src[] = { > - F(50000000, P_GCC_GPLL0_OUT_EVEN, 6, 0, 0), > - F(100000000, P_GCC_GPLL0_OUT_EVEN, 3, 0, 0), > - F(200000000, P_GCC_GPLL0_OUT_ODD, 1, 0, 0), > { } > }; I don't think any of the rcg2_gp ops use the frequency table, you should be able to simply remove it Konrad