From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68486C43387 for ; Tue, 18 Dec 2018 09:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40EEB205C9 for ; Tue, 18 Dec 2018 09:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726482AbeLRJWN (ORCPT ); Tue, 18 Dec 2018 04:22:13 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:32861 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbeLRJWL (ORCPT ); Tue, 18 Dec 2018 04:22:11 -0500 Received: from [192.168.108.68] (unknown [213.36.7.13]) (Authenticated sender: marc.w.gonzalez) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 0299A13F866; Tue, 18 Dec 2018 10:21:42 +0100 (CET) Subject: Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers To: Kalle Valo , Amit Kucheria Cc: LKML , MSM , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Greg Kroah-Hartman , "David S. Miller" , Andrew Morton , Nicolas Ferre , Arnd Bergmann References: <87r2ef701w.fsf@purkki.adurom.net> From: Marc Gonzalez Message-ID: <4be46ec9-4d0c-7380-021d-d03d0ab0c9df@free.fr> Date: Tue, 18 Dec 2018 10:21:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87r2ef701w.fsf@purkki.adurom.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/12/2018 08:42, Kalle Valo wrote: > Amit Kucheria wrote: > >> Several drivers didn't have a specific maintainer (other than the >> subsystem maintainer). Switch to using the 'qcom' and 'msm' regex >> patterns to capture all of them and add exceptions to the couple of >> drivers that contain 'msm' but are not related to qcom hardware. >> >> Thanks to Marc for the idea to use the N regex. >> >> Signed-off-by: Amit Kucheria >> --- >> MAINTAINERS | 14 ++++---------- >> 1 file changed, 4 insertions(+), 10 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 3318f30903b2..c9376030f77a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1929,20 +1929,14 @@ M: Andy Gross >> M: David Brown >> L: linux-arm-msm@vger.kernel.org >> S: Maintained >> -F: Documentation/devicetree/bindings/soc/qcom/ >> -F: arch/arm/boot/dts/qcom-*.dts >> -F: arch/arm/boot/dts/qcom-*.dtsi >> -F: arch/arm/mach-qcom/ >> -F: arch/arm64/boot/dts/qcom/* >> +N: qcom >> +N: msm > > IMHO this is pretty fragile in the long term. For example only due to > historical reasons qualcomm wireless drivers currently under ath > directory but who knows if at some point we switch using qcom (or > qualcomm) directory. I am failing to follow your logic. (IIUC, you are talking about drivers/net/wireless/ath/ath10k) The fact that the "qcom" or "msm" nomenclature is not used for this driver now just means that an explicit F entry is required. The fact that it could be renamed in the future just means that the entry would need to be updated or folded into a more generic matching pattern. What am I missing? > Also the wireless drivers might easily have filenames containing > strings like "msm" or "qcom" (which I assume would match with "N" > rules above). Any driver (not just wireless) might match "msm" or "qcom". These could be excluded with an X directive (as the proposed patch does, in fact). Regards.