From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0525221ADA2 for ; Fri, 11 Jul 2025 08:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752223488; cv=none; b=s8Ubza7F1TGJHafFTS4MJ4Wx/r7hYI2lVe6Kv6ruYKKparIm48Tae/fha13dVSbj0q00TydYUxi6P2zL3EqSAWn+0kp2li0tsokGZwMxV91HuIQbN8LTyWmeR9AptNuRsL3Zdk9gBikwyZ7syU6GwQ0BN111IaHIf706gw8/dWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752223488; c=relaxed/simple; bh=QYqt/VQXRENIw8ufzkxah/mgLiscWn2l8eiPLaEqdtA=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=Kyoj+gCBwzhLw6GDvhzUXDIhZJQvCsd1Q9tmbwmukio8QGc9kB64dqoLnb9SLuWhOeM6ecjdYyyTP11NcIqYvdtYCLRHWmrwNfjLrrFw1+uU0lSQpLVoJFoCxgYj+5D6t0X+WCLwat78rGeJJgjRvzCxmHHDf7i4ZxhrDFyeR8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=f+M6x8Y0; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=TZ8qZah+; arc=none smtp.client-ip=202.12.124.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="f+M6x8Y0"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TZ8qZah+" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id B79D51D00196; Fri, 11 Jul 2025 04:44:44 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Fri, 11 Jul 2025 04:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1752223484; x=1752309884; bh=WF9+3lnjfRQwgjXKff+rlIuGBtZEcHO9FtUjx6kias8=; b= f+M6x8Y0HndHChIkB8MeA9N8XNUieosjoUTIRKrau18t/2QYFOlQWoYitW1TmEb+ rTEhX9DgfWQ3Cyi3d1ib8e0KlG7F4/+K/hWAgh/3zLciRW1CaG+P7fMV82f9qj4F GRsrUGq8/egpnDsrcJm10KjBF2+mIkOyqDv85tJuQgVQWOZSpi5MMuoFfbygHZ6g eufDRX88veq5Yaz0mMnP0ywyLPVu35Dd1V4LLocpQyctzzYdBImDHuzDI5jas1mM +eeFJSDYttr1h5esvRuZQZVMQefAfG7pcAxpDSo8jQVe+pugKJ9gj4S95CHaSvYd znXFzkrMMQbh2ipK0G8U0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1752223484; x= 1752309884; bh=WF9+3lnjfRQwgjXKff+rlIuGBtZEcHO9FtUjx6kias8=; b=T Z8qZah+Cmf8xJp574+jQX3xXwYoX29M3NDYTDUn2Dnh9wSr4LxiC+ginx345EiUj GVomuFeA+AffIM9kApK1kcQqA3RP2LjOqCPVuqKiW6YkLqbFfEDzM3nW7cKloCek 8Ixu0TXh7NaNQos5qmRvN7Zci4WLM+2bVNTDzfqGuCKW4Kv7xiez8tVblgZmlSc7 /AAW2Bdk4QhjZO9ZUDMIer692BwVlW6EMwowk/wqIH3wC8/Y/7JVPgG4mvUpMQfa pGPqvdnYbrJrSiDn4DTuE/Fsyg+YMJc0I1iVx1fIWxt9Fo2aDj2O3dWNVRp3Q114 6dfbC6iPQLy/+qJKc/S7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdegvdekjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopedugedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtghomhdprhgtph htthhopehjrghmvghsrdhmohhrshgvsegrrhhmrdgtohhmpdhrtghpthhtohepjhhovgih rdhgohhulhihsegrrhhmrdgtohhmpdhrtghpthhtohepshhuiihukhhirdhpohhulhhosh gvsegrrhhmrdgtohhmpdhrtghpthhtohephihuiigvnhhghhhuiheshhhurgifvghirdgt ohhmpdhrtghpthhtoheprghrnhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopegsrh hoohhnihgvsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrgiisehkvghrnhgvlhdr ohhrghdprhgtphhtthhopeifihhllheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E762F700068; Fri, 11 Jul 2025 04:44:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: T7965fc80e983b7bf Date: Fri, 11 Jul 2025 10:44:23 +0200 From: "Arnd Bergmann" To: "Marc Zyngier" , "Arnd Bergmann" Cc: "Oliver Upton" , "Catalin Marinas" , "Will Deacon" , "Joey Gouly" , "Suzuki K Poulose" , "Zenghui Yu" , "Mark Brown" , "James Morse" , "Sebastian Ott" , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Message-Id: <4befb9eb-96e6-4a7c-9746-286144564f4e@app.fastmail.com> In-Reply-To: <86h5zj9laj.wl-maz@kernel.org> References: <20250711072752.2781647-1-arnd@kernel.org> <86h5zj9laj.wl-maz@kernel.org> Subject: Re: [PATCH] KVM: arm64: fix u64_replace_bits() usage Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Jul 11, 2025, at 10:36, Marc Zyngier wrote: > On Fri, 11 Jul 2025 08:27:47 +0100, Arnd Bergmann wrote: >> if (hpmn > vcpu->kvm->arch.nr_pmu_counters) { >> hpmn = vcpu->kvm->arch.nr_pmu_counters; >> - u64_replace_bits(val, hpmn, MDCR_EL2_HPMN); >> + val = u64_replace_bits(val, hpmn, MDCR_EL2_HPMN); >> } >> >> __vcpu_assign_sys_reg(vcpu, MDCR_EL2, val); > > This is only in -next, right? Because I have a fix for this already > queued for 6.16, as per [1]. Yes, as far as I can tell, the warning only showed up in linux-next after f66f9c3d09c1 ("bitfield: Ensure the return values of helper functions are checked"). As far as I can tell, Ben added the check in linux/bitfield.h when he sent you his version of the fix, they just ended up in linux-next in the wrong order, so I ended up recreating his original fix slightly differently. Arnd