From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066E3C76195 for ; Mon, 27 Mar 2023 12:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232506AbjC0MZL (ORCPT ); Mon, 27 Mar 2023 08:25:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjC0MZJ (ORCPT ); Mon, 27 Mar 2023 08:25:09 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E0C127; Mon, 27 Mar 2023 05:25:07 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PlX4H2LjLznZJ5; Mon, 27 Mar 2023 20:21:51 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 27 Mar 2023 20:25:04 +0800 Message-ID: <4bf0da8a-008a-7363-d1cd-53e4296e3436@huawei.com> Date: Mon, 27 Mar 2023 20:25:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/2] mailbox: pcc: Add support for platform notification handling To: Sudeep Holla CC: , , , , , , , , , , , , References: <20221016034043.52227-1-lihuisong@huawei.com> <20230314111135.16520-1-lihuisong@huawei.com> <20230314111135.16520-2-lihuisong@huawei.com> <20230327113057.cc2ufila5z25mgic@bogus> From: "lihuisong (C)" In-Reply-To: <20230327113057.cc2ufila5z25mgic@bogus> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/3/27 19:30, Sudeep Holla 写道: > On Tue, Mar 14, 2023 at 07:11:34PM +0800, Huisong Li wrote: >> Currently, PCC driver doesn't support the processing of platform >> notification for type 4 PCC subspaces. >> >> According to ACPI specification, if platform sends a notification >> to OSPM, it must clear the command complete bit and trigger platform >> interrupt. OSPM needs to check whether the command complete bit is >> cleared, clear platform interrupt, process command, and then set the >> command complete and ring doorbell to the Platform. >> >> Let us stash the value of the pcc type and use the same while processing >> the interrupt of the channel. We also need to set the command complete >> bit and ring doorbell in the interrupt handler for the type 4 channel to >> complete the communication flow after processing the notification from >> the Platform. >> >> Signed-off-by: Huisong Li >> --- >> drivers/mailbox/pcc.c | 50 +++++++++++++++++++++++++++++++++++-------- >> 1 file changed, 41 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c >> index 105d46c9801b..a0a87c480d8b 100644 >> --- a/drivers/mailbox/pcc.c >> +++ b/drivers/mailbox/pcc.c >> @@ -91,6 +91,7 @@ struct pcc_chan_reg { >> * @cmd_update: PCC register bundle for the command complete update register >> * @error: PCC register bundle for the error status register >> * @plat_irq: platform interrupt >> + * @type: PCC subspace type >> */ >> struct pcc_chan_info { >> struct pcc_mbox_chan chan; >> @@ -100,12 +101,15 @@ struct pcc_chan_info { >> struct pcc_chan_reg cmd_update; >> struct pcc_chan_reg error; >> int plat_irq; >> + u8 type; >> }; >> >> #define to_pcc_chan_info(c) container_of(c, struct pcc_chan_info, chan) >> static struct pcc_chan_info *chan_info; >> static int pcc_chan_count; >> >> +static int pcc_send_data(struct mbox_chan *chan, void *data); >> + >> /* >> * PCC can be used with perf critical drivers such as CPPC >> * So it makes sense to locally cache the virtual address and >> @@ -221,6 +225,34 @@ static int pcc_map_interrupt(u32 interrupt, u32 flags) >> return acpi_register_gsi(NULL, interrupt, trigger, polarity); >> } >> >> +static bool pcc_mbox_cmd_complete_check(struct pcc_chan_info *pchan) >> +{ >> + u64 val; >> + int ret; >> + >> + ret = pcc_chan_reg_read(&pchan->cmd_complete, &val); >> + if (ret) >> + return false; >> + >> + if (!pchan->cmd_complete.gas) >> + return true; >> + >> + /* >> + * Judge if the channel respond the interrupt based on the value of >> + * command complete. >> + */ >> + val &= pchan->cmd_complete.status_mask; > [super nit] Would prefer an blank line here. > Yeah, it would be better if there is an blank line here. Is it necessary to send v3 for this?