From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597162F069E for ; Fri, 2 Jan 2026 11:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767353212; cv=none; b=SuHTPCky8bfmj/SOIDLvr/otCFnXq76ewIGeMGhv16p5zm9TxFqMEu1lVkBGjPZ2ndsWFun7sYEwil7bOudkiglzoeZjk3frsWJrjslxpGigBm4LWqWrKWbf6fQENVB5U5MqIxuiG/93jSos/1YpIT8X7aLwHazgpPzweuJr//c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767353212; c=relaxed/simple; bh=wZCrrZeNgczJ32sMkjccG8DxRkRnphvQU666PCRG8sM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JZUNTIQGeAa/dhKhAaAfnUNRRMwBVcJXSelFmsbTdxbssy5Un7H7tqA56Un3T7PAn9LOEqqf+FU7G2bmgUck4VopVicRZATBoYq0YYcvtKzt8ItLcPAzz2ZyDsUMx9iuamLkVJNp7RbkxFMhSuxlY8Rjx0He5eQ6Oh6NSA6CAnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cc772S5a; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cc772S5a" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-64b7b737eddso15180684a12.1 for ; Fri, 02 Jan 2026 03:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767353209; x=1767958009; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wZCrrZeNgczJ32sMkjccG8DxRkRnphvQU666PCRG8sM=; b=cc772S5a4VMMUdVSNVwm41kkCgYEgXMQr6YIlJKkgaP4LQvrMPOpAi/v0v+JeM8XD2 W/8Bh5km53LMoX8TOcrXNvtU93GWDJNk6Ll005AtHiw1rjohlik6X2EKzUpGFWBh9SIV CEpo4mo8H1YBusC3JR+rW5CN/yqvnim3TjoHleMXyORMq0GrzXYwUsasqN8ycpQ0WWFG P/CmA86qaS1CQ6UelBIAWMtW4+V5JPO8diHsyMo+paDrq8S5NIm8J4EcBTwS47SssA5r pGntSTkoAqaeHHVIjQi3fYUbGKUvbWMnTz0dxdf0+XVxRWdzJFonIXUTnWYs5EUMDcfo HMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767353209; x=1767958009; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wZCrrZeNgczJ32sMkjccG8DxRkRnphvQU666PCRG8sM=; b=GYMf7XTlfESrDMwFkZTEDwZyMXiZH/Rfp+Bjl9L4aMWuad3rsYGmNokn6wrKVgMJng 6dJ57dtiBN3fbEpu6H91kjncgROTcwAOhjaBhyUUzUU67AmNSAWJ1hcdUbPQOmAahXIY qaJe0fSTgk8z9VSPzhtB8wBG97DuHE5Hr3CnWV33GOqWl3Q9LJMvL+QVjsGyEERKpHhQ m5hi59xUUPs2zxUpxNqUGtXHSPSsPs+F+dApLiXol27BUIy9XsIFMY1IFRE01vSF8zm7 +EYvWE3zsZaWx4w6ONJ6S1AZMN4WHCLeIJ5FsbEuN/EJVjE1iazTqxSpwG46BezqVAqk b8vA== X-Forwarded-Encrypted: i=1; AJvYcCUL1q8SRULslZGNFajrgZUYwxnvbsvB/uzQ0GVlS26flmXzE2YOS056vxyami7aiOQUeZkQoRmHteA+JxY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/EQJOU59LEZNoCRO+xkbb4MBVVXHyKwEUeRXVZC7w23+Ez4TB kRv1DUqOwXMylZGoZHqaTNRXsU/CepM2PCd1m2LWiF9ELikhb+dPAZEMCkXeFWrjcZ0= X-Gm-Gg: AY/fxX6us3jyyHCyIIT/k4z5EkYsdwZLJVMooW65UHWM2jp7vGBr01NYpgFAw2lr91Y YmOu1oGBIcTI7k7Juxg4iis3DS/4+9BxCIHVhbQUgz/beh6c7D57p9jxptf4t6a+OQwm6kmhqgN C/JEs3QlVR+9A33MZ7U+41PDGbIQdZ5FOnt7dryjCdZqB8f7oWcjLh1EPpiXagWkLdHcTdiL6Vw dlOsRcXQ+cgcYpWhGYqaaHyqao9o8jwNanZC4xOQA/py0vdUH2Q1FZXY4M5ZqecgkDNc/wJ5rhP Q7lCwVbEHYnyDWYvhuzPDVoJXmeRlySCkkkAFVE7TqkgL/bkyZdTSwhTqGiM2iQPpv/d/kWsS1J xZp6BaWP3LwLPUCKMG2xUzOTGVf4MyLx7CXlLJQtUvRDvgKz5L5TASr2ztDcG3Q5UzioS7S3OMk XLiqs2QDlV2HVxX7f2Lnb3v1ftqg== X-Google-Smtp-Source: AGHT+IFb1cSu9KLCyJKAobmw+k0POeGJfgr/xC7uOSmUiVHIv6vit6M7ROfPJPxEhme+Gx1mdZY0qg== X-Received: by 2002:a17:907:7e84:b0:b79:fc57:b598 with SMTP id a640c23a62f3a-b8037153443mr3708113166b.36.1767353208658; Fri, 02 Jan 2026 03:26:48 -0800 (PST) Received: from salami.lan ([212.129.80.79]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f7bsm4468179566b.18.2026.01.02.03.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 03:26:48 -0800 (PST) Message-ID: <4bfcb1420b9684f67bd4b8f583313c1a08a1616d.camel@linaro.org> Subject: Re: [PATCH v5 21/21] regulator: s2mps11: enable-gpios is optional on s2mpg1x From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Bartosz Golaszewski Cc: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Krzysztof Kozlowski , Linus Walleij , Peter Griffin , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Date: Fri, 02 Jan 2026 11:26:42 +0000 In-Reply-To: References: <20251227-s2mpg1x-regulators-v5-0-0c04b360b4c9@linaro.org> <20251227-s2mpg1x-regulators-v5-21-0c04b360b4c9@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-01-02 at 11:19 +0100, Bartosz Golaszewski wrote: > On Sat, Dec 27, 2025 at 1:24=E2=80=AFPM Andr=C3=A9 Draszik wrote: > >=20 > > For s2mpg1x, enable-gpios is optional, but when not given, the driver > > is complaining quite verbosely about the missing property. > >=20 > > Refactor the code slightly to avoid printing those messages to the > > kernel log in that case. > >=20 >=20 > I don't get the point of this - you added this function in the same > series, why can't it be done right the first time it's implemented? Sure, I can merge this patch into the refactoring patch 15 - the intention was to have incremental changes to simplify review. Cheers, Andre