mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family
Date: Tue, 2 May 2023 11:51:03 +0200	[thread overview]
Message-ID: <4bfcbde3-c9e1-65a9-4494-3d9bb222a89f@linaro.org> (raw)
In-Reply-To: <CAOX2RU6wwvMLgScAgtqpOuSLeaULUAet4TtjQZkWK_uwwkr2Zw@mail.gmail.com>



On 1.05.2023 23:22, Robert Marko wrote:
> On Mon, 1 May 2023 at 14:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 29.04.2023 21:33, Robert Marko wrote:
>>> Add SOC IDs for the IPQ5018 family.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>>  include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index 802495b20276..c1283bad81e1 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -216,6 +216,9 @@
>>>  #define QCOM_ID_SM8350                       439
>>>  #define QCOM_ID_QCM2290                      441
>>>  #define QCOM_ID_SM6115                       444
>>> +#define QCOM_ID_IPQ5010                      446
>>> +#define QCOM_ID_IPQ5018                      447
>>> +#define QCOM_ID_IPQ5028                      448
>>>  #define QCOM_ID_SC8280XP             449
>>>  #define QCOM_ID_IPQ6005                      453
>>>  #define QCOM_ID_QRB5165                      455
>>> @@ -229,6 +232,9 @@
>>>  #define QCOM_ID_SM8450_3             482
>>>  #define QCOM_ID_SC7280                       487
>>>  #define QCOM_ID_SC7180P                      495
>>> +#define QCOM_ID_IPQ5000                      503
>>
>>> +#define QCOM_ID_IPQ0509                      504
>>> +#define QCOM_ID_IPQ0518                      505
>> Are you sure these names are in tact?
> 
> Hi,
> They should be correct, I am seeing them being used downstream
> and in end products as well, IPQ0509 being one of those weird ones
> that integrate 256MB of RAM on the die as well.
Hmmm.. it's sketchy and weird-sounding, but also appealing in a way

I got caught off-guard with the leading zeroes, but probably qcom
just didn't want to mess with the IPQabcd scheme!

Konrad
> 
> Regards,
> Robert
> 
>>
>> Konrad
>>>  #define QCOM_ID_SM6375                       507
>>>  #define QCOM_ID_IPQ9514                      510
>>>  #define QCOM_ID_IPQ9550                      511
>>> @@ -236,6 +242,7 @@
>>>  #define QCOM_ID_IPQ9570                      513
>>>  #define QCOM_ID_IPQ9574                      514
>>>  #define QCOM_ID_SM8550                       519
>>> +#define QCOM_ID_IPQ5016                      520
>>>  #define QCOM_ID_IPQ9510                      521
>>>  #define QCOM_ID_QRB4210                      523
>>>  #define QCOM_ID_QRB2210                      524
>>> @@ -243,6 +250,7 @@
>>>  #define QCOM_ID_QRU1000                      539
>>>  #define QCOM_ID_QDU1000                      545
>>>  #define QCOM_ID_QDU1010                      587
>>> +#define QCOM_ID_IPQ5019                      569
>>>  #define QCOM_ID_QRU1032                      588
>>>  #define QCOM_ID_QRU1052                      589
>>>  #define QCOM_ID_QRU1062                      590

  reply	other threads:[~2023-05-02  9:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-29 19:33 Robert Marko
2023-04-29 19:33 ` [PATCH 2/2] soc: qcom: socinfo: " Robert Marko
2023-05-01  6:51   ` Krzysztof Kozlowski
2023-05-01  6:50 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Krzysztof Kozlowski
2023-05-01 12:51 ` Konrad Dybcio
2023-05-01 21:22   ` Robert Marko
2023-05-02  9:51     ` Konrad Dybcio [this message]
2023-05-02 17:33       ` Robert Marko
2023-05-02  6:56   ` Krzysztof Kozlowski
2023-05-25  4:54 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bfcbde3-c9e1-65a9-4494-3d9bb222a89f@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®